USB: serial-simple: adding Kaufmann RKS+CAN VCP
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/1 USB: serial-simple: adding Kaufmann RKS+CAN VCP
Adding the device and product ID
The device is a is a CAN bus interface / license dongle The device thus is usable either directly from user space or can be attached to a kernel CAN interface with slcan_attach
v2: improve change log
--- drivers/usb/serial/usb-serial-simple.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/usb/serial/usb-serial-simple.c +7 -0
@@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS); { USB_DEVICE(0x908, 0x0004) }DEVICE (siemens_mpi,SIEMENS_IDS ); +/* KAUFMANN RKS+CAN VCP */ +#define KAUFMANN_IDS () \ + { USB_DEVICE(0x16d0, 0x0870) } +DEVICE (kaufmann,KAUFMANN_IDS ); +/* All of the above structures mushed into two lists */ static struct usb_serial_driver *const serial_drivers[] = { &carelink_device,
@@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = { &hp4x_device, &suunto_device, &siemens_mpi_device, + &kaufmann_device, NULL };
@@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = {HP4X_IDS (),SUUNTO_IDS (),SIEMENS_IDS (), +KAUFMANN_IDS (), { }, };MODULE_DEVICE_TABLE (usb, id_table);
Signature · 1 line
2.41.0
Johan Hovold
maintainerQuoted 4 lines · Oliver Neukum
Adding the device and product ID
The device is a is a CAN bus interface / license dongle The device thus is usable either directly from user space or can be attached to a kernel CAN interface withslcan_attach
I reworded the above slightly and added the missing full stops to make it a bit more readable. The result is here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=66672e61d4a6f8f9011b031d366eeb450fa41117
Quoted 1 line
v2: improve change log
In the future, please keep the changelog below the --- line.
Quoted 32 lines
Reported-by Kaufmann Automotive GmbH <[email protected]>Signed-off-by Oliver Neukum <[email protected]>--- drivers/usb/serial/usb-serial-simple.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/usb/serial/usb-serial-simple.c +6
-0@@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS); { USB_DEVICE(0x908, 0x0004) }DEVICE (siemens_mpi,SIEMENS_IDS ); +/* KAUFMANN RKS+CAN VCP */ +#define KAUFMANN_IDS () \ + { USB_DEVICE(0x16d0, 0x0870) } +DEVICE (kaufmann,KAUFMANN_IDS ); +/* All of the above structures mushed into two lists */ static struct usb_serial_driver *const serial_drivers[] = { &carelink_device,@@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = { &hp4x_device, &suunto_device, &siemens_mpi_device, + &kaufmann_device, NULL };
drivers/usb/serial/usb-serial-simple.c static const struct usb_device_id id_table[] = { · line 163
Quoted 7 lines
drivers/usb/serial/usb-serial-simple.c +1
-0@@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = {HP4X_IDS (),SUUNTO_IDS (),SIEMENS_IDS (), +KAUFMANN_IDS (), { }, };MODULE_DEVICE_TABLE (usb, id_table);
Looks like you forgot to move the new entries to maintain the (approximate) sort order as I asked you to do. I fixed that up before applying.
Johan