Skip to contentSkip to conversation

run_tests: fix verbose

PATCH In review Claudio Imbrenda 2 participants 2 messages Jul 12, 2023 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 run_tests: fix verbose

The "v" and "verbose" options in getopt grew an extra :, which breaks it.

$ ./run_tests.sh -v
getopt: option requires an argument -- v
$ ./run_tests.sh --verbose
getopt: option --verbose requires an argument

Remove the unnecessary :

Fixes 15e441c4 ("run_tests: add list tests name option on command line")
---
 run_tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
run_tests.sh +1 -1
index baf8e461..abb0ab77 100755
@@ -44,7 +44,7 @@ fi
 
 only_tests=""
 list_tests=""
-args=$(getopt -u -o ag:htj:v:l -l all,group:,help,tap13,parallel:,verbose:,list -- $*)
+args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list -- $*)
 [ $? -ne 0 ] && exit 2;
 set -- $args;
 while [ $# -gt 0 ]; do
Signature · 1 line
2.41.0
#1 lore raw
Quoted 31 lines · Claudio Imbrenda

The "v" and "verbose" options in getopt grew an extra :, which breaks it.

$ ./run_tests.sh -v
getopt: option requires an argument -- v
$ ./run_tests.sh --verbose
getopt: option --verbose requires an argument

Remove the unnecessary :

Fixes 15e441c4 ("run_tests: add list tests name option on command line")
---
 run_tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
run_tests.sh +1 -1
index baf8e461..abb0ab77 100755
@@ -44,7 +44,7 @@ fi
 
 only_tests=""
 list_tests=""
-args=$(getopt -u -o ag:htj:v:l -l all,group:,help,tap13,parallel:,verbose:,list -- $*)
+args=$(getopt -u -o ag:htj:vl -l all,group:,help,tap13,parallel:,verbose,list -- $*)
 [ $? -ne 0 ] && exit 2;
 set -- $args;
 while [ $# -gt 0 ]; do
Signature · 1 line
2.41.0

Pushed, thanks!

drew