Skip to contentSkip to conversation

dt-bindings: usb: qcom,dwc3: document extcon property

PATCH In review David Heidelberg 3 participants 3 messages Jul 12, 2023 – Jul 14, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: usb: qcom,dwc3: document extcon property

The driver has support for it already. Only missing bit is dt-binding entry.

---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +4 -0
index 4875c5b7d5b5..7099b583d21c 100644
@@ -107,6 +107,10 @@ properties:
     minItems: 1
     maxItems: 4
 
+  extcon:
+    description:
+      Phandle to the extcon device providing the cable state.
+
   qcom,select-utmi-as-pipe-clk:
     description:
       If present, disable USB3 pipe_clk requirement.
Signature · 1 line
2.40.1
#1 lore raw
Quoted 1 line · David Heidelberg

The driver has support for it already. Only missing bit is dt-binding entry.

No, because the child node already has it. We do not need to extcons for one USB. Also another reason is that it should be deprecated.

Best regards,
Krzysztof

#2 lore raw
Quoted 6 lines · Krzysztof Kozlowski
Quoted 1 line · David Heidelberg

The driver has support for it already. Only missing bit is dt-binding entry.

No, because the child node already has it. We do not need to extcons for one USB. Also another reason is that it should be deprecated.

In the current design of the Linux dwc3 driver we actually need both nodes to be extcon targets, as both device drivers needs to react to the role change. So I think the patch accurately describes the intended design of today.

That said, we do not want to do this for the Type-C case, where we use a full port node. Combined with other reasons, we really should fix the dwc3 driver model so that the core propagates the role changes to the glue drivers, and as such I agree that we shouldn't pick this patch.

Regards,
Bjorn