Skip to contentSkip to conversation

dt-bindings: extcon: extcon-usb-gpio: convert to yaml format

PATCH In review David Heidelberg 4 participants 4 messages Jul 13, 2023 – Jul 15, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: extcon: extcon-usb-gpio: convert to yaml format

---
 .../bindings/extcon/extcon-usb-gpio.txt       | 21 ---------
 .../bindings/extcon/extcon-usb-gpio.yaml      | 45 +++++++++++++++++++
 2 files changed, 45 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt deleted +0 -21
deleted file mode 100644
index dfc14f71e81f..000000000000
@@ -1,21 +0,0 @@
-USB GPIO Extcon device
-
-This is a virtual device used to generate USB cable states from the USB ID pin
-connected to a GPIO pin.
-
-Required properties:
-- compatible: Should be "linux,extcon-usb-gpio"
-
-Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
-- id-gpio: gpio for USB ID pin. See gpio binding.
-- vbus-gpio: gpio for USB VBUS pin.
-
-Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
-	extcon_usb1 {
-		compatible = "linux,extcon-usb-gpio";
-		id-gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>;
-	}
-
-	&omap_dwc3_1 {
-		extcon = <&extcon_usb1>;
-	};
Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml new file +45 -0

45 lines not on this page · raw message

Signature · 1 line
2.40.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines

--------- Original Message ---------
Sender : David Heidelberg <[email protected]>
Date : 2023-07-13 09:25 (GMT+9)
Title : [PATCH] dt-bindings: extcon: extcon-usb-gpio: convert to yaml format

Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt

Quoted 12 lines

---
.../bindings/extcon/extcon-usb-gpio.txt      | 21 --------- .../bindings/extcon/extcon-usb-gpio.yaml      | 45 +++++++++++++++++++

2 files changed, 45 insertions(+), 21 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml

Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt deleted +0 -0
deleted file mode 100644
index dfc14f71e81f..000000000000

[]

Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml

Quoted 5 lines
Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml new file +0 -0
new file mode 100644
index 000000000000..b345745013a2

[]

#3 lore raw
In reply to David Heidelberg

Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml line 10

Quoted 2 lines · David Heidelberg
Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml new file +2 -0
+maintainers:
+  - Linus Walleij <[email protected]>

I don't see why I should be listed for this? I have nothing to do with it, I think.

On the topic:
Can't this just reuse Rob's excellent binding in Documentation/devicetree/bindings/connector/usb-connector.yaml just add id-gpios to it and list const: linux,extcon-usb-gpio as a deprecated compatible.

(Then we should make the Linux driver probe from the existing and better compatibles from that file, but it's a whole other issue.)

Yours,
Linus Walleij