Skip to contentSkip to conversation

soc: microchip: Explicitly include correct DT includes

PATCH In review Rob Herring 2 participants 2 messages Jul 14, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: microchip: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

---
 drivers/soc/atmel/sfr.c                     | 1 -
 drivers/soc/microchip/mpfs-sys-controller.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/soc/atmel/sfr.c +0 -1
index 0525eef49d1a..cc94ca1b494c 100644
@@ -10,7 +10,6 @@
 #include <linux/nvmem-provider.h>
 #include <linux/random.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 
drivers/soc/microchip/mpfs-sys-controller.c +1 -1
index 216d9f4ea0ce..fbcd5fd24d7c 100644
@@ -13,7 +13,7 @@
 #include <linux/module.h>
 #include <linux/jiffies.h>
 #include <linux/interrupt.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/mailbox_client.h>
 #include <linux/platform_device.h>
 #include <soc/microchip/mpfs.h>
Signature · 7 lines
2.40.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
maintainer
#1 lore raw
Quoted 10 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Hmm, usually these go to different places. I'll push them both to the at91 repo.

Quoted 38 lines
---
 drivers/soc/atmel/sfr.c                     | 1 -
 drivers/soc/microchip/mpfs-sys-controller.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/soc/atmel/sfr.c +0 -1
index 0525eef49d1a..cc94ca1b494c 100644
@@ -10,7 +10,6 @@
 #include <linux/nvmem-provider.h>
 #include <linux/random.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 
drivers/soc/microchip/mpfs-sys-controller.c +1 -1
index 216d9f4ea0ce..fbcd5fd24d7c 100644
@@ -13,7 +13,7 @@
 #include <linux/module.h>
 #include <linux/jiffies.h>
 #include <linux/interrupt.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/mailbox_client.h>
 #include <linux/platform_device.h>
 #include <soc/microchip/mpfs.h>
Signature · 7 lines
2.40.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv