Skip to contentSkip to conversation

Add Facebook Yosemite V4 (AST2600) BMC

PATCH Superseded Delphine CC Chiu 2 participants 12 messages Jul 12, 2023 – Jul 18, 2023

Subsystems (3)

v1 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

cover Add Facebook Yosemite V4 (AST2600) BMC

v1 - Add Facebook Yosemite V4 (AST2600) BMC

Delphine CC Chiu (2):
dt-bindings: arm: aspeed: add Facebook Yosemite V4 board
ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

 .../bindings/arm/aspeed/aspeed.yaml           |   1 +
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 570 ++++++++++++++++++
 3 files changed, 572 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Document the new compatibles used on Facebook Yosemite V4.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index e0eff4c05879..2ef6821e3648 100644
@@ -79,6 +79,7 @@ properties:
               - facebook,elbert-bmc
               - facebook,fuji-bmc
               - facebook,greatlakes-bmc
+              - facebook,yosemitev4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
Signature · 1 line
2.25.1
#3 lore raw

PATCH 2/2 ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

In reply to Delphine CC Chiu

Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 570 ++++++++++++++++++
 2 files changed, 571 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts
arch/arm/boot/dts/Makefile +1 -0
index 59829fc90315..871e6d271262 100644
@@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-galaxy100.dtb \
 	aspeed-bmc-facebook-greatlakes.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
+	aspeed-bmc-facebook-yosemitev4.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
 	aspeed-bmc-facebook-wedge40.dtb \
 	aspeed-bmc-facebook-wedge100.dtb \
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +570 -0

570 lines not on this page · raw message

Signature · 1 line
2.25.1
#4 lore raw

Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

Quoted 41 lines · Delphine CC Chiu

Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 570 ++++++++++++++++++
 2 files changed, 571 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts
arch/arm/boot/dts/Makefile +1 -0
index 59829fc90315..871e6d271262 100644
@@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-galaxy100.dtb \
 	aspeed-bmc-facebook-greatlakes.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
+	aspeed-bmc-facebook-yosemitev4.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
 	aspeed-bmc-facebook-wedge40.dtb \
 	aspeed-bmc-facebook-wedge100.dtb \
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +13 -0
new file mode 100644
index 000000000000..1df151fb6ff3
@@ -0,0 +1,570 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2022 Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/i2c/i2c.h>
+
+/ {
+	model = "Facebook Yosemite V4 BMC";
+	compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600";
+

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts line 23

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +10 -0
+	aliases {
+		serial4 = &uart5;
+		serial5 = &uart6;
+		serial6 = &uart7;
+		serial7 = &uart8;
+		serial8 = &uart9;
+	};
+
+	chosen {
+		bootargs = "console=ttyS4,57600n8";

Use stdout-path

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +6 -0
+	};
+
+	memory at 80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};

...

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts line 143

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +6 -0
+
+&i2c0 {
+	status = "okay";
+	bus-frequency = <400000>;
+	multi-master;
+	adm1278 at 40 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts line 153

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +10 -0
+		compatible = "adi,adm1278";
+		reg = <0x40>;
+	};
+};
+
+&i2c1 {
+	status = "okay";
+	bus-frequency = <400000>;
+	multi-master;
+	adm1278 at 40 {

Look, you already got such comment so you are repeating same mistakes.
https://lore.kernel.org/all/a8854c8e-8868-461d-9f7b-d5b44f7288c7 at linaro.org/

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts line 163

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +10 -0
+		compatible = "adi,adm1278";
+		reg = <0x40>;
+	};
+};
+
+&i2c2 {
+	status = "okay";
+	bus-frequency = <400000>;
+	multi-master;
+	adm1278 at 40 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts

Quoted 1 line
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +1 -0
+		compatible = "adi,adm1278";

I stop here, there is no point to review same mistakes.

Best regards,
Krzysztof

#5 lore raw

v2 cover Add Facebook Yosemite V4 (AST2600) BMC

In reply to Delphine CC Chiu

v2 - Add Facebook Yosemite V4 (AST2600) BMC

Delphine CC Chiu (2):
dt-bindings: arm: aspeed: add Facebook Yosemite V4 board
ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

 .../bindings/arm/aspeed/aspeed.yaml           |   1 +
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 577 ++++++++++++++++++
 3 files changed, 579 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts
Signature · 1 line
2.25.1
#6 lore raw

PATCH v2 1/2 dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Document the new compatibles used on Facebook Yosemite V4.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index e0eff4c05879..2ef6821e3648 100644
@@ -79,6 +79,7 @@ properties:
               - facebook,elbert-bmc
               - facebook,fuji-bmc
               - facebook,greatlakes-bmc
+              - facebook,yosemitev4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
Signature · 1 line
2.25.1
#7 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Quoted 4 lines · Delphine CC Chiu

Document the new compatibles used on Facebook Yosemite V4.

---

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v6.4/source/Documentation/process/submitting-patches.rst#L552

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

#8 lore raw

PATCH v2 2/2 ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

In reply to Delphine CC Chiu

Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 577 ++++++++++++++++++
 2 files changed, 578 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts
arch/arm/boot/dts/Makefile +1 -0
index 59829fc90315..871e6d271262 100644
@@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-galaxy100.dtb \
 	aspeed-bmc-facebook-greatlakes.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
+	aspeed-bmc-facebook-yosemitev4.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
 	aspeed-bmc-facebook-wedge40.dtb \
 	aspeed-bmc-facebook-wedge100.dtb \
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +577 -0

577 lines not on this page · raw message

Signature · 1 line
2.25.1
#9 lore raw

Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

Quoted 41 lines · Delphine CC Chiu

Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 577 ++++++++++++++++++
 2 files changed, 578 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts
arch/arm/boot/dts/Makefile +1 -0
index 59829fc90315..871e6d271262 100644
@@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-galaxy100.dtb \
 	aspeed-bmc-facebook-greatlakes.dtb \
 	aspeed-bmc-facebook-minipack.dtb \
+	aspeed-bmc-facebook-yosemitev4.dtb \
 	aspeed-bmc-facebook-tiogapass.dtb \
 	aspeed-bmc-facebook-wedge40.dtb \
 	aspeed-bmc-facebook-wedge100.dtb \
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +13 -0
new file mode 100644
index 000000000000..cfe4838fae5a
@@ -0,0 +1,577 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2022 Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/i2c/i2c.h>
+
+/ {
+	model = "Facebook Yosemite V4 BMC";
+	compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600";
+

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts line 23

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +10 -0
+	aliases {
+		serial4 = &uart5;
+		serial5 = &uart6;
+		serial6 = &uart7;
+		serial7 = &uart8;
+		serial8 = &uart9;
+	};
+
+	chosen {
+		bootargs = "console=ttyS4,57600n8";

Nothing improved, so you just ignored entire feedback and resent the same.

Sorry, that's not how responding to feedback works.

NAK

Best regards,
Krzysztof

#10 lore raw

RE: [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

Quoted 68 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Friday, July 14, 2023 12:13 PM
To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>; patrick at stwcx.xyz; Arnd Bergmann <[email protected]>; Olof Johansson <[email protected]>; soc at kernel.org; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

Security Reminder: Please be aware that this email is sent by an external
sender.

Quoted 7 lines · Delphine CC Chiu

Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC.

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-facebook-yosemitev4.dts    | 577

++++++++++++++++++

Quoted 40 lines
 2 files changed, 578 insertions(+)
 create mode 100644

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts

arch/arm/boot/dts/Makefile +1 -0
index 59829fc90315..871e6d271262 100644
@@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
      aspeed-bmc-facebook-galaxy100.dtb \
      aspeed-bmc-facebook-greatlakes.dtb \
      aspeed-bmc-facebook-minipack.dtb \
+     aspeed-bmc-facebook-yosemitev4.dtb \
      aspeed-bmc-facebook-tiogapass.dtb \
      aspeed-bmc-facebook-wedge40.dtb \
      aspeed-bmc-facebook-wedge100.dtb \ diff --git

a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file mode 100644
index 000000000000..cfe4838fae5a

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +17 -0
@@ -0,0 +1,577 @@
+// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022
+Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h> #include
+<dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/i2c/i2c.h>
+
+/ {
+     model = "Facebook Yosemite V4 BMC";
+     compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600";
+
+     aliases {
+             serial4 = &uart5;
+             serial5 = &uart6;
+             serial6 = &uart7;
Quoted 8 lines

arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts line 23

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file +6 -0
+             serial7 = &uart8;
+             serial8 = &uart9;
+     };
+
+     chosen {
+             bootargs = "console=ttyS4,57600n8";

Nothing improved, so you just ignored entire feedback and resent the same.

I lost stdout-path feedback, so I'll revise to following format in next version contribute:

chosen {
               stdout-path = "serial4:57600n8";
      };

As former feedback mentioned, I also revise the i2c device node names by referencing DT specification. The only node name I used that not on the list is "power-sensor",
which is following the example under Documentation/devicetree/bindings.

Most of the other partition in DTS is same as the recent-contributed project. Would you please to tell if there's still some omissions I made. Thank you for reviewing.

Quoted 7 lines

Sorry, that's not how responding to feedback works.

NAK

Best regards,
Krzysztof

#11 lore raw
In reply to Delphine CC Chiu
Quoted 2 lines · Delphine CC Chiu

v2 - Add Facebook Yosemite V4 (AST2600) BMC

Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets.

Best regards,
Krzysztof