Skip to contentSkip to conversation

wifi: ath5k: remove phydir check from ath5k_debug_init_device()

PATCH In review Minjie Du 2 participants 2 messages Jul 14, 2023 – Jul 25, 2023 Atheros ATH5K wireless driver

lore
Share & tools
lore

Minjie Du

author
#0 lore raw

PATCH v6 1/1 wifi: ath5k: remove phydir check from ath5k_debug_init_device()

'phydir' returned from debugfs_create_dir() is checked against NULL. As the debugfs API returns an error pointer,
the returned value can never be NULL.

Therefore, as the documentation suggests that the check is unnecessary and other debugfs calls have no operation in error cases, it is advisable to completely eliminate the check.

---
V5 -> V6: add 'Reviewed-by:' tag.
V4 -> V5: fix expression about patch.
V3 -> V4: fix the patch format.
V2 -> V3: remove the error check.
V1 -> V2: use IS_ERR_OR_NULL() replace IS_ERR() to error check.
V1: use IS_ERR() to error check.

---
 drivers/net/wireless/ath/ath5k/debug.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/wireless/ath/ath5k/debug.c +0 -2
index 4b41160e5..ec130510a 100644
@@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
 	ah->debug.level = ath5k_debug;
 
 	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
-	if (!phydir)
-		return;
 
 	debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
 	debugfs_create_file("registers", 0400, phydir, ah, &registers_fops);
Signature · 1 line
2.39.0
#1 lore raw
Quoted 11 lines · Minjie Du

'phydir' returned from debugfs_create_dir() is checked against NULL. As the debugfs API returns an error pointer,
the returned value can never be NULL.

Therefore, as the documentation suggests that the check is unnecessary and other debugfs calls have no operation in error cases, it is advisable to completely eliminate the check.

Patch applied to ath-next branch of ath.git, thanks.

f7eb8315b22a wifi: ath5k: remove phydir check from ath5k_debug_init_device()

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches