Skip to contentSkip to conversation

eudev: Add group sgx to eudev package

PATCH In review Alex Kiernan 2 participants 5 messages Jul 14, 2023 – Jul 20, 2023 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eudev: Add group sgx to eudev package

Fix startup warning:

udevd[171]: specified group 'sgx' unknown

This mirrors the change in bab455cd9b1b ("systemd: add group sgx to udev package") for systemd-udev.

---

 meta/recipes-core/udev/eudev_3.2.12.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-core/udev/eudev_3.2.12.bb +4 -1
index 572ccecafd0c..4268bcc2c5de 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "ccdd64ec3c381d3c3ed0e99d2e70d1f62988c7763de89ca7bdffafa5ea
 
 GITHUB_BASE_URI = "https://github.com/eudev-project/eudev/releases"
 
-inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases
+inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases useradd
 
 CONFLICT_DISTRO_FEATURES = "systemd"
 
@@ -85,3 +85,6 @@ pkg_postinst:${PN}-hwdb () {
 pkg_prerm:${PN}-hwdb () {
 	rm -f $D${sysconfdir}/udev/hwdb.bin
 }
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM:${PN} = "-r sgx"
Signature · 1 line
2.39.0
#1 lore raw

Hello,

I had a bit of trouble to find this but this causes the following oe-selftest failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/2274/steps/14/logs/stdio

2023-07-18 20:56:16,128 - oe-selftest - INFO - gdbserver.GdbServerTest.test_gdb_server (subunit.RemotedTestCase)
2023-07-18 20:56:16,129 - oe-selftest - INFO -  ... ERROR
Stderr:
2023-07-18 20:32:39,581 - oe-selftest - INFO - Adding: "include selftest.inc" in /home/pokybuild/yocto-worker/oe-selftest/build/build-st-836115/conf/local.conf
2023-07-18 20:32:39,582 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2023-07-18 20:56:16,129 - oe-selftest - INFO - 14: 7/58 224/529 (269.86s) (0 failed) (gdbserver.GdbServerTest.test_gdb_server)
2023-07-18 20:56:16,129 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest/build/meta/lib/oeqa/selftest/cases/gdbserver.py", line 43, in test_gdb_server
    shutil.unpack_archive(filename, debugfs)
  File "/usr/lib64/python3.11/shutil.py", line 1323, in unpack_archive
    func(filename, extract_dir, **kwargs)
  File "/usr/lib64/python3.11/shutil.py", line 1244, in _unpack_tarfile
    tarobj.extractall(extract_dir, filter=filter)
  File "/usr/lib64/python3.11/tarfile.py", line 2257, in extractall
    self._extract_one(tarinfo, path, set_attrs=not tarinfo.isdir(),
  File "/usr/lib64/python3.11/tarfile.py", line 2324, in _extract_one
    self._handle_fatal_error(e)
  File "/usr/lib64/python3.11/tarfile.py", line 2320, in _extract_one
    self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
  File "/usr/lib64/python3.11/tarfile.py", line 2403, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib64/python3.11/tarfile.py", line 2448, in makefile
    with bltn_open(targetpath, "wb") as target:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^

PermissionError: [Errno 13] Permission denied: '/tmp/debugfs-j_xgxhkm/./etc/gshadow'

Quoted 46 lines · Alex Kiernan

Fix startup warning:

udevd[171]: specified group 'sgx' unknown

This mirrors the change in bab455cd9b1b ("systemd: add group sgx to udev package") for systemd-udev.

---

 meta/recipes-core/udev/eudev_3.2.12.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-core/udev/eudev_3.2.12.bb +4 -1
index 572ccecafd0c..4268bcc2c5de 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "ccdd64ec3c381d3c3ed0e99d2e70d1f62988c7763de89ca7bdffafa5ea
 
 GITHUB_BASE_URI = "https://github.com/eudev-project/eudev/releases"
 
-inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases
+inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases useradd
 
 CONFLICT_DISTRO_FEATURES = "systemd"
 
@@ -85,3 +85,6 @@ pkg_postinst:${PN}-hwdb () {
 pkg_prerm:${PN}-hwdb () {
 	rm -f $D${sysconfdir}/udev/hwdb.bin
 }
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM:${PN} = "-r sgx"
Signature · 11 lines
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184267): https://lists.openembedded.org/g/openembedded-core/message/184267
Mute This Topic: https://lists.openembedded.org/mt/100141828/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw
Quoted 32 lines · Alexandre Belloni

Hello,

I had a bit of trouble to find this but this causes the following oe-selftest failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/2274/steps/14/logs/stdio

2023-07-18 20:56:16,128 - oe-selftest - INFO - gdbserver.GdbServerTest.test_gdb_server (subunit.RemotedTestCase)
2023-07-18 20:56:16,129 - oe-selftest - INFO -  ... ERROR
Stderr:
2023-07-18 20:32:39,581 - oe-selftest - INFO - Adding: "include selftest.inc" in /home/pokybuild/yocto-worker/oe-selftest/build/build-st-836115/conf/local.conf
2023-07-18 20:32:39,582 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2023-07-18 20:56:16,129 - oe-selftest - INFO - 14: 7/58 224/529 (269.86s) (0 failed) (gdbserver.GdbServerTest.test_gdb_server)
2023-07-18 20:56:16,129 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest/build/meta/lib/oeqa/selftest/cases/gdbserver.py", line 43, in test_gdb_server
    shutil.unpack_archive(filename, debugfs)
  File "/usr/lib64/python3.11/shutil.py", line 1323, in unpack_archive
    func(filename, extract_dir, **kwargs)
  File "/usr/lib64/python3.11/shutil.py", line 1244, in _unpack_tarfile
    tarobj.extractall(extract_dir, filter=filter)
  File "/usr/lib64/python3.11/tarfile.py", line 2257, in extractall
    self._extract_one(tarinfo, path, set_attrs=not tarinfo.isdir(),
  File "/usr/lib64/python3.11/tarfile.py", line 2324, in _extract_one
    self._handle_fatal_error(e)
  File "/usr/lib64/python3.11/tarfile.py", line 2320, in _extract_one
    self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
  File "/usr/lib64/python3.11/tarfile.py", line 2403, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib64/python3.11/tarfile.py", line 2448, in makefile
    with bltn_open(targetpath, "wb") as target:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 2 lines

PermissionError: [Errno 13] Permission denied: '/tmp/debugfs-j_xgxhkm/./etc/gshadow'

That's interesting... really not sure why /etc/shadow doesn't trigger this failure too (which is in the same set of tarballs). That said I've no idea what the fix is, since this looks like collateral damage rather than something which this change obviously broke. Will stare at it a bit more.

Quoted 49 lines · Alex Kiernan
Quoted 38 lines

Fix startup warning:

udevd[171]: specified group 'sgx' unknown

This mirrors the change in bab455cd9b1b ("systemd: add group sgx to udev package") for systemd-udev.

---

 meta/recipes-core/udev/eudev_3.2.12.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-core/udev/eudev_3.2.12.bb +4 -2
index 572ccecafd0c..4268bcc2c5de 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "ccdd64ec3c381d3c3ed0e99d2e70d1f62988c7763de89ca7bdffafa5ea
 
 GITHUB_BASE_URI = "https://github.com/eudev-project/eudev/releases"
 
-inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases
+inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases useradd
 
 CONFLICT_DISTRO_FEATURES = "systemd"
 
@@ -85,3 +85,6 @@ pkg_postinst:${PN}-hwdb () {
 pkg_prerm:${PN}-hwdb () {
      rm -f $D${sysconfdir}/udev/hwdb.bin
 }
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM:${PN} = "-r sgx"
--

2.39.0

Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184267): https://lists.openembedded.org/g/openembedded-core/message/184267
Mute This Topic: https://lists.openembedded.org/mt/100141828/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Quoted 4 lines

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--
Alex Kiernan

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 38 lines · Alex Kiernan via lists.openembedded.org
Quoted 32 lines · Alexandre Belloni

Hello,

I had a bit of trouble to find this but this causes the following oe-selftest failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/2274/steps/14/logs/stdio

2023-07-18 20:56:16,128 - oe-selftest - INFO - gdbserver.GdbServerTest.test_gdb_server (subunit.RemotedTestCase)
2023-07-18 20:56:16,129 - oe-selftest - INFO -  ... ERROR
Stderr:
2023-07-18 20:32:39,581 - oe-selftest - INFO - Adding: "include selftest.inc" in /home/pokybuild/yocto-worker/oe-selftest/build/build-st-836115/conf/local.conf
2023-07-18 20:32:39,582 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2023-07-18 20:56:16,129 - oe-selftest - INFO - 14: 7/58 224/529 (269.86s) (0 failed) (gdbserver.GdbServerTest.test_gdb_server)
2023-07-18 20:56:16,129 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest/build/meta/lib/oeqa/selftest/cases/gdbserver.py", line 43, in test_gdb_server
    shutil.unpack_archive(filename, debugfs)
  File "/usr/lib64/python3.11/shutil.py", line 1323, in unpack_archive
    func(filename, extract_dir, **kwargs)
  File "/usr/lib64/python3.11/shutil.py", line 1244, in _unpack_tarfile
    tarobj.extractall(extract_dir, filter=filter)
  File "/usr/lib64/python3.11/tarfile.py", line 2257, in extractall
    self._extract_one(tarinfo, path, set_attrs=not tarinfo.isdir(),
  File "/usr/lib64/python3.11/tarfile.py", line 2324, in _extract_one
    self._handle_fatal_error(e)
  File "/usr/lib64/python3.11/tarfile.py", line 2320, in _extract_one
    self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
  File "/usr/lib64/python3.11/tarfile.py", line 2403, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib64/python3.11/tarfile.py", line 2448, in makefile
    with bltn_open(targetpath, "wb") as target:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 2 lines

PermissionError: [Errno 13] Permission denied: '/tmp/debugfs-j_xgxhkm/./etc/gshadow'

Quoted 6 lines

That's interesting... really not sure why /etc/shadow doesn't trigger this failure too (which is in the same set of tarballs). That said I've no idea what the fix is, since this looks like collateral damage rather than something which this change obviously broke. Will stare at it a bit more.

If I read the pieces right, we do:

        self._setup_dbg_rootfs(['/etc', '/var/lib/rpm',

'/var/cache/dnf', '/var/lib/dnf'])

I assume in order to prime the RPM config, which then copies gshadow (and the rest of /etc - ignoring that its not using ${sysconfdir}), which then causes this failure...

Something like:

meta/lib/oe/rootfs.py +3 -0
index 890ba5f03984..a2e81afb4f09 100644
@@ -162,6 +162,9 @@ class Rootfs(object, metaclass=ABCMeta):
             bb.note("  Install extra debug packages...")
             self.pm.install(extra_debug_pkgs.split(), True)
 
+        sysconfdir = self.image_rootfs + self.d.getVar('sysconfdir')
+        shutil.rmtree(sysconfdir)
+
         bb.note("  Rename debug rootfs...")
         try:
             shutil.rmtree(self.image_rootfs + '-dbg')

Would appear sensible, but it feels rather "nuclear" and is way out of my comfort zone of a proposed change!

Quoted 61 lines
Quoted 43 lines · Alex Kiernan
Quoted 34 lines

Fix startup warning:

udevd[171]: specified group 'sgx' unknown

This mirrors the change in bab455cd9b1b ("systemd: add group sgx to udev package") for systemd-udev.

---

 meta/recipes-core/udev/eudev_3.2.12.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-core/udev/eudev_3.2.12.bb +4 -2
index 572ccecafd0c..4268bcc2c5de 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "ccdd64ec3c381d3c3ed0e99d2e70d1f62988c7763de89ca7bdffafa5ea
 
 GITHUB_BASE_URI = "https://github.com/eudev-project/eudev/releases"
 
-inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases
+inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases useradd
 
 CONFLICT_DISTRO_FEATURES = "systemd"
 
@@ -85,3 +85,6 @@ pkg_postinst:${PN}-hwdb () {
 pkg_prerm:${PN}-hwdb () {
      rm -f $D${sysconfdir}/udev/hwdb.bin
 }
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM:${PN} = "-r sgx"
--
Quoted 6 lines

2.39.0

Quoted 4 lines

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--
Alex Kiernan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184593): https://lists.openembedded.org/g/openembedded-core/message/184593
Mute This Topic: https://lists.openembedded.org/mt/100141828/3618097
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 1 line
Alex Kiernan

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 75 lines · Alex Kiernan via lists.openembedded.org
Quoted 38 lines · Alex Kiernan via lists.openembedded.org
Quoted 32 lines · Alexandre Belloni

Hello,

I had a bit of trouble to find this but this causes the following oe-selftest failure:

https://autobuilder.yoctoproject.org/typhoon/#/builders/56/builds/2274/steps/14/logs/stdio

2023-07-18 20:56:16,128 - oe-selftest - INFO - gdbserver.GdbServerTest.test_gdb_server (subunit.RemotedTestCase)
2023-07-18 20:56:16,129 - oe-selftest - INFO -  ... ERROR
Stderr:
2023-07-18 20:32:39,581 - oe-selftest - INFO - Adding: "include selftest.inc" in /home/pokybuild/yocto-worker/oe-selftest/build/build-st-836115/conf/local.conf
2023-07-18 20:32:39,582 - oe-selftest - INFO - Adding: "include bblayers.inc" in bblayers.conf
2023-07-18 20:56:16,129 - oe-selftest - INFO - 14: 7/58 224/529 (269.86s) (0 failed) (gdbserver.GdbServerTest.test_gdb_server)
2023-07-18 20:56:16,129 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest/build/meta/lib/oeqa/selftest/cases/gdbserver.py", line 43, in test_gdb_server
    shutil.unpack_archive(filename, debugfs)
  File "/usr/lib64/python3.11/shutil.py", line 1323, in unpack_archive
    func(filename, extract_dir, **kwargs)
  File "/usr/lib64/python3.11/shutil.py", line 1244, in _unpack_tarfile
    tarobj.extractall(extract_dir, filter=filter)
  File "/usr/lib64/python3.11/tarfile.py", line 2257, in extractall
    self._extract_one(tarinfo, path, set_attrs=not tarinfo.isdir(),
  File "/usr/lib64/python3.11/tarfile.py", line 2324, in _extract_one
    self._handle_fatal_error(e)
  File "/usr/lib64/python3.11/tarfile.py", line 2320, in _extract_one
    self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
  File "/usr/lib64/python3.11/tarfile.py", line 2403, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib64/python3.11/tarfile.py", line 2448, in makefile
    with bltn_open(targetpath, "wb") as target:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 2 lines

PermissionError: [Errno 13] Permission denied: '/tmp/debugfs-j_xgxhkm/./etc/gshadow'

Quoted 6 lines

That's interesting... really not sure why /etc/shadow doesn't trigger this failure too (which is in the same set of tarballs). That said I've no idea what the fix is, since this looks like collateral damage rather than something which this change obviously broke. Will stare at it a bit more.

If I read the pieces right, we do:

        self._setup_dbg_rootfs(['/etc', '/var/lib/rpm',

'/var/cache/dnf', '/var/lib/dnf'])

I assume in order to prime the RPM config, which then copies gshadow (and the rest of /etc - ignoring that its not using ${sysconfdir}), which then causes this failure...

Something like:

meta/lib/oe/rootfs.py +3 -0
index 890ba5f03984..a2e81afb4f09 100644
@@ -162,6 +162,9 @@ class Rootfs(object, metaclass=ABCMeta):
             bb.note("  Install extra debug packages...")
             self.pm.install(extra_debug_pkgs.split(), True)
 
+        sysconfdir = self.image_rootfs + self.d.getVar('sysconfdir')
+        shutil.rmtree(sysconfdir)
+
         bb.note("  Rename debug rootfs...")
         try:
             shutil.rmtree(self.image_rootfs + '-dbg')
Quoted 3 lines

Would appear sensible, but it feels rather "nuclear" and is way out of my comfort zone of a proposed change!

Have sent a change to rework the way rpm is handled when building the debugfs, which I think is the root cause of this failure.

Quoted 68 lines
Quoted 50 lines
Quoted 43 lines · Alex Kiernan
Quoted 34 lines

Fix startup warning:

udevd[171]: specified group 'sgx' unknown

This mirrors the change in bab455cd9b1b ("systemd: add group sgx to udev package") for systemd-udev.

---

 meta/recipes-core/udev/eudev_3.2.12.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-core/udev/eudev_3.2.12.bb +4 -2
index 572ccecafd0c..4268bcc2c5de 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "ccdd64ec3c381d3c3ed0e99d2e70d1f62988c7763de89ca7bdffafa5ea
 
 GITHUB_BASE_URI = "https://github.com/eudev-project/eudev/releases"
 
-inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases
+inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases useradd
 
 CONFLICT_DISTRO_FEATURES = "systemd"
 
@@ -85,3 +85,6 @@ pkg_postinst:${PN}-hwdb () {
 pkg_prerm:${PN}-hwdb () {
      rm -f $D${sysconfdir}/udev/hwdb.bin
 }
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM:${PN} = "-r sgx"
--
Quoted 6 lines

2.39.0

Quoted 4 lines

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Quoted 5 lines

--
Alex Kiernan

--
Alex Kiernan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184600): https://lists.openembedded.org/g/openembedded-core/message/184600
Mute This Topic: https://lists.openembedded.org/mt/100141828/3618097
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 1 line
Alex Kiernan