Skip to contentSkip to conversation

hsi: omap_ssi: Explicitly include correct DT includes

PATCH Applied Rob Herring 2 participants 2 messages Jul 14, 2023 – Jul 31, 2023 HSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hsi: omap_ssi: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

---
 drivers/hsi/controllers/omap_ssi_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hsi/controllers/omap_ssi_core.c +1 -0
index 84ba8b875199..4c1a00f9929e 100644
@@ -25,6 +25,7 @@
 #include <linux/debugfs.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/pm_runtime.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/hsi/hsi.h>
 #include <linux/idr.h>
Signature · 1 line
2.40.1
#1 lore raw
Quoted 10 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

[...]

Applied, thanks!

[1/1] hsi: omap_ssi: Explicitly include correct DT includes

      commit: 7ebf243a201856adcac240e490596bb908ee5fcc

Best regards,

Signature · 1 line
Sebastian Reichel <[email protected]>