soc: bcm: Explicitly include correct DT includes
PATCH 1/1 soc: bcm: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
--- drivers/soc/bcm/bcm63xx/bcm-pmb.c | 1 - drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 1 - 2 files changed, 2 deletions(-)
drivers/soc/bcm/bcm63xx/bcm-pmb.c +0 -1
@@ -8,7 +8,6 @@#include <linux/io.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/reset/bcm63xx_pmb.h>
drivers/soc/bcm/bcm63xx/bcm63xx-power.c +0 -1
@@ -14,7 +14,6 @@#include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/of.h> -#include <linux/of_device.h> struct bcm63xx_power_dev {struct generic_pm_domain genpd;
Signature · 1 line
2.40.1
Hi Rob,
Quoted 2 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus.
"before it was"?
Quoted 7 lines
As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include
platform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 5 lines
Signed-off-by Rob Herring <[email protected]>--- drivers/soc/bcm/bcm63xx/bcm-pmb.c | 1 - drivers/soc/bcm/bcm63xx/bcm63xx-power.c | 1 - 2 files changed, 2 deletions(-)