shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static
Subsystems (2)
PATCH 1/1 shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static
smatch reportsmm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
was not declared. Should it be static?mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
was not declared. Should it be static?
These variables are only used in their defining file, so it should be static.
--- mm/shmem_quota.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/shmem_quota.c +2 -2
@@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot)return 0 ; } -int shmem_mark_dquot_dirty (struct dquot *dquot) +static int shmem_mark_dquot_dirty (struct dquot *dquot) {return 0 ; } -int shmem_dquot_write_info (struct super_block *sb,int type) +static int shmem_dquot_write_info (struct super_block *sb,int type) {return 0 ; }
Signature · 1 line
2.27.0
Quoted 7 lines · Tom Rix
smatch reports
mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
was not declared. Should it be static?mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
was not declared. Should it be static?These variables are only used in their defining file, so it should be static.
These are functions, not variables, and you're the third person to send this patch today.