fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags
Subsystems (52)
Thomas Zimmermann
maintainerv4 cover fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from fbdev and drivers, as briefly discussed at [1]. Both flags were maybe useful when fbdev had special handling for driver modules. With commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 and have no further effect.
Patches 1 to 7 remove FBINFO_DEFAULT from drivers. Patches 2 to 5 split this by the way the fb_info struct is being allocated. All flags are cleared to zero during the allocation.
Patches 8 to 16 do the same for FBINFO_FLAG_DEFAULT. Patch 8 fixes an actual bug in how arch/sh uses the token for struct fb_videomode, which is unrelated.
Patch 17 removes both flag constants from <linux/fb.h> and patch 18 documents the zero'ed memory returned by framebuffer_alloc().
v4:
* clarify commit messages (Geert, Dan)
v3:
* sh: include board name in commit message (Adrian)
* docs: reword text (Miguel)
v2:
* sh: use FB_MODE_IS_UNKNOWN (Adrian)
* fix commit messages (Miguel)
* document framebuffer_alloc()'s zero'ed memory (Miguel)
[1] https://lore.kernel.org/dri-devel/[email protected]/
Thomas Zimmermann (18):
drm: Remove flag FBINFO_DEFAULT from fbdev emulation
fbdev: Remove FBINFO_DEFAULT from static structs
fbdev: Remove FBINFO_DEFAULT from kzalloc()'ed structs
fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs
fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structs fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT
vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver
sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct
fb_videomode.flag
auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs
fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT
fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT
fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT
fbdev: Document that framebuffer_alloc() returns zero'ed data
arch/sh/boards/mach-sh7763rdp/setup.c | 2 +- drivers/auxdisplay/cfag12864bfb.c | 1 - drivers/auxdisplay/ht16k33.c | 1 - drivers/gpu/drm/drm_fbdev_dma.c | 1 - drivers/gpu/drm/drm_fbdev_generic.c | 1 - drivers/gpu/drm/gma500/fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fbdev.c | 2 +- drivers/hid/hid-picolcd_fb.c | 1 - drivers/media/pci/ivtv/ivtvfb.c | 1 - drivers/media/test-drivers/vivid/vivid-osd.c | 1 - drivers/staging/fbtft/fbtft-core.c | 2 +- drivers/staging/sm750fb/sm750.c | 1 - drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +- drivers/video/fbdev/amba-clcd.c | 1 - drivers/video/fbdev/amifb.c | 5 ++--- drivers/video/fbdev/arcfb.c | 1 - drivers/video/fbdev/asiliantfb.c | 1 - drivers/video/fbdev/atafb.c | 1 - drivers/video/fbdev/atmel_lcdfb.c | 2 +- drivers/video/fbdev/aty/aty128fb.c | 1 - drivers/video/fbdev/aty/atyfb_base.c | 3 +-- drivers/video/fbdev/aty/radeon_base.c | 3 +-- drivers/video/fbdev/broadsheetfb.c | 2 +- drivers/video/fbdev/bw2.c | 1 - drivers/video/fbdev/carminefb.c | 1 - drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 1 - drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/chipsfb.c | 1 - drivers/video/fbdev/cirrusfb.c | 3 +-- drivers/video/fbdev/clps711x-fb.c | 1 - drivers/video/fbdev/cobalt_lcdfb.c | 1 - drivers/video/fbdev/controlfb.c | 2 +- drivers/video/fbdev/core/fb_info.c | 3 ++- drivers/video/fbdev/cyber2000fb.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 1 - drivers/video/fbdev/efifb.c | 1 - drivers/video/fbdev/ep93xx-fb.c | 1 - drivers/video/fbdev/ffb.c | 3 +-- drivers/video/fbdev/fm2fb.c | 1 - drivers/video/fbdev/fsl-diu-fb.c | 2 +- drivers/video/fbdev/g364fb.c | 2 +- drivers/video/fbdev/gbefb.c | 1 - drivers/video/fbdev/geode/gx1fb_core.c | 1 - drivers/video/fbdev/geode/gxfb_core.c | 1 - drivers/video/fbdev/geode/lxfb_core.c | 1 - drivers/video/fbdev/goldfishfb.c | 1 - drivers/video/fbdev/grvga.c | 2 +- drivers/video/fbdev/gxt4500.c | 3 +-- drivers/video/fbdev/hecubafb.c | 2 +- drivers/video/fbdev/hgafb.c | 2 +- drivers/video/fbdev/hitfb.c | 2 +- drivers/video/fbdev/hpfb.c | 1 - drivers/video/fbdev/hyperv_fb.c | 2 -- drivers/video/fbdev/i740fb.c | 2 +- drivers/video/fbdev/i810/i810_main.c | 4 ++-- drivers/video/fbdev/imsttfb.c | 3 +-- drivers/video/fbdev/imxfb.c | 3 +-- drivers/video/fbdev/intelfb/intelfbdrv.c | 5 ++--- drivers/video/fbdev/kyro/fbdev.c | 1 - drivers/video/fbdev/leo.c | 1 - drivers/video/fbdev/macfb.c | 1 - drivers/video/fbdev/matrox/matroxfb_crtc2.c | 5 ++--- drivers/video/fbdev/maxinefb.c | 1 - drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- drivers/video/fbdev/metronomefb.c | 2 +- drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- drivers/video/fbdev/mx3fb.c | 1 - drivers/video/fbdev/neofb.c | 2 +- drivers/video/fbdev/nvidia/nvidia.c | 4 ++-- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/omap/omapfb_main.c | 1 - drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 - drivers/video/fbdev/p9100.c | 1 - drivers/video/fbdev/platinumfb.c | 1 - drivers/video/fbdev/pm2fb.c | 3 +-- drivers/video/fbdev/pm3fb.c | 3 +-- drivers/video/fbdev/pmag-aa-fb.c | 1 - drivers/video/fbdev/pmag-ba-fb.c | 1 - drivers/video/fbdev/pmagb-b-fb.c | 1 - drivers/video/fbdev/ps3fb.c | 2 +- drivers/video/fbdev/pvr2fb.c | 2 +- drivers/video/fbdev/pxa168fb.c | 2 +- drivers/video/fbdev/pxafb.c | 2 -- drivers/video/fbdev/q40fb.c | 1 - drivers/video/fbdev/riva/fbdev.c | 3 +-- drivers/video/fbdev/s1d13xxxfb.c | 4 ++-- drivers/video/fbdev/s3c-fb.c | 1 - drivers/video/fbdev/sa1100fb.c | 1 - drivers/video/fbdev/savage/savagefb_driver.c | 3 +-- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 -- drivers/video/fbdev/simplefb.c | 1 - drivers/video/fbdev/sis/sis_main.c | 5 +---- drivers/video/fbdev/skeletonfb.c | 2 +- drivers/video/fbdev/sm501fb.c | 2 +- drivers/video/fbdev/sm712fb.c | 1 - drivers/video/fbdev/smscufx.c | 2 +- drivers/video/fbdev/sstfb.c | 1 - drivers/video/fbdev/sunxvr1000.c | 1 - drivers/video/fbdev/sunxvr2500.c | 1 - drivers/video/fbdev/sunxvr500.c | 1 - drivers/video/fbdev/tcx.c | 1 - drivers/video/fbdev/tdfxfb.c | 2 +- drivers/video/fbdev/tgafb.c | 2 +- drivers/video/fbdev/tridentfb.c | 2 +- drivers/video/fbdev/udlfb.c | 2 +- drivers/video/fbdev/uvesafb.c | 3 +-- drivers/video/fbdev/valkyriefb.c | 1 - drivers/video/fbdev/vermilion/vermilion.c | 2 +- drivers/video/fbdev/vesafb.c | 2 +- drivers/video/fbdev/vfb.c | 1 - drivers/video/fbdev/vga16fb.c | 2 +- drivers/video/fbdev/via/viafbdev.c | 2 +- drivers/video/fbdev/vt8500lcdfb.c | 3 +-- drivers/video/fbdev/wm8505fb.c | 3 +-- drivers/video/fbdev/xen-fbfront.c | 2 +- drivers/video/fbdev/xilinxfb.c | 1 - include/linux/fb.h | 3 --- samples/vfio-mdev/mdpy-fb.c | 1 - 120 files changed, 68 insertions(+), 151 deletions(-)
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 1/18 drm: Remove flag FBINFO_DEFAULT from fbdev emulation
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/gpu/drm/drm_fbdev_dma.c | 1 - drivers/gpu/drm/drm_fbdev_generic.c | 1 - drivers/gpu/drm/gma500/fbdev.c | 2 +- drivers/gpu/drm/radeon/radeon_fbdev.c | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_fbdev_dma.c +0 -1
@@ -123,7 +123,6 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper,drm_fb_helper_fill_info (info, fb_helper, sizes); info->fbops = &drm_fbdev_dma_fb_ops; - info->flags =FBINFO_DEFAULT ;/* screen */ info->flags |=FBINFO_VIRTFB ;/* system memory */
drivers/gpu/drm/drm_fbdev_generic.c +0 -1
@@ -109,7 +109,6 @@ static int drm_fbdev_generic_helper_fb_probe(struct drm_fb_helper *fb_helper,drm_fb_helper_fill_info (info, fb_helper, sizes); info->fbops = &drm_fbdev_generic_fb_ops; - info->flags =FBINFO_DEFAULT ;/* screen */ info->flags |=FBINFO_VIRTFB |FBINFO_READS_FAST ;
drivers/gpu/drm/gma500/fbdev.c +1 -1
@@ -215,7 +215,7 @@ static int psb_fbdev_fb_probe(struct drm_fb_helper *fb_helper, } info->fbops = &psb_fbdev_fb_ops; - info->flags =FBINFO_DEFAULT ; +/* Accessed stolen memory directly */ info->screen_base = dev_priv->vram_addr + backing->offset; info->screen_size = size;
drivers/gpu/drm/radeon/radeon_fbdev.c +1 -1
@@ -253,7 +253,7 @@ static int radeon_fbdev_fb_helper_fb_probe(struct drm_fb_helper *fb_helper, } info->fbops = &radeon_fbdev_fb_ops; - info->flags =FBINFO_DEFAULT ; +/* radeon resume is fragile and needs a vt switch to help it along */ info->skip_vt_switch = false;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 2/18 fbdev: Remove FBINFO_DEFAULT from static structs
In reply to Thomas ZimmermannThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/68328fb.c | 2 +- drivers/video/fbdev/acornfb.c | 2 +- drivers/video/fbdev/g364fb.c | 2 +- drivers/video/fbdev/hpfb.c | 1 - drivers/video/fbdev/macfb.c | 1 - drivers/video/fbdev/maxinefb.c | 1 - 6 files changed, 3 insertions(+), 6 deletions(-)
drivers/video/fbdev/68328fb.c +1 -1
@@ -448,7 +448,7 @@ static int __init mc68x328fb_init(void) fb_info.var.red.offset = fb_info.var.green.offset = fb_info.var.blue.offset =0 ; } fb_info.pseudo_palette = &mc68x328fb_pseudo_palette; - fb_info.flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + fb_info.flags =FBINFO_HWACCEL_YPAN ;if (fb_alloc_cmap (&fb_info.cmap,256 ,0 ))return -ENOMEM ;
drivers/video/fbdev/acornfb.c +1 -1
@@ -694,7 +694,7 @@ static void acornfb_init_fbinfo(void) first =0 ; fb_info.fbops = &acornfb_ops; - fb_info.flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + fb_info.flags =FBINFO_HWACCEL_YPAN ; fb_info.pseudo_palette = current_par.pseudo_palette;strcpy (fb_info.fix.id,"Acorn" );
drivers/video/fbdev/g364fb.c +1 -1
@@ -219,7 +219,7 @@ int __init g364fb_init(void) fb_info.screen_base = (char *)G364_MEM_BASE ;/* virtual kernel address */ fb_info.var = fb_var; fb_info.fix = fb_fix; - fb_info.flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + fb_info.flags =FBINFO_HWACCEL_YPAN ;fb_alloc_cmap (&fb_info.cmap,255 ,0 );
drivers/video/fbdev/hpfb.c +0 -1
@@ -287,7 +287,6 @@ static int hpfb_init_one(unsigned long phys_base, unsigned long virt_base)else strcat (fb_info.fix.id,"Catseye" ); fb_info.fbops = &hpfb_ops; - fb_info.flags =FBINFO_DEFAULT ; fb_info.var = hpfb_defined; fb_info.screen_base = (char *)fb_start;
drivers/video/fbdev/macfb.c +0 -1
@@ -876,7 +876,6 @@ static int __init macfb_init(void) fb_info.var = macfb_defined; fb_info.fix = macfb_fix; fb_info.pseudo_palette = pseudo_palette; - fb_info.flags =FBINFO_DEFAULT ; err =fb_alloc_cmap (&fb_info.cmap, video_cmap_len,0 );if (err)
drivers/video/fbdev/maxinefb.c +0 -1
@@ -155,7 +155,6 @@ int __init maxinefb_init(void) fb_info.screen_base = (char *)maxinefb_fix.smem_start; fb_info.var = maxinefb_defined; fb_info.fix = maxinefb_fix; - fb_info.flags =FBINFO_DEFAULT ;fb_alloc_cmap (&fb_info.cmap,256 ,0 );
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 3/18 fbdev: Remove FBINFO_DEFAULT from kzalloc()'ed structs
In reply to Thomas ZimmermannThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/controlfb.c | 2 +- drivers/video/fbdev/cyber2000fb.c | 2 +- drivers/video/fbdev/valkyriefb.c | 1 - drivers/video/fbdev/vermilion/vermilion.c | 2 +- drivers/video/fbdev/vt8500lcdfb.c | 3 +-- 5 files changed, 4 insertions(+), 6 deletions(-)
drivers/video/fbdev/controlfb.c +1 -1
@@ -775,7 +775,7 @@ static void __init control_init_info(struct fb_info *info, struct fb_info_contro info->par = &p->par; info->fbops = &controlfb_ops; info->pseudo_palette = p->pseudo_palette; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; info->screen_base = p->frame_buffer +CTRLFB_OFF ;fb_alloc_cmap (&info->cmap,256 ,0 );
drivers/video/fbdev/cyber2000fb.c +1 -1
@@ -1459,7 +1459,7 @@ static struct cfb_info *cyberpro_alloc_fb_info(unsigned int id, char *name) cfb->fb.var.accel_flags =FB_ACCELF_TEXT ; cfb->fb.fbops = &cyber2000fb_ops; - cfb->fb.flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + cfb->fb.flags =FBINFO_HWACCEL_YPAN ; cfb->fb.pseudo_palette = cfb->pseudo_palette;spin_lock_init (&cfb->reg_b0_lock);
drivers/video/fbdev/valkyriefb.c +0 -1
@@ -535,7 +535,6 @@ static int __init valkyrie_init_info(struct fb_info *info, { info->fbops = &valkyriefb_ops; info->screen_base = p->frame_buffer +0x1000 ; - info->flags =FBINFO_DEFAULT ; info->pseudo_palette = p->pseudo_palette; info->par = &p->par;return fb_alloc_cmap (&info->cmap,256 ,0 );
drivers/video/fbdev/vermilion/vermilion.c +1 -1
@@ -477,7 +477,7 @@ static int vml_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) } info = &vinfo->info; - info->flags =FBINFO_DEFAULT |FBINFO_PARTIAL_PAN_OK ; + info->flags =FBINFO_PARTIAL_PAN_OK ; err =vmlfb_enable_mmio (par);if (err)
drivers/video/fbdev/vt8500lcdfb.c +1 -2
@@ -300,8 +300,7 @@ static int vt8500lcd_probe(struct platform_device *pdev) fbi->fb.var.vmode =FB_VMODE_NONINTERLACED ; fbi->fb.fbops = &vt8500lcd_ops; - fbi->fb.flags =FBINFO_DEFAULT - |FBINFO_HWACCEL_COPYAREA + fbi->fb.flags =FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_YPAN |FBINFO_VIRTFB
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 4/18 fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs
In reply to Thomas ZimmermannThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/pxafb.c | 1 - drivers/video/fbdev/sa1100fb.c | 1 - drivers/video/fbdev/wm8505fb.c | 3 +-- drivers/video/fbdev/xilinxfb.c | 1 - 4 files changed, 1 insertion(+), 5 deletions(-)
drivers/video/fbdev/pxafb.c +0 -1
@@ -1826,7 +1826,6 @@ static struct pxafb_info *pxafb_init_fbinfo(struct device *dev, fbi->fb.var.vmode =FB_VMODE_NONINTERLACED ; fbi->fb.fbops = &pxafb_ops; - fbi->fb.flags =FBINFO_DEFAULT ; fbi->fb.node =-1 ; addr = fbi;
drivers/video/fbdev/sa1100fb.c +0 -1
@@ -1089,7 +1089,6 @@ static struct sa1100fb_info *sa1100fb_init_fbinfo(struct device *dev) fbi->fb.var.vmode =FB_VMODE_NONINTERLACED ; fbi->fb.fbops = &sa1100fb_ops; - fbi->fb.flags =FBINFO_DEFAULT ; fbi->fb.monspecs = monspecs; fbi->fb.pseudo_palette = fbi->pseudo_palette;
drivers/video/fbdev/wm8505fb.c +1 -2
@@ -285,8 +285,7 @@ static int wm8505fb_probe(struct platform_device *pdev) fbi->fb.fix.accel =FB_ACCEL_NONE ; fbi->fb.fbops = &wm8505fb_ops; - fbi->fb.flags =FBINFO_DEFAULT - |FBINFO_HWACCEL_COPYAREA + fbi->fb.flags =FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN
drivers/video/fbdev/xilinxfb.c +0 -1
@@ -324,7 +324,6 @@ static int xilinxfb_assign(struct platform_device *pdev, drvdata->info.fix.line_length = pdata->xvirt *BYTES_PER_PIXEL ; drvdata->info.pseudo_palette = drvdata->pseudo_palette; - drvdata->info.flags =FBINFO_DEFAULT ; drvdata->info.var = xilinx_fb_var; drvdata->info.var.height = pdata->screen_height_mm; drvdata->info.var.width = pdata->screen_width_mm;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 5/18 fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structs
In reply to Thomas ZimmermannThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/amifb.c | 5 ++--- drivers/video/fbdev/asiliantfb.c | 1 - drivers/video/fbdev/atmel_lcdfb.c | 2 +- drivers/video/fbdev/aty/atyfb_base.c | 3 +-- drivers/video/fbdev/aty/radeon_base.c | 3 +-- drivers/video/fbdev/bw2.c | 1 - drivers/video/fbdev/carminefb.c | 1 - drivers/video/fbdev/cg14.c | 2 +- drivers/video/fbdev/cg3.c | 1 - drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/chipsfb.c | 1 - drivers/video/fbdev/cirrusfb.c | 3 +-- drivers/video/fbdev/clps711x-fb.c | 1 - drivers/video/fbdev/cobalt_lcdfb.c | 1 - drivers/video/fbdev/ep93xx-fb.c | 1 - drivers/video/fbdev/ffb.c | 3 +-- drivers/video/fbdev/fm2fb.c | 1 - drivers/video/fbdev/gbefb.c | 1 - drivers/video/fbdev/geode/gx1fb_core.c | 1 - drivers/video/fbdev/geode/gxfb_core.c | 1 - drivers/video/fbdev/geode/lxfb_core.c | 1 - drivers/video/fbdev/grvga.c | 2 +- drivers/video/fbdev/hgafb.c | 2 +- drivers/video/fbdev/hitfb.c | 2 +- drivers/video/fbdev/hyperv_fb.c | 2 -- drivers/video/fbdev/i740fb.c | 2 +- drivers/video/fbdev/i810/i810_main.c | 4 ++-- drivers/video/fbdev/imsttfb.c | 3 +-- drivers/video/fbdev/intelfb/intelfbdrv.c | 4 ++-- drivers/video/fbdev/kyro/fbdev.c | 1 - drivers/video/fbdev/leo.c | 1 - drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- drivers/video/fbdev/neofb.c | 2 +- drivers/video/fbdev/nvidia/nvidia.c | 4 ++-- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/p9100.c | 1 - drivers/video/fbdev/platinumfb.c | 1 - drivers/video/fbdev/pm2fb.c | 3 +-- drivers/video/fbdev/pm3fb.c | 3 +-- drivers/video/fbdev/pmag-aa-fb.c | 1 - drivers/video/fbdev/pmag-ba-fb.c | 1 - drivers/video/fbdev/pmagb-b-fb.c | 1 - drivers/video/fbdev/ps3fb.c | 2 +- drivers/video/fbdev/pvr2fb.c | 2 +- drivers/video/fbdev/pxa168fb.c | 2 +- drivers/video/fbdev/q40fb.c | 1 - drivers/video/fbdev/riva/fbdev.c | 3 +-- drivers/video/fbdev/s1d13xxxfb.c | 4 ++-- drivers/video/fbdev/savage/savagefb_driver.c | 3 +-- drivers/video/fbdev/simplefb.c | 1 - drivers/video/fbdev/sis/sis_main.c | 3 +-- drivers/video/fbdev/skeletonfb.c | 2 +- drivers/video/fbdev/smscufx.c | 2 +- drivers/video/fbdev/sstfb.c | 1 - drivers/video/fbdev/sunxvr1000.c | 1 - drivers/video/fbdev/sunxvr2500.c | 1 - drivers/video/fbdev/sunxvr500.c | 1 - drivers/video/fbdev/tcx.c | 1 - drivers/video/fbdev/tdfxfb.c | 2 +- drivers/video/fbdev/tgafb.c | 2 +- drivers/video/fbdev/tridentfb.c | 2 +- drivers/video/fbdev/udlfb.c | 2 +- drivers/video/fbdev/via/viafbdev.c | 2 +- 64 files changed, 41 insertions(+), 81 deletions(-)
drivers/video/fbdev/amifb.c +2 -3
@@ -2427,7 +2427,7 @@ static int amifb_set_par(struct fb_info *info) info->fix.ywrapstep =1 ; info->fix.xpanstep =0 ; info->fix.ypanstep =0 ; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YWRAP | + info->flags =FBINFO_HWACCEL_YWRAP |FBINFO_READS_FAST ;/* override SCROLL_REDRAW */ }else { info->fix.ywrapstep =0 ;
@@ -2436,7 +2436,7 @@ static int amifb_set_par(struct fb_info *info)else info->fix.xpanstep =16 << maxfmode; info->fix.ypanstep =1 ; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; }return 0 ; }
@@ -3660,7 +3660,6 @@ static int __init amifb_probe(struct platform_device *pdev) } info->fbops = &amifb_ops; - info->flags =FBINFO_DEFAULT ; info->device = &pdev->dev; if (!fb_find_mode(&info->var, info, mode_option, ami_modedb,
drivers/video/fbdev/asiliantfb.c +0 -1
@@ -516,7 +516,6 @@ static int init_asiliant(struct fb_info *p, unsigned long addr) p->fix.smem_start = addr; p->var = asiliantfb_var; p->fbops = &asiliantfb_ops; - p->flags =FBINFO_DEFAULT ; err =fb_alloc_cmap (&p->cmap,256 ,0 );if (err) {
drivers/video/fbdev/atmel_lcdfb.c +1 -1
@@ -1059,7 +1059,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)if (IS_ERR (sinfo->reg_lcd)) sinfo->reg_lcd =NULL ; - info->flags =FBINFO_DEFAULT |FBINFO_PARTIAL_PAN_OK | + info->flags =FBINFO_PARTIAL_PAN_OK |FBINFO_HWACCEL_YPAN ; info->pseudo_palette = sinfo->pseudo_palette; info->fbops = &atmel_lcdfb_ops;
drivers/video/fbdev/aty/atyfb_base.c +1 -2
@@ -2637,8 +2637,7 @@ static int aty_init(struct fb_info *info) info->fbops = &atyfb_ops; info->pseudo_palette = par->pseudo_palette; - info->flags =FBINFO_DEFAULT | -FBINFO_HWACCEL_IMAGEBLIT | + info->flags =FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_YPAN |
drivers/video/fbdev/aty/radeon_base.c +1 -2
@@ -1972,8 +1972,7 @@ static int radeon_set_fbinfo(struct radeonfb_info *rinfo) info->par = rinfo; info->pseudo_palette = rinfo->pseudo_palette; - info->flags =FBINFO_DEFAULT - |FBINFO_HWACCEL_COPYAREA + info->flags =FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN ;
drivers/video/fbdev/bw2.c +0 -1
@@ -314,7 +314,6 @@ static int bw2_probe(struct platform_device *op) info->fix.smem_len =PAGE_ALIGN (linebytes * info->var.yres); - info->flags =FBINFO_DEFAULT ; info->fbops = &bw2_ops; info->screen_base = of_ioremap(&op->resource[0], 0,
drivers/video/fbdev/carminefb.c +0 -1
@@ -561,7 +561,6 @@ static int alloc_carmine_fb(void __iomem *regs, void __iomem *smem_base, info->fix = carminefb_fix; info->pseudo_palette = par->pseudo_palette; - info->flags =FBINFO_DEFAULT ; ret =fb_alloc_cmap (&info->cmap,256 ,1 );if (ret <0 )
drivers/video/fbdev/cg14.c +1 -1
@@ -533,7 +533,7 @@ static int cg14_probe(struct platform_device *op) par->mode =MDI_8_PIX ; par->ramsize = (is_8mb ?0x800000 :0x400000 ); - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; info->fbops = &cg14_ops;__cg14_reset (par);
drivers/video/fbdev/cg3.c +0 -1
@@ -384,7 +384,6 @@ static int cg3_probe(struct platform_device *op)if (!par->regs) goto out_release_fb; - info->flags =FBINFO_DEFAULT ; info->fbops = &cg3_ops; info->screen_base =of_ioremap (&op->resource[0 ],CG3_RAM_OFFSET , info->fix.smem_len,"cg3 ram" );
drivers/video/fbdev/cg6.c +1 -1
@@ -782,7 +782,7 @@ static int cg6_probe(struct platform_device *op) par->fhc =of_ioremap (&op->resource[0 ],CG6_FHC_OFFSET ,sizeof (u32),"cgsix fhc" ); - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_IMAGEBLIT | + info->flags =FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_READS_FAST ; info->fbops = &cg6_ops;
drivers/video/fbdev/chipsfb.c +0 -1
@@ -340,7 +340,6 @@ static void init_chips(struct fb_info *p, unsigned long addr) p->var = chipsfb_var; p->fbops = &chipsfb_ops; - p->flags =FBINFO_DEFAULT ;fb_alloc_cmap (&p->cmap,256 ,0 );
drivers/video/fbdev/cirrusfb.c +1 -2
@@ -1978,8 +1978,7 @@ static int cirrusfb_set_fbinfo(struct fb_info *info)struct fb_var_screeninfo *var = &info->var; info->pseudo_palette = cinfo->pseudo_palette; - info->flags =FBINFO_DEFAULT - |FBINFO_HWACCEL_XPAN + info->flags =FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_IMAGEBLIT
drivers/video/fbdev/clps711x-fb.c +0 -1
@@ -310,7 +310,6 @@ static int clps711x_fb_probe(struct platform_device *pdev) } info->fbops = &clps711x_fb_ops; - info->flags =FBINFO_DEFAULT ; info->var.activate =FB_ACTIVATE_FORCE |FB_ACTIVATE_NOW ; info->var.height =-1 ; info->var.width =-1 ;
drivers/video/fbdev/cobalt_lcdfb.c +0 -1
@@ -313,7 +313,6 @@ static int cobalt_lcdfb_probe(struct platform_device *dev) info->fix.smem_len = info->screen_size; info->pseudo_palette =NULL ; info->par =NULL ; - info->flags =FBINFO_DEFAULT ; retval =register_framebuffer (info);if (retval <0 ) {
drivers/video/fbdev/ep93xx-fb.c +0 -1
@@ -515,7 +515,6 @@ static int ep93xxfb_probe(struct platform_device *pdev) info->fix.accel =FB_ACCEL_NONE ; info->var.activate =FB_ACTIVATE_NOW ; info->var.vmode =FB_VMODE_NONINTERLACED ; - info->flags =FBINFO_DEFAULT ; info->node =-1 ; info->state =FBINFO_STATE_RUNNING ; info->pseudo_palette = &fbi->pseudo_palette;
drivers/video/fbdev/ffb.c +1 -2
@@ -929,8 +929,7 @@ static int ffb_probe(struct platform_device *op)/* Don't mention copyarea, so SCROLL_REDRAW is always * used. It is the fastest on this chip. */ - info->flags = (FBINFO_DEFAULT | -/* FBINFO_HWACCEL_COPYAREA | */ + info->flags = (/* FBINFO_HWACCEL_COPYAREA | */ FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_IMAGEBLIT );
drivers/video/fbdev/fm2fb.c +0 -1
@@ -280,7 +280,6 @@ static int fm2fb_probe(struct zorro_dev *z, const struct zorro_device_id *id) info->pseudo_palette = info->par; info->par =NULL ; info->fix = fb_fix; - info->flags =FBINFO_DEFAULT ;if (register_framebuffer (info) <0 ) {fb_dealloc_cmap (&info->cmap);
drivers/video/fbdev/gbefb.c +0 -1
@@ -1194,7 +1194,6 @@ static int gbefb_probe(struct platform_device *p_dev) info->fbops = &gbefb_ops; info->pseudo_palette = pseudo_palette; - info->flags =FBINFO_DEFAULT ; info->screen_base = gbe_mem;fb_alloc_cmap (&info->cmap,256 ,0 );
drivers/video/fbdev/geode/gx1fb_core.c +0 -1
@@ -294,7 +294,6 @@ static struct fb_info *gx1fb_init_fbinfo(struct device *dev) info->var.vmode =FB_VMODE_NONINTERLACED ; info->fbops = &gx1fb_ops; - info->flags =FBINFO_DEFAULT ; info->node =-1 ; info->pseudo_palette = (void *)par +sizeof (struct geodefb_par );
drivers/video/fbdev/geode/gxfb_core.c +0 -1
@@ -308,7 +308,6 @@ static struct fb_info *gxfb_init_fbinfo(struct device *dev) info->var.vmode =FB_VMODE_NONINTERLACED ; info->fbops = &gxfb_ops; - info->flags =FBINFO_DEFAULT ; info->node =-1 ; info->pseudo_palette = (void *)par +sizeof (struct gxfb_par );
drivers/video/fbdev/geode/lxfb_core.c +0 -1
@@ -432,7 +432,6 @@ static struct fb_info *lxfb_init_fbinfo(struct device *dev) info->var.vmode =FB_VMODE_NONINTERLACED ; info->fbops = &lxfb_ops; - info->flags =FBINFO_DEFAULT ; info->node =-1 ; info->pseudo_palette = (void *)par +sizeof (struct lxfb_par );
drivers/video/fbdev/grvga.c +1 -1
@@ -377,7 +377,7 @@ static int grvga_probe(struct platform_device *dev) info->fbops = &grvga_ops; info->fix = grvga_fix; info->pseudo_palette = par->color_palette; - info->flags =FBINFO_DEFAULT |FBINFO_PARTIAL_PAN_OK |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_PARTIAL_PAN_OK |FBINFO_HWACCEL_YPAN ; info->fix.smem_len = grvga_mem_size; if (!devm_request_mem_region(&dev->dev, dev->resource[0].start,
drivers/video/fbdev/hgafb.c +1 -1
@@ -573,7 +573,7 @@ static int hgafb_probe(struct platform_device *pdev) hga_fix.smem_start = (unsigned long )hga_vram; hga_fix.smem_len = hga_vram_len; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; info->var = hga_default_var; info->fix = hga_fix; info->monspecs.hfmin =0 ;
drivers/video/fbdev/hitfb.c +1 -1
@@ -405,7 +405,7 @@ static int hitfb_probe(struct platform_device *dev) info->var = hitfb_var; info->fix = hitfb_fix; info->pseudo_palette = info->par; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN | + info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_COPYAREA ; info->screen_base = (void *)hitfb_fix.smem_start;
drivers/video/fbdev/hyperv_fb.c +0 -2
@@ -1159,8 +1159,6 @@ static int hvfb_probe(struct hv_device *hdev, }/* Set up fb_info */ - info->flags =FBINFO_DEFAULT ; - info->var.xres_virtual = info->var.xres = screen_width; info->var.yres_virtual = info->var.yres = screen_height; info->var.bits_per_pixel = screen_depth;
drivers/video/fbdev/i740fb.c +1 -1
@@ -1077,7 +1077,7 @@ static int i740fb_probe(struct pci_dev *dev, const struct pci_device_id *ent) info->fix.mmio_len =pci_resource_len (dev,1 ); info->fix.smem_start =pci_resource_start (dev,0 ); info->fix.smem_len = info->screen_size; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ;if (i740fb_setup_ddc_bus (info) ==0 ) { par->ddc_registered = true;
drivers/video/fbdev/i810/i810_main.c +2 -2
@@ -1442,13 +1442,13 @@ static int i810fb_set_par(struct fb_info *info)encode_fix (&info->fix, info);if (info->var.accel_flags && !(par->dev_flags &LOCKUP )) { - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN | + info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_IMAGEBLIT ; info->pixmap.scan_align =2 ; }else { info->pixmap.scan_align =1 ; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; }return 0 ; }
drivers/video/fbdev/imsttfb.c +1 -2
@@ -1447,8 +1447,7 @@ static int init_imstt(struct fb_info *info) info->var.pixclock =1000000 /getclkMHz (par); info->fbops = &imsttfb_ops; - info->flags =FBINFO_DEFAULT | -FBINFO_HWACCEL_COPYAREA | + info->flags =FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_YPAN ;
drivers/video/fbdev/intelfb/intelfbdrv.c +2 -2
@@ -1372,11 +1372,11 @@ static int intelfb_set_par(struct fb_info *info)intelfb_blank (FB_BLANK_UNBLANK , info);if (ACCEL (dinfo, info)) { - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN | + info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_IMAGEBLIT ; }else - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ;kfree (hw);return 0 ;
drivers/video/fbdev/kyro/fbdev.c +0 -1
@@ -716,7 +716,6 @@ static int kyrofb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) info->fbops = &kyrofb_ops; info->fix = kyro_fix; info->pseudo_palette = currentpar->palette; - info->flags =FBINFO_DEFAULT ;SetCoreClockPLL (deviceInfo.pSTGReg, pdev);
drivers/video/fbdev/leo.c +0 -1
@@ -600,7 +600,6 @@ static int leo_probe(struct platform_device *op) !info->screen_base) goto out_unmap_regs; - info->flags =FBINFO_DEFAULT ; info->fbops = &leo_ops; info->pseudo_palette = par->clut_data;
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c +1 -1
@@ -501,7 +501,7 @@ static int mb862xxfb_init_fbinfo(struct fb_info *fbi) fbi->var.accel_flags =0 ; fbi->var.vmode =FB_VMODE_NONINTERLACED ; fbi->var.activate =FB_ACTIVATE_NOW ; - fbi->flags = FBINFO_DEFAULT | + fbi->flags =#ifdef __BIG_ENDIAN FBINFO_FOREIGN_ENDIAN |#endif
drivers/video/fbdev/mmp/fb/mmpfb.c +1 -1
@@ -502,7 +502,7 @@ static int fb_info_setup(struct fb_info *info, {int ret =0 ;/* Initialise static fb parameters.*/ - info->flags =FBINFO_DEFAULT |FBINFO_PARTIAL_PAN_OK | + info->flags =FBINFO_PARTIAL_PAN_OK |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN ; info->node =-1 ;strcpy (info->fix.id, fbi->name);
drivers/video/fbdev/neofb.c +1 -1
@@ -1944,7 +1944,7 @@ static struct fb_info *neo_alloc_fb_info(struct pci_dev *dev, par->internal_display = internal; par->external_display = external; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ;switch (info->fix.accel) {case FB_ACCEL_NEOMAGIC_NM2070 :
drivers/video/fbdev/nvidia/nvidia.c +2 -2
@@ -1111,8 +1111,8 @@ static int nvidia_set_fbinfo(struct fb_info *info)int lpitch;NVTRACE_ENTER (); - info->flags =FBINFO_DEFAULT - |FBINFO_HWACCEL_IMAGEBLIT + info->flags = +FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_YPAN ;
drivers/video/fbdev/offb.c +1 -1
@@ -514,7 +514,7 @@ static void offb_init_fb(struct platform_device *parent, const char *name, info->fbops = &offb_ops; info->screen_base =ioremap (address, fix->smem_len); info->pseudo_palette = par->pseudo_palette; - info->flags =FBINFO_DEFAULT | foreign_endian; + info->flags = foreign_endian;fb_alloc_cmap (&info->cmap,256 ,0 );
drivers/video/fbdev/p9100.c +0 -1
@@ -283,7 +283,6 @@ static int p9100_probe(struct platform_device *op)if (!par->regs) goto out_release_fb; - info->flags =FBINFO_DEFAULT ; info->fbops = &p9100_ops; info->screen_base =of_ioremap (&op->resource[2 ],0 , info->fix.smem_len,"p9100 ram" );
drivers/video/fbdev/platinumfb.c +0 -1
@@ -317,7 +317,6 @@ static void platinum_init_info(struct fb_info *info,/* Fill fb_info */ info->fbops = &platinumfb_ops; info->pseudo_palette = pinfo->pseudo_palette; - info->flags =FBINFO_DEFAULT ; info->screen_base = pinfo->frame_buffer +0x20 ;fb_alloc_cmap (&info->cmap,256 ,0 );
drivers/video/fbdev/pm2fb.c +1 -2
@@ -1657,8 +1657,7 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) info->fbops = &pm2fb_ops; info->fix = pm2fb_fix; info->pseudo_palette = default_par->palette; - info->flags =FBINFO_DEFAULT | -FBINFO_HWACCEL_YPAN | + info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_FILLRECT ;
drivers/video/fbdev/pm3fb.c +1 -2
@@ -1390,8 +1390,7 @@ static int pm3fb_probe(struct pci_dev *dev, const struct pci_device_id *ent) info->fix = pm3fb_fix; info->pseudo_palette = par->palette; - info->flags =FBINFO_DEFAULT | -FBINFO_HWACCEL_XPAN | + info->flags =FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_IMAGEBLIT |
drivers/video/fbdev/pmag-aa-fb.c +0 -1
@@ -174,7 +174,6 @@ static int pmagaafb_probe(struct device *dev) info->fbops = &aafb_ops; info->fix = aafb_fix; info->var = aafb_defined; - info->flags =FBINFO_DEFAULT ;/* Request the I/O MEM resource. */ start = tdev->resource.start;
drivers/video/fbdev/pmag-ba-fb.c +0 -1
@@ -166,7 +166,6 @@ static int pmagbafb_probe(struct device *dev) info->fbops = &pmagbafb_ops; info->fix = pmagbafb_fix; info->var = pmagbafb_defined; - info->flags =FBINFO_DEFAULT ;/* Request the I/O MEM resource. */ start = tdev->resource.start;
drivers/video/fbdev/pmagb-b-fb.c +0 -1
@@ -273,7 +273,6 @@ static int pmagbbfb_probe(struct device *dev) info->fbops = &pmagbbfb_ops; info->fix = pmagbbfb_fix; info->var = pmagbbfb_defined; - info->flags =FBINFO_DEFAULT ;/* Request the I/O MEM resource. */ start = tdev->resource.start;
drivers/video/fbdev/ps3fb.c +1 -1
@@ -1145,7 +1145,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev) info->fix.smem_len = ps3fb_videomemory.size -GPU_FB_START ; info->pseudo_palette = par->pseudo_palette; - info->flags =FBINFO_DEFAULT |FBINFO_READS_FAST | + info->flags =FBINFO_READS_FAST |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN ; retval =fb_alloc_cmap (&info->cmap,256 ,0 );
drivers/video/fbdev/pvr2fb.c +1 -1
@@ -810,7 +810,7 @@ static int __maybe_unused pvr2fb_common_init(void) fb_info->fix = pvr2_fix; fb_info->par = currentpar; fb_info->pseudo_palette = currentpar->palette; - fb_info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + fb_info->flags =FBINFO_HWACCEL_YPAN ;if (video_output ==VO_VGA ) defmode =DEFMODE_VGA ;
drivers/video/fbdev/pxa168fb.c +1 -1
@@ -637,7 +637,7 @@ static int pxa168fb_probe(struct platform_device *pdev)/* * Initialise static fb parameters. */ - info->flags =FBINFO_DEFAULT |FBINFO_PARTIAL_PAN_OK | + info->flags =FBINFO_PARTIAL_PAN_OK |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN ; info->node =-1 ;strscpy (info->fix.id, mi->id,16 );
drivers/video/fbdev/q40fb.c +0 -1
@@ -99,7 +99,6 @@ static int q40fb_probe(struct platform_device *dev) info->var = q40fb_var; info->fix = q40fb_fix; info->fbops = &q40fb_ops; - info->flags =FBINFO_DEFAULT ;/* not as module for now */ info->pseudo_palette = info->par; info->par =NULL ; info->screen_base = (char *) q40fb_fix.smem_start;
drivers/video/fbdev/riva/fbdev.c +1 -2
@@ -1688,8 +1688,7 @@ static int riva_set_fbinfo(struct fb_info *info)struct riva_par *par = info->par;NVTRACE_ENTER (); - info->flags =FBINFO_DEFAULT - |FBINFO_HWACCEL_XPAN + info->flags =FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT
drivers/video/fbdev/s1d13xxxfb.c +2 -2
@@ -869,14 +869,14 @@ static int s1d13xxxfb_probe(struct platform_device *pdev) default_par->regs, info->fix.smem_len / 1024, info->screen_base); info->par = default_par; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; info->fbops = &s1d13xxxfb_fbops;switch (prod_id) {case S1D13506_PROD_ID :/* activate acceleration */ s1d13xxxfb_fbops.fb_fillrect = s1d13xxxfb_bitblt_solidfill; s1d13xxxfb_fbops.fb_copyarea = s1d13xxxfb_bitblt_copyarea; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN | + info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_COPYAREA ;break ;default :
drivers/video/fbdev/savage/savagefb_driver.c +1 -2
@@ -2135,8 +2135,7 @@ static int savage_init_fb_info(struct fb_info *info, struct pci_dev *dev, info->var.accel_flags =0 ; info->fbops = &savagefb_ops; - info->flags =FBINFO_DEFAULT | -FBINFO_HWACCEL_YPAN | + info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_XPAN ; info->pseudo_palette = par->pseudo_palette;
drivers/video/fbdev/simplefb.c +0 -1
@@ -479,7 +479,6 @@ static int simplefb_probe(struct platform_device *pdev) par->size = info->fix.smem_len; info->fbops = &simplefb_ops; - info->flags =FBINFO_DEFAULT ; info->screen_base =ioremap_wc (info->fix.smem_start, info->fix.smem_len);if (!info->screen_base) {
drivers/video/fbdev/sis/sis_main.c +1 -2
@@ -6472,8 +6472,7 @@ error_3: vfree(ivideo->bios_abase);sisfb_initaccel (ivideo);#if defined(FBINFO_HWACCEL_DISABLED ) && defined(FBINFO_HWACCEL_XPAN ) - sis_fb_info->flags =FBINFO_DEFAULT | -FBINFO_HWACCEL_YPAN | + sis_fb_info->flags =FBINFO_HWACCEL_YPAN |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT |
drivers/video/fbdev/skeletonfb.c +1 -1
@@ -716,7 +716,7 @@ static int xxxfb_probe(struct pci_dev *dev, const struct pci_device_id *ent)* * NOTE: These are for fbcon use only. */ - info->flags =FBINFO_DEFAULT ; + info->flags =0 ;/********************* This stage is optional ******************************/ /*
drivers/video/fbdev/smscufx.c +1 -1
@@ -114,7 +114,7 @@ static struct fb_fix_screeninfo ufx_fix = { .accel = FB_ACCEL_NONE, }; -static const u32 smscufx_info_flags =FBINFO_DEFAULT |FBINFO_READS_FAST | +static const u32 smscufx_info_flags =FBINFO_READS_FAST |FBINFO_VIRTFB |FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_COPYAREA |FBINFO_MISC_ALWAYS_SETPAR ;
drivers/video/fbdev/sstfb.c +0 -1
@@ -1399,7 +1399,6 @@ static int sstfb_probe(struct pci_dev *pdev, const struct pci_device_id *id)f_ddprintk ("membase_phys: %#lx\n" , fix->smem_start);f_ddprintk ("fbbase_virt: %p\n" , info->screen_base); - info->flags =FBINFO_DEFAULT ; info->fbops = &sstfb_ops; info->pseudo_palette = par->palette;
drivers/video/fbdev/sunxvr1000.c +0 -1
@@ -72,7 +72,6 @@ static int gfb_set_fbinfo(struct gfb_info *gp)struct fb_info *info = gp->info;struct fb_var_screeninfo *var = &info->var; - info->flags =FBINFO_DEFAULT ; info->fbops = &gfb_ops; info->screen_base = gp->fb_base; info->screen_size = gp->fb_size;
drivers/video/fbdev/sunxvr2500.c +0 -1
@@ -77,7 +77,6 @@ static int s3d_set_fbinfo(struct s3d_info *sp)struct fb_info *info = sp->info;struct fb_var_screeninfo *var = &info->var; - info->flags =FBINFO_DEFAULT ; info->fbops = &s3d_ops; info->screen_base = sp->fb_base; info->screen_size = sp->fb_size;
drivers/video/fbdev/sunxvr500.c +0 -1
@@ -200,7 +200,6 @@ static int e3d_set_fbinfo(struct e3d_info *ep)struct fb_info *info = ep->info;struct fb_var_screeninfo *var = &info->var; - info->flags =FBINFO_DEFAULT ; info->fbops = &e3d_ops; info->screen_base = ep->fb_base; info->screen_size = ep->fb_size;
drivers/video/fbdev/tcx.c +0 -1
@@ -438,7 +438,6 @@ static int tcx_probe(struct platform_device *op) par->mmap_map[i].poff = op->resource[j].start; } - info->flags =FBINFO_DEFAULT ; info->fbops = &tcx_ops;/* Initialize brooktree DAC. */
drivers/video/fbdev/tdfxfb.c +1 -1
@@ -1468,7 +1468,7 @@ static int tdfxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id) info->fbops = &tdfxfb_ops; info->pseudo_palette = default_par->palette; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ;#ifdef CONFIG_FB_3DFX_ACCEL info->flags |=FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_COPYAREA |
drivers/video/fbdev/tgafb.c +1 -1
@@ -1470,7 +1470,7 @@ static int tgafb_register(struct device *dev) par->tga_chip_rev =TGA_READ_REG (par,TGA_START_REG ) &0xff ;/* Setup framebuffer. */ - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_COPYAREA | + info->flags =FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_FILLRECT ; info->fbops = &tgafb_ops; info->screen_base = par->tga_fb_base;
drivers/video/fbdev/tridentfb.c +1 -1
@@ -1600,7 +1600,7 @@ static int trident_pci_probe(struct pci_dev *dev, info->fbops = &tridentfb_ops; info->pseudo_palette = default_par->pseudo_pal; - info->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ;if (!noaccel && default_par->init_accel) { info->flags &= ~FBINFO_HWACCEL_DISABLED ; info->flags |=FBINFO_HWACCEL_COPYAREA ;
drivers/video/fbdev/udlfb.c +1 -1
@@ -39,7 +39,7 @@ static const struct fb_fix_screeninfo dlfb_fix = { .accel = FB_ACCEL_NONE, }; -static const u32 udlfb_info_flags =FBINFO_DEFAULT |FBINFO_READS_FAST | +static const u32 udlfb_info_flags =FBINFO_READS_FAST |FBINFO_VIRTFB |FBINFO_HWACCEL_IMAGEBLIT |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_COPYAREA |FBINFO_MISC_ALWAYS_SETPAR ;
drivers/video/fbdev/via/viafbdev.c +1 -1
@@ -1770,7 +1770,7 @@ int via_fb_pci_probe(struct viafb_dev *vdev) viafbinfo->fix.mmio_len = vdev->engine_len; viafbinfo->node =0 ; viafbinfo->fbops = &viafb_ops; - viafbinfo->flags =FBINFO_DEFAULT |FBINFO_HWACCEL_YPAN ; + viafbinfo->flags =FBINFO_HWACCEL_YPAN ; viafbinfo->pseudo_palette = pseudo_pal;if (viafb_accel && !viafb_setup_engine (viafbinfo)) {
Signature · 1 line
2.41.0
Thomas Zimmermann
maintainerPATCH v4 6/18 fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT
In reply to Thomas ZimmermannThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/fsl-diu-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/fsl-diu-fb.c +1 -1
@@ -1476,7 +1476,7 @@ static int install_fb(struct fb_info *info) info->var.activate =FB_ACTIVATE_NOW ; info->fbops = &fsl_diu_ops; - info->flags =FBINFO_DEFAULT |FBINFO_VIRTFB |FBINFO_PARTIAL_PAN_OK | + info->flags =FBINFO_VIRTFB |FBINFO_PARTIAL_PAN_OK |FBINFO_READS_FAST ; info->pseudo_palette = mfbi->pseudo_palette;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 7/18 vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver
In reply to Thomas ZimmermannThe flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- samples/vfio-mdev/mdpy-fb.c | 1 - 1 file changed, 1 deletion(-)
samples/vfio-mdev/mdpy-fb.c +0 -1
@@ -162,7 +162,6 @@ static int mdpy_fb_probe(struct pci_dev *pdev, } info->fbops = &mdpy_fb_ops; - info->flags =FBINFO_DEFAULT ; info->pseudo_palette = par->palette; ret =register_framebuffer (info);
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 8/18 sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag
In reply to Thomas ZimmermannAssign FB_MODE_IS_UNKNOWN to sh7763fb_videomode.flag instead of FBINFO_FLAG_DEFAULT. Both are 0, so the stored value does not change.
FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info. Flags for videomodes are prefixed with FB_MODE_.
v3:
* include board name in commit message (Adrian)
v2:
* assign FB_MODE_IS_UNKNOWN (Adrian)
--- arch/sh/boards/mach-sh7763rdp/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/boards/mach-sh7763rdp/setup.c +1 -1
@@ -119,7 +119,7 @@ static struct fb_videomode sh7763fb_videomode = { .vsync_len = 1, .sync = 0, .vmode = FB_VMODE_NONINTERLACED, - .flag = FBINFO_FLAG_DEFAULT, + .flag = FB_MODE_IS_UNKNOWN, };static struct sh7760fb_platdata sh7763fb_def_pdata = {
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 9/18 auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/auxdisplay/cfag12864bfb.c | 1 - drivers/auxdisplay/ht16k33.c | 1 - 2 files changed, 2 deletions(-)
drivers/auxdisplay/cfag12864bfb.c +0 -1
@@ -79,7 +79,6 @@ static int cfag12864bfb_probe(struct platform_device *device) info->var = cfag12864bfb_var; info->pseudo_palette =NULL ; info->par =NULL ; - info->flags =FBINFO_FLAG_DEFAULT ;if (register_framebuffer (info) <0 ) goto fballoced;
drivers/auxdisplay/ht16k33.c +0 -1
@@ -646,7 +646,6 @@ static int ht16k33_fbdev_probe(struct device *dev, struct ht16k33_priv *priv, fbdev->info->var = ht16k33_fb_var; fbdev->info->bl_dev = bl; fbdev->info->pseudo_palette =NULL ; - fbdev->info->flags =FBINFO_FLAG_DEFAULT ; fbdev->info->par = priv; err =register_framebuffer (fbdev->info);
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 10/18 hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/hid/hid-picolcd_fb.c | 1 - 1 file changed, 1 deletion(-)
drivers/hid/hid-picolcd_fb.c +0 -1
@@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data) info->var = picolcdfb_var; info->fix = picolcdfb_fix; info->fix.smem_len =PICOLCDFB_SIZE *8 ; - info->flags =FBINFO_FLAG_DEFAULT ; fbdata = info->par;spin_lock_init (&fbdata->lock);
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 11/18 media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/media/pci/ivtv/ivtvfb.c | 1 - drivers/media/test-drivers/vivid/vivid-osd.c | 1 - 2 files changed, 2 deletions(-)
drivers/media/pci/ivtv/ivtvfb.c +0 -1
@@ -1048,7 +1048,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)/* Generate valid fb_info */ oi->ivtvfb_info.node =-1 ; - oi->ivtvfb_info.flags =FBINFO_FLAG_DEFAULT ; oi->ivtvfb_info.par = itv; oi->ivtvfb_info.var = oi->ivtvfb_defined; oi->ivtvfb_info.fix = oi->ivtvfb_fix;
drivers/media/test-drivers/vivid/vivid-osd.c +0 -1
@@ -310,7 +310,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)/* Generate valid fb_info */ dev->fb_info.node =-1 ; - dev->fb_info.flags =FBINFO_FLAG_DEFAULT ; dev->fb_info.par = dev; dev->fb_info.var = dev->fb_defined; dev->fb_info.fix = dev->fb_fix;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v4 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Hi Thomas,
Quoted 15 lines · Thomas Zimmermann
The flag
FBINFO_FLAG_DEFAULTis 0 and has no effect, as struct fbinfo.flags has been allocated to zero bykzalloc(). So do not set it.Flags should signal differences from the default values. After cleaning up all occurrences of
FBINFO_DEFAULT, the token will be removed.v2:
* fix commit message (Miguel)Signed-off-by Thomas Zimmermann <[email protected]>Acked-by Sam Ravnborg <[email protected]>Cc Andy Walls <[email protected]>Cc Mauro Carvalho Chehab <[email protected]>Cc Hans Verkuil <[email protected]>
Quoted 4 lines
--- drivers/media/pci/ivtv/ivtvfb.c | 1 - drivers/media/test-drivers/vivid/vivid-osd.c | 1 - 2 files changed, 2 deletions(-)
I can take this patches for 6.6, unless you prefer to have this whole series merged in one go?
In that case you can use my:
Regards,
Hans
Quoted 25 lines
drivers/media/pci/ivtv/ivtvfb.c +0
-1@@ -1048,7 +1048,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)/* Generate valid fb_info */ oi->ivtvfb_info.node =-1 ; - oi->ivtvfb_info.flags =FBINFO_FLAG_DEFAULT ; oi->ivtvfb_info.par = itv; oi->ivtvfb_info.var = oi->ivtvfb_defined; oi->ivtvfb_info.fix = oi->ivtvfb_fix;drivers/media/test-drivers/vivid/vivid-osd.c +0
-1@@ -310,7 +310,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)/* Generate valid fb_info */ dev->fb_info.node =-1 ; - dev->fb_info.flags =FBINFO_FLAG_DEFAULT ; dev->fb_info.par = dev; dev->fb_info.var = dev->fb_defined; dev->fb_info.fix = dev->fb_fix;
Thomas Zimmermann
maintainerPATCH v4 12/18 staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/staging/fbtft/fbtft-core.c | 2 +- drivers/staging/sm750fb/sm750.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
@@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, info->var.transp.offset =0 ; info->var.transp.length =0 ; - info->flags =FBINFO_FLAG_DEFAULT |FBINFO_VIRTFB ; + info->flags =FBINFO_VIRTFB ; par = info->par; par->info = info;
drivers/staging/sm750fb/sm750.c +0 -1
@@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) info->screen_base = crtc->v_screen;pr_debug ("screen_base vaddr = %p\n" , info->screen_base); info->screen_size = line_length * var->yres_virtual; - info->flags =FBINFO_FLAG_DEFAULT |0 ;/* set info->fix */ fix->type =FB_TYPE_PACKED_PIXELS ;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v4 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Quoted 7 lines · Thomas Zimmermann
The flag
FBINFO_FLAG_DEFAULTis 0 and has no effect, as struct fbinfo.flags has been allocated to zero byframebuffer_alloc(). So do not set it.Flags should signal differences from the default values. After cleaning up all occurrences of
FBINFO_DEFAULT, the token will be removed.
Quoted 8 lines
v2:
* fix commit message (Miguel)Signed-off-by Thomas Zimmermann <[email protected]>Acked-by Sam Ravnborg <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Sudip Mukherjee <[email protected]>Cc Teddy Wang <[email protected]>
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 13/18 fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/amba-clcd.c | 1 - drivers/video/fbdev/matrox/matroxfb_crtc2.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/video/fbdev/amba-clcd.c +0 -1
@@ -461,7 +461,6 @@ static int clcdfb_register(struct clcd_fb *fb) } fb->fb.fbops = &clcdfb_ops; - fb->fb.flags =FBINFO_FLAG_DEFAULT ; fb->fb.pseudo_palette = fb->cmap;strncpy (fb->fb.fix.id, clcd_name,sizeof (fb->fb.fix.id));
drivers/video/fbdev/matrox/matroxfb_crtc2.c +2 -3
@@ -603,9 +603,8 @@ static int matroxfb_dh_regit(const struct matrox_fb_info *minfo,void * oldcrtc2; m2info->fbcon.fbops = &matroxfb_dh_ops; - m2info->fbcon.flags =FBINFO_FLAG_DEFAULT ; - m2info->fbcon.flags |=FBINFO_HWACCEL_XPAN | -FBINFO_HWACCEL_YPAN ; + m2info->fbcon.flags =FBINFO_HWACCEL_XPAN | +FBINFO_HWACCEL_YPAN ; m2info->fbcon.pseudo_palette = m2info->cmap;fb_alloc_cmap (&m2info->fbcon.cmap,256 ,1 );
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 14/18 fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/arcfb.c | 1 - drivers/video/fbdev/aty/aty128fb.c | 1 - drivers/video/fbdev/broadsheetfb.c | 2 +- drivers/video/fbdev/da8xx-fb.c | 1 - drivers/video/fbdev/efifb.c | 1 - drivers/video/fbdev/goldfishfb.c | 1 - drivers/video/fbdev/gxt4500.c | 3 +-- drivers/video/fbdev/hecubafb.c | 2 +- drivers/video/fbdev/imxfb.c | 3 +-- drivers/video/fbdev/intelfb/intelfbdrv.c | 1 - drivers/video/fbdev/metronomefb.c | 2 +- drivers/video/fbdev/mx3fb.c | 1 - drivers/video/fbdev/omap/omapfb_main.c | 1 - drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 - drivers/video/fbdev/s3c-fb.c | 1 - drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 -- drivers/video/fbdev/sis/sis_main.c | 2 -- drivers/video/fbdev/sm501fb.c | 2 +- drivers/video/fbdev/sm712fb.c | 1 - drivers/video/fbdev/uvesafb.c | 3 +-- drivers/video/fbdev/vesafb.c | 2 +- drivers/video/fbdev/vfb.c | 1 - drivers/video/fbdev/vga16fb.c | 2 +- drivers/video/fbdev/xen-fbfront.c | 2 +- 24 files changed, 10 insertions(+), 29 deletions(-)
drivers/video/fbdev/arcfb.c +0 -1
@@ -546,7 +546,6 @@ static int arcfb_probe(struct platform_device *dev) par->c2io_addr = c2io_addr; par->cslut[0 ] =0x00 ; par->cslut[1 ] =0x06 ; - info->flags =FBINFO_FLAG_DEFAULT ;spin_lock_init (&par->lock);if (irq) { par->irq = irq;
drivers/video/fbdev/aty/aty128fb.c +0 -1
@@ -1927,7 +1927,6 @@ static int aty128_init(struct pci_dev *pdev, const struct pci_device_id *ent)/* fill in info */ info->fbops = &aty128fb_ops; - info->flags =FBINFO_FLAG_DEFAULT ; par->lcd_on = default_lcd_on; par->crt_on = default_crt_on;
drivers/video/fbdev/broadsheetfb.c +1 -1
@@ -1069,7 +1069,7 @@ static int broadsheetfb_probe(struct platform_device *dev)mutex_init (&par->io_lock); - info->flags =FBINFO_FLAG_DEFAULT |FBINFO_VIRTFB ; + info->flags =FBINFO_VIRTFB ; info->fbdefio = &broadsheetfb_defio;fb_deferred_io_init (info);
drivers/video/fbdev/da8xx-fb.c +0 -1
@@ -1463,7 +1463,6 @@ static int fb_probe(struct platform_device *device) da8xx_fb_var.bits_per_pixel = lcd_cfg->bpp;/* Initialize fbinfo */ - da8xx_fb_info->flags =FBINFO_FLAG_DEFAULT ; da8xx_fb_info->fix = da8xx_fb_fix; da8xx_fb_info->var = da8xx_fb_var; da8xx_fb_info->fbops = &da8xx_fb_ops;
drivers/video/fbdev/efifb.c +0 -1
@@ -555,7 +555,6 @@ static int efifb_probe(struct platform_device *dev) info->fbops = &efifb_ops; info->var = efifb_defined; info->fix = efifb_fix; - info->flags =FBINFO_FLAG_DEFAULT ; orientation =drm_get_panel_orientation_quirk (efifb_defined.xres, efifb_defined.yres);
drivers/video/fbdev/goldfishfb.c +0 -1
@@ -212,7 +212,6 @@ static int goldfish_fb_probe(struct platform_device *pdev) height =readl (fb->reg_base +FB_GET_HEIGHT ); fb->fb.fbops = &goldfish_fb_ops; - fb->fb.flags =FBINFO_FLAG_DEFAULT ; fb->fb.pseudo_palette = fb->cmap; fb->fb.fix.type =FB_TYPE_PACKED_PIXELS ; fb->fb.fix.visual =FB_VISUAL_TRUECOLOR ;
drivers/video/fbdev/gxt4500.c +1 -2
@@ -690,8 +690,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)#endif info->fbops = &gxt4500_ops; - info->flags =FBINFO_FLAG_DEFAULT |FBINFO_HWACCEL_XPAN | -FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN ; err =fb_alloc_cmap (&info->cmap,256 ,0 );if (err) {
drivers/video/fbdev/hecubafb.c +1 -1
@@ -189,7 +189,7 @@ static int hecubafb_probe(struct platform_device *dev) par->send_command = apollo_send_command; par->send_data = apollo_send_data; - info->flags =FBINFO_FLAG_DEFAULT |FBINFO_VIRTFB ; + info->flags =FBINFO_VIRTFB ; info->fbdefio = &hecubafb_defio;fb_deferred_io_init (info);
drivers/video/fbdev/imxfb.c +1 -2
@@ -698,8 +698,7 @@ static int imxfb_init_fbinfo(struct platform_device *pdev) info->var.vmode =FB_VMODE_NONINTERLACED ; info->fbops = &imxfb_ops; - info->flags =FBINFO_FLAG_DEFAULT | -FBINFO_READS_FAST ; + info->flags =FBINFO_READS_FAST ; np = pdev->dev.of_node; info->var.grayscale = of_property_read_bool(np,
drivers/video/fbdev/intelfb/intelfbdrv.c +0 -1
@@ -1098,7 +1098,6 @@ static int intelfb_set_fbinfo(struct intelfb_info *dinfo)DBG_MSG ("intelfb_set_fbinfo\n" ); - info->flags =FBINFO_FLAG_DEFAULT ; info->fbops = &intel_fb_ops; info->pseudo_palette = dinfo->pseudo_palette;
drivers/video/fbdev/metronomefb.c +1 -1
@@ -642,7 +642,7 @@ static int metronomefb_probe(struct platform_device *dev)if (retval <0 ) goto err_free_irq; - info->flags =FBINFO_FLAG_DEFAULT |FBINFO_VIRTFB ; + info->flags =FBINFO_VIRTFB ; info->fbdefio = &metronomefb_defio;fb_deferred_io_init (info);
drivers/video/fbdev/mx3fb.c +0 -1
@@ -1406,7 +1406,6 @@ static struct fb_info *mx3fb_init_fbinfo(struct device *dev, fbi->var.activate =FB_ACTIVATE_NOW ; fbi->fbops = ops; - fbi->flags =FBINFO_FLAG_DEFAULT ; fbi->pseudo_palette = mx3fbi->pseudo_palette;mutex_init (&mx3fbi->mutex);
drivers/video/fbdev/omap/omapfb_main.c +0 -1
@@ -1451,7 +1451,6 @@ static int fbinfo_init(struct omapfb_device *fbdev, struct fb_info *info)int r =0 ; info->fbops = &omapfb_ops; - info->flags =FBINFO_FLAG_DEFAULT ;strscpy (fix->id,MODULE_NAME ,sizeof (fix->id));
drivers/video/fbdev/omap2/omapfb/omapfb-main.c +0 -1
@@ -1732,7 +1732,6 @@ static int omapfb_fb_init(struct omapfb2_device *fbdev, struct fb_info *fbi)int r =0 ; fbi->fbops = &omapfb_ops; - fbi->flags =FBINFO_FLAG_DEFAULT ; fbi->pseudo_palette = fbdev->pseudo_palette;if (ofbi->region->size ==0 ) {
drivers/video/fbdev/s3c-fb.c +0 -1
@@ -1244,7 +1244,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no, fbinfo->var.vmode =FB_VMODE_NONINTERLACED ; fbinfo->var.bits_per_pixel = windata->default_bpp; fbinfo->fbops = &s3c_fb_ops; - fbinfo->flags =FBINFO_FLAG_DEFAULT ; fbinfo->pseudo_palette = &win->pseudo_palette;/* prepare to actually start the framebuffer */
drivers/video/fbdev/sh_mobile_lcdcfb.c +0 -2
@@ -1565,7 +1565,6 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) ovl->info = info; - info->flags =FBINFO_FLAG_DEFAULT ; info->fbops = &sh_mobile_lcdc_overlay_ops; info->device = priv->dev; info->screen_buffer = ovl->fb_mem;
@@ -2052,7 +2051,6 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch, ch->info = info; - info->flags =FBINFO_FLAG_DEFAULT ; info->fbops = &sh_mobile_lcdc_ops; info->device = priv->dev; info->screen_buffer = ch->fb_mem;
drivers/video/fbdev/sis/sis_main.c +0 -2
@@ -6477,8 +6477,6 @@ error_3: vfree(ivideo->bios_abase);FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT | ((ivideo->accel) ?0 :FBINFO_HWACCEL_DISABLED ); -#else - sis_fb_info->flags =FBINFO_FLAG_DEFAULT ;#endif sis_fb_info->var = ivideo->default_var; sis_fb_info->fix = ivideo->sisfb_fix;
drivers/video/fbdev/sm501fb.c +1 -1
@@ -1731,7 +1731,7 @@ static int sm501fb_init_fb(struct fb_info *fb, enum sm501_controller head, par->ops.fb_cursor =NULL ; fb->fbops = &par->ops; - fb->flags =FBINFO_FLAG_DEFAULT |FBINFO_READS_FAST | + fb->flags =FBINFO_READS_FAST |FBINFO_HWACCEL_COPYAREA |FBINFO_HWACCEL_FILLRECT |FBINFO_HWACCEL_XPAN |FBINFO_HWACCEL_YPAN ;
drivers/video/fbdev/sm712fb.c +0 -1
@@ -1528,7 +1528,6 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, sfb->fb = info; sfb->chip_id = ent->device; sfb->pdev = pdev; - info->flags =FBINFO_FLAG_DEFAULT ; info->fbops = &smtcfb_ops; info->fix = smtcfb_fix; info->var = smtcfb_var;
drivers/video/fbdev/uvesafb.c +1 -2
@@ -1508,8 +1508,7 @@ static void uvesafb_init_info(struct fb_info *info, struct vbe_mode_ib *mode) par->ypan =0 ; } - info->flags =FBINFO_FLAG_DEFAULT | - (par->ypan ?FBINFO_HWACCEL_YPAN :0 ); + info->flags = (par->ypan ?FBINFO_HWACCEL_YPAN :0 );if (!par->ypan) uvesafb_ops.fb_pan_display =NULL ;
drivers/video/fbdev/vesafb.c +1 -1
@@ -457,7 +457,7 @@ static int vesafb_probe(struct platform_device *dev) info->fbops = &vesafb_ops; info->var = vesafb_defined; info->fix = vesafb_fix; - info->flags =FBINFO_FLAG_DEFAULT | (ypan ?FBINFO_HWACCEL_YPAN :0 ); + info->flags = (ypan ?FBINFO_HWACCEL_YPAN :0 );if (fb_alloc_cmap (&info->cmap,256 ,0 ) <0 ) { err = -ENOMEM ;
drivers/video/fbdev/vfb.c +0 -1
@@ -455,7 +455,6 @@ static int vfb_probe(struct platform_device *dev) info->fix = vfb_fix; info->pseudo_palette = info->par; info->par =NULL ; - info->flags =FBINFO_FLAG_DEFAULT ; retval =fb_alloc_cmap (&info->cmap,256 ,0 );if (retval <0 )
drivers/video/fbdev/vga16fb.c +1 -1
@@ -1359,7 +1359,7 @@ static int vga16fb_probe(struct platform_device *dev) info->fix = vga16fb_fix;/* supports rectangles with widths of multiples of 8 */ info->pixmap.blit_x =1 <<7 |1 <<15 |1 <<23 |1 <<31 ; - info->flags =FBINFO_FLAG_DEFAULT |FBINFO_HWACCEL_YPAN ; + info->flags =FBINFO_HWACCEL_YPAN ; i = (info->var.bits_per_pixel ==8 ) ?256 :16 ; ret =fb_alloc_cmap (&info->cmap, i,0 );
drivers/video/fbdev/xen-fbfront.c +1 -1
@@ -432,7 +432,7 @@ static int xenfb_probe(struct xenbus_device *dev, fb_info->fix.type =FB_TYPE_PACKED_PIXELS ; fb_info->fix.accel =FB_ACCEL_NONE ; - fb_info->flags =FBINFO_FLAG_DEFAULT |FBINFO_VIRTFB ; + fb_info->flags =FBINFO_VIRTFB ; ret =fb_alloc_cmap (&fb_info->cmap,256 ,0 );if (ret <0 ) {
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 15/18 fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/atafb.c | 1 - 1 file changed, 1 deletion(-)
drivers/video/fbdev/atafb.c +0 -1
@@ -3112,7 +3112,6 @@ static int __init atafb_probe(struct platform_device *pdev)#ifdef ATAFB_FALCON fb_info.pseudo_palette = current_par.hw.falcon.pseudo_palette;#endif - fb_info.flags =FBINFO_FLAG_DEFAULT ; if (!fb_find_mode(&fb_info.var, &fb_info, mode_option, atafb_modedb, NUM_TOTAL_MODES, &atafb_modedb[defmode],
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 16/18 fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT
In reply to Thomas ZimmermannThe flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it.
Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
--- drivers/video/fbdev/pxafb.c | 1 - 1 file changed, 1 deletion(-)
drivers/video/fbdev/pxafb.c +0 -1
@@ -888,7 +888,6 @@ static void init_pxafb_overlay(struct pxafb_info *fbi, struct pxafb_layer *ofb, ofb->fb.var.vmode =FB_VMODE_NONINTERLACED ; ofb->fb.fbops = &overlay_fb_ops; - ofb->fb.flags =FBINFO_FLAG_DEFAULT ; ofb->fb.node =-1 ; ofb->fb.pseudo_palette =NULL ;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 17/18 fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT
In reply to Thomas ZimmermannRemove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT. No functional changes.
--- include/linux/fb.h | 3 --- 1 file changed, 3 deletions(-)
include/linux/fb.h +0 -3
@@ -383,7 +383,6 @@ struct fb_tile_ops {#endif /* CONFIG_FB_TILEBLITTING */ /* FBINFO_* = fb_info.flags bit flags */ -#define FBINFO_DEFAULT 0#define FBINFO_HWACCEL_DISABLED 0x0002/* When FBINFO_HWACCEL_DISABLED is set: * Hardware acceleration is turned off. Software implementations
@@ -504,8 +503,6 @@ struct fb_info {bool skip_vt_switch;/* no VT switch on suspend/resume required */ }; -#define FBINFO_FLAG_DEFAULT FBINFO_DEFAULT -/* This will go away * fbset currently hacks in FB_ACCELF_TEXT into var.accel_flags * when it wants to turn the acceleration engine on. This is
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thomas Zimmermann
maintainerPATCH v4 18/18 fbdev: Document that framebuffer_alloc() returns zero'ed data
In reply to Thomas ZimmermannMost fbdev drivers depend on framebuffer_alloc() to initialize the allocated memory to 0. Document this guarantee.
v3:
* slightly reword the sentence (Miguel)
--- drivers/video/fbdev/core/fb_info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/video/fbdev/core/fb_info.c +2 -1
@@ -13,7 +13,8 @@* * Creates a new frame buffer info structure. Also reserves @size bytes * for driver private data (info->par). info->par (if any) will be -* aligned to sizeof(long). +* aligned to sizeof(long). The new instances of struct fb_info and +* the driver private data are both cleared to zero. * * Returns the new structure, or NULL if an error occurred. *
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel