Skip to contentSkip to conversation

HID: hiddev: Modify Format

PATCH In review [email protected] 2 participants 2 messages Jul 16, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 HID: hiddev: Modify Format

Fix the following checkpatch error(s):

ERROR: "inode * inode" should be "inode *inode"
ERROR: "file * file" should be "file *file"

---
 drivers/hid/usbhid/hiddev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/usbhid/hiddev.c +1 -1
index 59cf3ddfdf78..581dc33197d0 100644
@@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, int on)
 /*
  * release file op
  */
-static int hiddev_release(struct inode * inode, struct file * file)
+static int hiddev_release(struct inode *inode, struct file *file)
 {
     struct hiddev_list *list = file->private_data;
     unsigned long flags;
maintainer
#2 lore raw
Quoted 23 lines · On Sun, Jul 16, 2023 at 12:11:11PM +0800, [email protected] wrote:

Fix the following checkpatch error(s):

ERROR: "inode * inode" should be "inode *inode"
ERROR: "file * file" should be "file *file"

---
 drivers/hid/usbhid/hiddev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/usbhid/hiddev.c +1 -1
index 59cf3ddfdf78..581dc33197d0 100644
@@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, int
 on)
 /*
  * release file op
  */
-static int hiddev_release(struct inode * inode, struct file * file)
+static int hiddev_release(struct inode *inode, struct file *file)
 {
     struct hiddev_list *list = file->private_data;
Quoted 1 line
     unsigned long flags;

This patch is corrupted and can not be applied.

Please try working on drivers/staging/* files instead first, to give you a chance to figure out how to do kernel development, before attempting checkpatch changes on subsystems that might not want them.

good luck!

greg k-h