Skip to contentSkip to conversation

proc: Fix four errors in kmsg.c

PATCH In review [email protected] 4 participants 5 messages Jul 14, 2023 – Jul 17, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 proc: Fix four errors in kmsg.c

The following checkpatch errors are removed:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"

---
 fs/proc/kmsg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/proc/kmsg.c +2 -2
index 2fc92a13f9f8..64025da60e2a 100644
@@ -17,12 +17,12 @@
 
 #include <asm/io.h>
 
-static int kmsg_open(struct inode * inode, struct file * file)
+static int kmsg_open(struct inode *inode, struct file *file)
 {
     return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC);
 }
 
-static int kmsg_release(struct inode * inode, struct file * file)
+static int kmsg_release(struct inode *inode, struct file *file)
 {
     (void) do_syslog(SYSLOG_ACTION_CLOSE, NULL, 0, SYSLOG_FROM_PROC);
     return 0;
#2 lore raw
Quoted 5 lines · On Fri 2023-07-14 14:57:59, [email protected] wrote:

The following checkpatch errors are removed:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"

Please, do not do fix these cosmetic issues reported by checkpatch.pl. It is not worth the effort. In fact, it is contra productive. It complicates the git history, backports.

I suggest to find an area in the kernel which might be interesting for you (any driver or subsystem, ...) and try to fix a real bug there or implement a real feature.

You might start with reading the related discussions on lkml or related mailing list, reviewing or testing patches, ...

Best Regards,
Petr

#3 lore raw
Quoted 10 lines · Petr Mladek
Quoted 5 lines · On Fri 2023-07-14 14:57:59, [email protected] wrote:

The following checkpatch errors are removed:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"

Please, do not do fix these cosmetic issues reported by checkpatch.pl. It is not worth the effort. In fact, it is contra productive. It complicates the git history, backports.

BTW, Did anyone suggest you to fix errors/warnings reported by checkpatch.pl?

You seem to be 2nd person who sent similar patch from @suo.com within the last week. The first patch was rejected as well, see
https://lore.kernel.org/all/[email protected]/

You might want to tell this person that there are better ways how to get involved into the kernel development.

Best Regards,
Petr

#4 lore raw
In reply to Petr Mladek
Quoted 10 lines · Petr Mladek
Quoted 5 lines · On Fri 2023-07-14 14:57:59, [email protected] wrote:

The following checkpatch errors are removed:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"

Please, do not do fix these cosmetic issues reported by checkpatch.pl. It is not worth the effort. In fact, it is contra productive. It complicates the git history, backports.

Absolutely agree with Petr.

As a side note, I wonder if checkpatch can deprecate that -f option?

#5 lore raw
Quoted 8 lines · Sergey Senozhatsky
Quoted 7 lines · Petr Mladek
Quoted 5 lines · On Fri 2023-07-14 14:57:59, [email protected] wrote:

The following checkpatch errors are removed:
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"

Quoted 7 lines
Quoted 3 lines

Please, do not do fix these cosmetic issues reported by checkpatch.pl. It is not worth the effort. In fact, it is contra productive. It complicates the git history, backports.

Absolutely agree with Petr.

As a side note, I wonder if checkpatch can deprecate that -f option?

Either that or document in very strong language that it should only be used in very special circumstances, usually by the file owner or maintainer.

Signature · 1 line
~Randy