media: aspeed: Fix memory overwrite if timing is 1600x900
PATCH v2 1/1 media: aspeed: Fix memory overwrite if timing is 1600x900
When capturing 1600x900, system could crash when system memory usage is tight.
The way to reproduce this issue:
1. Use 1600x900 to display on host
2. Mount ISO through 'Virtual media' on OpenBMC's web
3. Run script as below on host to do sha continuously #!/bin/bash
while [ [1] ];
do
find /media -type f -printf '"%h/%f"\n' | xargs sha256sum
done
4. Open KVM on OpenBMC's web
The size of macro block captured is 8x8. Therefore, we should make sure the height of src-buf is 8 aligned to fix this issue.
---
v2 changes
- Add how to reproduce this issue.
--- drivers/media/platform/aspeed/aspeed-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/aspeed/aspeed-video.c +2 -2
@@ -1130,7 +1130,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)static void aspeed_video_set_resolution (struct aspeed_video *video) {struct v4l2_bt_timings *act = &video->active_timings; -unsigned int size = act->width * act->height; +unsigned int size = act->width *ALIGN (act->height,8 );/* Set capture/compression frame sizes */ aspeed_video_calc_compressed_size (video, size);
@@ -1147,7 +1147,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video)u32 width =ALIGN (act->width,64 );aspeed_video_write (video,VE_CAP_WINDOW , width <<16 | act->height); - size = width * act->height; + size = width *ALIGN (act->height,8 ); }else {aspeed_video_write (video,VE_CAP_WINDOW , act->width <<16 | act->height);
base-commit: 2605e80d3438c77190f55b821c6575048c68268e
Signature · 1 line
2.25.1
Hi Jammy,
Quoted 10 lines · Jammy Huang
When capturing 1600x900, system could crash when system memory usage is tight.
The way to reproduce this issue:
1. Use 1600x900 to display on host
2. Mount ISO through 'Virtual media' on OpenBMC's web
3. Run script as below on host to do sha continuously #!/bin/bash
while [ [1] ];
do
Quoted 8 lines
find /media -type f -printf '"%h/%f"\n' | xargs sha256sumdone
4. Open KVM on OpenBMC's webThe size of macro block captured is 8x8. Therefore, we should make sure the height of src-buf is 8 aligned to fix this issue.
Signed-off-by Jammy Huang <[email protected]>
Your email address you sent this from differs from your SoB. Can you post again from the correct email address? Checkpatch complains about this.
Regards,
Hans
Quoted 31 lines
---
v2 changes
- Add how to reproduce this issue.--- drivers/media/platform/aspeed/aspeed-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/aspeed/aspeed-video.c +2
-2@@ -1130,7 +1130,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)static void aspeed_video_set_resolution (struct aspeed_video *video) {struct v4l2_bt_timings *act = &video->active_timings; -unsigned int size = act->width * act->height; +unsigned int size = act->width *ALIGN (act->height,8 );/* Set capture/compression frame sizes */ aspeed_video_calc_compressed_size (video, size);@@ -1147,7 +1147,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video)u32 width =ALIGN (act->width,64 );aspeed_video_write (video,VE_CAP_WINDOW , width <<16 | act->height); - size = width * act->height; + size = width *ALIGN (act->height,8 ); }else {aspeed_video_write (video,VE_CAP_WINDOW , act->width <<16 | act->height);base-commit:
2605e80d3438c77190f55b821c6575048c68268e
Hi Hans,
ASPEED's mail server had some problem these days. I will try to resend the patch.
Thank you.
Quoted 61 lines · Hans Verkuil
Hi Jammy,
Quoted 10 lines · Jammy Huang
When capturing 1600x900, system could crash when system memory usage is tight.
The way to reproduce this issue:
1. Use 1600x900 to display on host
2. Mount ISO through 'Virtual media' on OpenBMC's web
3. Run script as below on host to do sha continuously #!/bin/bash
while [ [1] ];
doQuoted 8 lines
find /media -type f -printf '"%h/%f"\n' | xargs sha256sumdone
4. Open KVM on OpenBMC's webThe size of macro block captured is 8x8. Therefore, we should make sure the height of src-buf is 8 aligned to fix this issue.
Signed-off-by Jammy Huang <[email protected]>Your email address you sent this from differs from your SoB. Can you post again from the correct email address? Checkpatch complains about this.
Regards,
Hans
Quoted 31 lines
---
v2 changes
- Add how to reproduce this issue.--- drivers/media/platform/aspeed/aspeed-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/aspeed/aspeed-video.c +2
-2@@ -1130,7 +1130,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)static void aspeed_video_set_resolution (struct aspeed_video *video) {struct v4l2_bt_timings *act = &video->active_timings; -unsigned int size = act->width * act->height; +unsigned int size = act->width *ALIGN (act->height,8 );/* Set capture/compression frame sizes */ aspeed_video_calc_compressed_size (video, size);@@ -1147,7 +1147,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video)u32 width =ALIGN (act->width,64 );aspeed_video_write (video,VE_CAP_WINDOW , width <<16 | act->height); - size = width * act->height; + size = width *ALIGN (act->height,8 ); }else {aspeed_video_write (video,VE_CAP_WINDOW , act->width <<16 | act->height);base-commit:
2605e80d3438c77190f55b821c6575048c68268e
Signature · 2 lines
Best Regards Jammy
PATCH RESEND v2 1/1 media: aspeed: Fix memory overwrite if timing is 1600x900
When capturing 1600x900, system could crash when system memory usage is tight.
The way to reproduce this issue:
1. Use 1600x900 to display on host
2. Mount ISO through 'Virtual media' on OpenBMC's web
3. Run script as below on host to do sha continuously #!/bin/bash
while [ [1] ];
do
find /media -type f -printf '"%h/%f"\n' | xargs sha256sum
done
4. Open KVM on OpenBMC's web
The size of macro block captured is 8x8. Therefore, we should make sure the height of src-buf is 8 aligned to fix this issue.
---
v2 changes
- Add how to reproduce this issue.
--- drivers/media/platform/aspeed/aspeed-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/aspeed/aspeed-video.c +2 -2
@@ -1130,7 +1130,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)static void aspeed_video_set_resolution (struct aspeed_video *video) {struct v4l2_bt_timings *act = &video->active_timings; -unsigned int size = act->width * act->height; +unsigned int size = act->width *ALIGN (act->height,8 );/* Set capture/compression frame sizes */ aspeed_video_calc_compressed_size (video, size);
@@ -1147,7 +1147,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video)u32 width =ALIGN (act->width,64 );aspeed_video_write (video,VE_CAP_WINDOW , width <<16 | act->height); - size = width * act->height; + size = width *ALIGN (act->height,8 ); }else {aspeed_video_write (video,VE_CAP_WINDOW , act->width <<16 | act->height);
base-commit: 2605e80d3438c77190f55b821c6575048c68268e
Signature · 1 line
2.25.1