Update AUX invalidation sequence
Subsystems (2)
v3 cover Update AUX invalidation sequence
Hi,
as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence.
In this version we support all the engines affected by this change.
The stable backport has some challenges because the original patch that this series fixes has had more changes in between.
Thanks a lot Nirmoy for your review and for the fruitful discussions!
Thanks,
Andi
Changelog:
=========
v2 -> v3
- added r-b from Nirmoy in patch 1 and 4.
- added patch 3 which enables the ccs_flush in the control pipe for mtl+ compute and render engines.
- added redundant checks in patch 2 for enabling the EMIT_FLUSH flag.
v1 -> v2
- add a clean up preliminary patch for the existing registers
- add support for more engines
- add the Fixes tag
Andi Shyti (3):
drm/i915/gt: Cleanup aux invalidation registers drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control drm/i915/gt: Support aux invalidation on all engines
Jonathan Cavitt (2):
drm/i915/gt: Ensure memory quiesced before invalidation drm/i915/gt: Poll aux invalidation register bit on invalidation
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 95 ++++++++++++++------ drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 3 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 1 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 2 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 14 ++- drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +--- 6 files changed, 82 insertions(+), 50 deletions(-)
Signature · 1 line
2.40.1
PATCH v3 1/5 drm/i915/gt: Cleanup aux invalidation registers
Fix the 'NV' definition postfix that is supposed to be INV.
Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers.
Remove also VD1, VD3 and VE1 registers that don't exist.
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 14 ++++++-------- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +++--- 3 files changed, 13 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -4
@@ -287,8 +287,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)if (!HAS_FLAT_CCS (rq->engine->i915)) {/* hsdes: 1809175790 */ - cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_GFX_CCS_AUX_NV ); + cs =gen12_emit_aux_table_inv (rq->engine->gt, cs, +GEN12_CCS_AUX_INV ); } *cs++ =preparser_disable (false);
@@ -348,10 +348,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)if (aux_inv) {/* hsdes: 1809175790 */ if (rq->engine->class ==VIDEO_DECODE_CLASS ) cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VD0_AUX_NV ); + cs,GEN12_VD0_AUX_INV );else cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VE0_AUX_NV ); + cs,GEN12_VE0_AUX_INV ); }if (mode &EMIT_INVALIDATE )
drivers/gpu/drm/i915/gt/intel_gt_regs.h +6 -8
@@ -332,9 +332,10 @@#define GEN8_PRIVATE_PAT_HI _MMIO(0x40e0 + 4)#define GEN10_PAT_INDEX (index) _MMIO(0x40e0 + (index) * 4)#define BSD_HWS_PGA_GEN7 _MMIO(0x4180) -#define GEN12_GFX_CCS_AUX_NV _MMIO(0x4208) -#define GEN12_VD0_AUX_NV _MMIO(0x4218) -#define GEN12_VD1_AUX_NV _MMIO(0x4228) + +#define GEN12_CCS_AUX_INV _MMIO(0x4208) +#define GEN12_VD0_AUX_INV _MMIO(0x4218) +#define GEN12_VE0_AUX_INV _MMIO(0x4238)#define GEN8_RTCR _MMIO(0x4260)#define GEN8_M1TCR _MMIO(0x4264)
@@ -342,14 +343,11 @@#define GEN8_BTCR _MMIO(0x426c)#define GEN8_VTCR _MMIO(0x4270) -#define GEN12_VD2_AUX_NV _MMIO(0x4298) -#define GEN12_VD3_AUX_NV _MMIO(0x42a8) -#define GEN12_VE0_AUX_NV _MMIO(0x4238) -#define BLT_HWS_PGA_GEN7 _MMIO(0x4280) -#define GEN12_VE1_AUX_NV _MMIO(0x42b8) +#define GEN12_VD2_AUX_INV _MMIO(0x4298)#define AUX_INV REG_BIT(0) +#define VEBOX_HWS_PGA_GEN7 _MMIO(0x4380)#define GEN12_AUX_ERR_DBG _MMIO(0x43f4)
drivers/gpu/drm/i915/gt/intel_lrc.c +3 -3
@@ -1374,7 +1374,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)/* hsdes: 1809175790 */ if (!HAS_FLAT_CCS (ce->engine->i915)) cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_GFX_CCS_AUX_NV ); + cs,GEN12_CCS_AUX_INV );/* Wa_16014892111 */ if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||
@@ -1403,10 +1403,10 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)if (!HAS_FLAT_CCS (ce->engine->i915)) {if (ce->engine->class ==VIDEO_DECODE_CLASS ) cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VD0_AUX_NV ); + cs,GEN12_VD0_AUX_INV );else if (ce->engine->class ==VIDEO_ENHANCEMENT_CLASS ) cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VE0_AUX_NV ); + cs,GEN12_VE0_AUX_INV ); }return cs;
Signature · 1 line
2.40.1
Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/gt: Cleanup aux invalidation registers
Quoted 11 lines · Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV.
Take the chance to also order properly the registers based on their address and call the
GEN12_GFX_CCS_AUX_INVaddress asGEN12_CCS_AUX_INVlike all the other similar registers.Remove also VD1, VD3 and VE1 registers that don't exist.
Signed-off-by Andi Shyti <[email protected]>Cc <[email protected]> # v5.8+Reviewed-by Nirmoy Das <[email protected]>
Regards
Andrzej
Quoted 95 lines
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 14 ++++++-------- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +++--- 3 files changed, 13 insertions(+), 15 deletions(-)drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4
-4@@ -287,8 +287,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)if (!HAS_FLAT_CCS (rq->engine->i915)) {/* hsdes: 1809175790 */ - cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_GFX_CCS_AUX_NV ); + cs =gen12_emit_aux_table_inv (rq->engine->gt, cs, +GEN12_CCS_AUX_INV ); } *cs++ =preparser_disable (false);@@ -348,10 +348,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)if (aux_inv) {/* hsdes: 1809175790 */ if (rq->engine->class ==VIDEO_DECODE_CLASS ) cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VD0_AUX_NV ); + cs,GEN12_VD0_AUX_INV );else cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VE0_AUX_NV ); + cs,GEN12_VE0_AUX_INV ); }if (mode &EMIT_INVALIDATE )drivers/gpu/drm/i915/gt/intel_gt_regs.h +6
-8@@ -332,9 +332,10 @@#define GEN8_PRIVATE_PAT_HI _MMIO(0x40e0 + 4)#define GEN10_PAT_INDEX (index) _MMIO(0x40e0 + (index) * 4)#define BSD_HWS_PGA_GEN7 _MMIO(0x4180) -#define GEN12_GFX_CCS_AUX_NV _MMIO(0x4208) -#define GEN12_VD0_AUX_NV _MMIO(0x4218) -#define GEN12_VD1_AUX_NV _MMIO(0x4228) + +#define GEN12_CCS_AUX_INV _MMIO(0x4208) +#define GEN12_VD0_AUX_INV _MMIO(0x4218) +#define GEN12_VE0_AUX_INV _MMIO(0x4238)#define GEN8_RTCR _MMIO(0x4260)#define GEN8_M1TCR _MMIO(0x4264)@@ -342,14 +343,11 @@#define GEN8_BTCR _MMIO(0x426c)#define GEN8_VTCR _MMIO(0x4270) -#define GEN12_VD2_AUX_NV _MMIO(0x4298) -#define GEN12_VD3_AUX_NV _MMIO(0x42a8) -#define GEN12_VE0_AUX_NV _MMIO(0x4238) -#define BLT_HWS_PGA_GEN7 _MMIO(0x4280) -#define GEN12_VE1_AUX_NV _MMIO(0x42b8) +#define GEN12_VD2_AUX_INV _MMIO(0x4298)#define AUX_INV REG_BIT(0) +#define VEBOX_HWS_PGA_GEN7 _MMIO(0x4380)#define GEN12_AUX_ERR_DBG _MMIO(0x43f4)drivers/gpu/drm/i915/gt/intel_lrc.c +3
-3@@ -1374,7 +1374,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)/* hsdes: 1809175790 */ if (!HAS_FLAT_CCS (ce->engine->i915)) cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_GFX_CCS_AUX_NV ); + cs,GEN12_CCS_AUX_INV );/* Wa_16014892111 */ if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||@@ -1403,10 +1403,10 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)if (!HAS_FLAT_CCS (ce->engine->i915)) {if (ce->engine->class ==VIDEO_DECODE_CLASS ) cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VD0_AUX_NV ); + cs,GEN12_VD0_AUX_INV );else if (ce->engine->class ==VIDEO_ENHANCEMENT_CLASS ) cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VE0_AUX_NV ); + cs,GEN12_VE0_AUX_INV ); }return cs;
PATCH v3 2/5 drm/i915/gt: Ensure memory quiesced before invalidation
In reply to Andi ShytiFrom: Jonathan Cavitt <[email protected]>
All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +7 -0
@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) {struct intel_engine_cs *engine = rq->engine; +/* +* Aux invalidations on Aux CCS platforms require +* memory traffic is quiesced prior. +*/ +if ((mode &EMIT_INVALIDATE ) && !HAS_FLAT_CCS (engine->i915)) + mode |=EMIT_FLUSH ; +if (mode &EMIT_FLUSH ) {u32 flags =0 ;int err;
Signature · 1 line
2.40.1
Re: [PATCH v3 2/5] drm/i915/gt: Ensure memory quiesced before invalidation
Quoted 9 lines · Andi Shyti
From: Jonathan Cavitt<[email protected]>
All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.
Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")Signed-off-by Jonathan Cavitt<[email protected]>Signed-off-by Andi Shyti<[email protected]>Cc <[email protected]> # v5.8+
|Reviewed-by: Nirmoy Das <[email protected]>|
Quoted 22 lines
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/gpu/drm/i915/gt/gen8_engine_cs.c +7
-0@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) {struct intel_engine_cs *engine = rq->engine; +/* +* Aux invalidations on Aux CCS platforms require +* memory traffic is quiesced prior. +*/ +if ((mode &EMIT_INVALIDATE ) && !HAS_FLAT_CCS (engine->i915)) + mode |=EMIT_FLUSH ; +if (mode &EMIT_FLUSH ) {u32 flags =0 ;int err;
Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/gt: Ensure memory quiesced before invalidation
In reply to Andi ShytiQuoted 9 lines · Andi Shyti
From: Jonathan Cavitt <[email protected]>
All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.
Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")Signed-off-by Jonathan Cavitt <[email protected]>Signed-off-by Andi Shyti <[email protected]>Cc <[email protected]> # v5.8+
Regards
Andrzej
Quoted 22 lines
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/gpu/drm/i915/gt/gen8_engine_cs.c +7
-0@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) {struct intel_engine_cs *engine = rq->engine; +/* +* Aux invalidations on Aux CCS platforms require +* memory traffic is quiesced prior. +*/ +if ((mode &EMIT_INVALIDATE ) && !HAS_FLAT_CCS (engine->i915)) + mode |=EMIT_FLUSH ; +if (mode &EMIT_FLUSH ) {u32 flags =0 ;int err;
PATCH v3 3/5 drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control
In reply to Andi ShytiEnable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112).
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 12 +++++++++++- drivers/gpu/drm/i915/gt/intel_engine_types.h | 1 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 1 + 3 files changed, 13 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +11 -1
@@ -207,7 +207,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)* memory traffic is quiesced prior. */ if ((mode &EMIT_INVALIDATE ) && !HAS_FLAT_CCS (engine->i915)) - mode |=EMIT_FLUSH ; + mode |=EMIT_FLUSH |EMIT_CCS_FLUSH ;if (mode &EMIT_FLUSH ) {u32 flags =0 ;
@@ -232,6 +232,16 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) flags |=PIPE_CONTROL_CS_STALL ; +/* +* When required, in MTL+ platforms, in the render and compute +* engines we need to set the CCS_FLUSH bit in the pipe control +*/ +if (mode &EMIT_CCS_FLUSH && +GRAPHICS_VER_FULL (rq->i915) >=IP_VER (12 ,70 ) && + (engine->class ==RENDER_CLASS || + engine->class ==COMPUTE_CLASS )) + flags |=PIPE_CONTROL_CCS_FLUSH ; +if (!HAS_3D_PIPELINE (engine->i915)) flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS ;else if (engine->class ==COMPUTE_CLASS )
drivers/gpu/drm/i915/gt/intel_engine_types.h +1 -0
@@ -514,6 +514,7 @@ struct intel_engine_cs {int (*emit_flush)(struct i915_request *request,u32 mode);#define EMIT_INVALIDATE BIT(0)#define EMIT_FLUSH BIT(1) +#define EMIT_CCS_FLUSH BIT(2)/* MTL+ */ #define EMIT_BARRIER (EMIT_INVALIDATE | EMIT_FLUSH) int (*emit_bb_start)(struct i915_request *rq, u64 offset, u32 length,
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
@@ -299,6 +299,7 @@#define PIPE_CONTROL_QW_WRITE (1<<14)#define PIPE_CONTROL_POST_SYNC_OP_MASK (3<<14)#define PIPE_CONTROL_DEPTH_STALL (1<<13) +#define PIPE_CONTROL_CCS_FLUSH (1<<13)/* MTL+ */ #define PIPE_CONTROL_WRITE_FLUSH (1<<12)#define PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH (1<<12)/* gen6+ */ #define PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE (1<<11)/* MBZ on ILK */
Signature · 1 line
2.40.1
Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control
Quoted 30 lines · Andi Shyti
Enable the
CCS_FLUSHbit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112).Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")Signed-off-by Andi Shyti <[email protected]>Cc Jonathan Cavitt <[email protected]>Cc Nirmoy Das <[email protected]>Cc <[email protected]> # v5.8+--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 12 +++++++++++- drivers/gpu/drm/i915/gt/intel_engine_types.h | 1 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 1 + 3 files changed, 13 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1
-1@@ -207,7 +207,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)* memory traffic is quiesced prior. */ if ((mode &EMIT_INVALIDATE ) && !HAS_FLAT_CCS (engine->i915)) - mode |=EMIT_FLUSH ; + mode |=EMIT_FLUSH |EMIT_CCS_FLUSH ;if (mode &EMIT_FLUSH ) {u32 flags =0 ;@@ -232,6 +232,16 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 242
Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +8
-0flags |=PIPE_CONTROL_CS_STALL ; +/* +* When required, in MTL+ platforms, in the render and compute +* engines we need to set the CCS_FLUSH bit in the pipe control +*/ +if (mode &EMIT_CCS_FLUSH && +GRAPHICS_VER_FULL (rq->i915) >=IP_VER (12 ,70 ) && + (engine->class ==RENDER_CLASS || + engine->class ==COMPUTE_CLASS ))
PIPE_CONTROL is only available for render and compute so we can skip this engine check.
drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 243
Quoted 1 line
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1
-0+ flags |=PIPE_CONTROL_CCS_FLUSH ;
This "flags" is applied to DWORD 1 of PIPE_CONTROL but we need this for DWORD 0
Regards,
Nirmoy
Quoted 28 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1
-0+if (!HAS_3D_PIPELINE (engine->i915)) flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS ;else if (engine->class ==COMPUTE_CLASS )drivers/gpu/drm/i915/gt/intel_engine_types.h +1
-0@@ -514,6 +514,7 @@ struct intel_engine_cs {int (*emit_flush)(struct i915_request *request,u32 mode);#define EMIT_INVALIDATE BIT(0)#define EMIT_FLUSH BIT(1) +#define EMIT_CCS_FLUSH BIT(2)/* MTL+ */ #define EMIT_BARRIER (EMIT_INVALIDATE | EMIT_FLUSH) int (*emit_bb_start)(struct i915_request *rq, u64 offset, u32 length,drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1
-0@@ -299,6 +299,7 @@#define PIPE_CONTROL_QW_WRITE (1<<14)#define PIPE_CONTROL_POST_SYNC_OP_MASK (3<<14)#define PIPE_CONTROL_DEPTH_STALL (1<<13) +#define PIPE_CONTROL_CCS_FLUSH (1<<13)/* MTL+ */ #define PIPE_CONTROL_WRITE_FLUSH (1<<12)#define PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH (1<<12)/* gen6+ */ #define PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE (1<<11)/* MBZ on ILK */
PATCH v3 4/5 drm/i915/gt: Poll aux invalidation register bit on invalidation
In reply to Andi ShytiFrom: Jonathan Cavitt <[email protected]>
For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared.
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 17 +++++++++++++---- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 1 + 2 files changed, 14 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +13 -4
@@ -174,6 +174,16 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv *cs++ =AUX_INV ; *cs++ =MI_NOOP ; + *cs++ =MI_SEMAPHORE_WAIT_TOKEN | +MI_SEMAPHORE_REGISTER_POLL | +MI_SEMAPHORE_POLL | +MI_SEMAPHORE_SAD_EQ_SDD ; + *cs++ =0 ; + *cs++ =i915_mmio_reg_offset (inv_reg) + gsi_offset; + *cs++ =0 ; + *cs++ =0 ; + *cs++ =MI_NOOP ; +return cs; }
@@ -284,10 +294,9 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)else if (engine->class ==COMPUTE_CLASS ) flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS ; + count =8 ;if (!HAS_FLAT_CCS (rq->engine->i915)) - count =8 +4 ; -else - count =8 ; + count +=10 ; cs =intel_ring_begin (rq, count);if (IS_ERR (cs))
@@ -330,7 +339,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) aux_inv = rq->engine->mask & ~GENMASK (_BCS (I915_MAX_BCS -1 ),BCS0 );if (aux_inv) - cmd +=4 ; + cmd +=10 ; } }
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
@@ -121,6 +121,7 @@#define MI_SEMAPHORE_TARGET (engine) ((engine)<<15)#define MI_SEMAPHORE_WAIT MI_INSTR(0x1c, 2)/* GEN8+ */ #define MI_SEMAPHORE_WAIT_TOKEN MI_INSTR(0x1c, 3)/* GEN12+ */ +#define MI_SEMAPHORE_REGISTER_POLL (1 << 16)#define MI_SEMAPHORE_POLL (1 << 15)#define MI_SEMAPHORE_SAD_GT_SDD (0 << 12)#define MI_SEMAPHORE_SAD_GTE_SDD (1 << 12)
Signature · 1 line
2.40.1
PATCH v3 5/5 drm/i915/gt: Support aux invalidation on all engines
In reply to Andi ShytiPerform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.
With this refactoring add more engines where the invalidation should be performed.
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++--------- drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 3 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +------ 3 files changed, 44 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +40 -23
@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)return MI_ARB_CHECK |1 <<8 | state; } -u32 *gen12_emit_aux_table_inv (struct intel_gt *gt,u32 *cs,const i915_reg_t inv_reg) +static u32 *gen12_emit_aux_table_inv (struct intel_gt *gt,u32 *cs, +const i915_reg_t inv_reg) {u32 gsi_offset = gt->uncore->gsi_offset;
@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t invreturn cs; } +static i915_reg_t intel_get_aux_inv_reg (struct intel_engine_cs *engine) +{ +if (HAS_FLAT_CCS (engine->i915)) +return _MMIO (0 ); + +switch (engine->id) { +case RCS0 : +return GEN12_CCS_AUX_INV ; +case VCS0 : +return GEN12_VD0_AUX_INV ; +case VCS2 : +return GEN12_VD2_AUX_INV ; +case VECS0 : +return GEN12_VE0_AUX_INV ; +default : +return _MMIO (0 ); + } +} + +static bool intel_engine_has_aux_inv (struct intel_engine_cs *engine) +{ +i915_reg_t reg =intel_get_aux_inv_reg (engine); + +return !!reg.reg; +} + +u32 *intel_emit_aux_table_inv (struct intel_engine_cs *engine,u32 *cs) +{ +i915_reg_t reg =intel_get_aux_inv_reg (engine); +struct intel_gt *gt = engine->gt; + +return reg.reg ?gen12_emit_aux_table_inv (gt, cs, reg) : cs; +} +static int mtl_dummy_pipe_control (struct i915_request *rq) {/* Wa_14016712196 */
@@ -311,11 +346,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) cs =gen8_emit_pipe_control (cs, flags,LRC_PPHWSP_SCRATCH_ADDR ); -if (!HAS_FLAT_CCS (rq->engine->i915)) { -/* hsdes: 1809175790 */ - cs =gen12_emit_aux_table_inv (rq->engine->gt, cs, -GEN12_CCS_AUX_INV ); - } + cs =intel_emit_aux_table_inv (engine, cs); *cs++ =preparser_disable (false);intel_ring_advance (rq, cs);
@@ -326,21 +357,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)int gen12_emit_flush_xcs (struct i915_request *rq,u32 mode) { -intel_engine_mask_t aux_inv =0 ;u32 cmd, *cs; cmd =4 ;if (mode &EMIT_INVALIDATE ) { cmd +=2 ; -if (!HAS_FLAT_CCS (rq->engine->i915) && - (rq->engine->class ==VIDEO_DECODE_CLASS || - rq->engine->class ==VIDEO_ENHANCEMENT_CLASS )) { - aux_inv = rq->engine->mask & - ~GENMASK (_BCS (I915_MAX_BCS -1 ),BCS0 ); -if (aux_inv) - cmd +=10 ; - } +if (intel_engine_has_aux_inv (rq->engine)) + cmd +=10 ; } cs =intel_ring_begin (rq, cmd);
@@ -371,14 +395,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) *cs++ =0 ;/* upper addr */ *cs++ =0 ;/* value */ -if (aux_inv) {/* hsdes: 1809175790 */ -if (rq->engine->class ==VIDEO_DECODE_CLASS ) - cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VD0_AUX_INV ); -else - cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VE0_AUX_INV ); - } + cs =intel_emit_aux_table_inv (rq->engine, cs);if (mode &EMIT_INVALIDATE ) *cs++ =preparser_disable (false);
drivers/gpu/drm/i915/gt/gen8_engine_cs.h +2 -1
@@ -13,6 +13,7 @@#include "intel_gt_regs.h" #include "intel_gpu_commands.h" +struct intel_engine_cs ;struct intel_gt ;struct i915_request ;
@@ -46,7 +47,7 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);u32 *gen11_emit_fini_breadcrumb_rcs (struct i915_request *rq,u32 *cs);u32 *gen12_emit_fini_breadcrumb_rcs (struct i915_request *rq,u32 *cs); -u32 *gen12_emit_aux_table_inv (struct intel_gt *gt,u32 *cs,const i915_reg_t inv_reg); +u32 *intel_emit_aux_table_inv (struct intel_engine_cs *engine,u32 *cs);static inline u32 *__gen8_emit_pipe_control (u32 *batch,u32 flags0,u32 flags1,u32 offset)
drivers/gpu/drm/i915/gt/intel_lrc.c +2 -15
@@ -1371,10 +1371,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs) IS_DG2_G11(ce->engine->i915)) cs =gen8_emit_pipe_control (cs,PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE ,0 ); -/* hsdes: 1809175790 */ -if (!HAS_FLAT_CCS (ce->engine->i915)) - cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_CCS_AUX_INV ); + cs =intel_emit_aux_table_inv (ce->engine, cs);/* Wa_16014892111 */ if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||
@@ -1399,17 +1396,7 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE , 0); -/* hsdes: 1809175790 */ -if (!HAS_FLAT_CCS (ce->engine->i915)) { -if (ce->engine->class ==VIDEO_DECODE_CLASS ) - cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VD0_AUX_INV ); -else if (ce->engine->class ==VIDEO_ENHANCEMENT_CLASS ) - cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VE0_AUX_INV ); - } - -return cs; +return intel_emit_aux_table_inv (ce->engine, cs); } static void
Signature · 1 line
2.40.1
Re: [PATCH v3 5/5] drm/i915/gt: Support aux invalidation on all engines
Quoted 10 lines · Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.
With this refactoring add more engines where the invalidation should be performed.
Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")Signed-off-by Andi Shyti<[email protected]>Cc <[email protected]> # v5.8+
|Reviewed-by: Nirmoy Das <[email protected]>|
Quoted 170 lines
--- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++--------- drivers/gpu/drm/i915/gt/gen8_engine_cs.h | 3 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +------ 3 files changed, 44 insertions(+), 39 deletions(-)drivers/gpu/drm/i915/gt/gen8_engine_cs.c +40
-23@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)return MI_ARB_CHECK |1 <<8 | state; } -u32 *gen12_emit_aux_table_inv (struct intel_gt *gt,u32 *cs,const i915_reg_t inv_reg) +static u32 *gen12_emit_aux_table_inv (struct intel_gt *gt,u32 *cs, +const i915_reg_t inv_reg) {u32 gsi_offset = gt->uncore->gsi_offset;@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t invreturn cs; } +static i915_reg_t intel_get_aux_inv_reg (struct intel_engine_cs *engine) +{ +if (HAS_FLAT_CCS (engine->i915)) +return _MMIO (0 ); + +switch (engine->id) { +case RCS0 : +return GEN12_CCS_AUX_INV ; +case VCS0 : +return GEN12_VD0_AUX_INV ; +case VCS2 : +return GEN12_VD2_AUX_INV ; +case VECS0 : +return GEN12_VE0_AUX_INV ; +default : +return _MMIO (0 ); + } +} + +static bool intel_engine_has_aux_inv (struct intel_engine_cs *engine) +{ +i915_reg_t reg =intel_get_aux_inv_reg (engine); + +return !!reg.reg; +} + +u32 *intel_emit_aux_table_inv (struct intel_engine_cs *engine,u32 *cs) +{ +i915_reg_t reg =intel_get_aux_inv_reg (engine); +struct intel_gt *gt = engine->gt; + +return reg.reg ?gen12_emit_aux_table_inv (gt, cs, reg) : cs; +} +static int mtl_dummy_pipe_control (struct i915_request *rq) {/* Wa_14016712196 */ @@ -311,11 +346,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) cs =gen8_emit_pipe_control (cs, flags,LRC_PPHWSP_SCRATCH_ADDR ); -if (!HAS_FLAT_CCS (rq->engine->i915)) { -/* hsdes: 1809175790 */ - cs =gen12_emit_aux_table_inv (rq->engine->gt, cs, -GEN12_CCS_AUX_INV ); - } + cs =intel_emit_aux_table_inv (engine, cs); *cs++ =preparser_disable (false);intel_ring_advance (rq, cs);@@ -326,21 +357,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)int gen12_emit_flush_xcs (struct i915_request *rq,u32 mode) { -intel_engine_mask_t aux_inv =0 ;u32 cmd, *cs; cmd =4 ;if (mode &EMIT_INVALIDATE ) { cmd +=2 ; -if (!HAS_FLAT_CCS (rq->engine->i915) && - (rq->engine->class ==VIDEO_DECODE_CLASS || - rq->engine->class ==VIDEO_ENHANCEMENT_CLASS )) { - aux_inv = rq->engine->mask & - ~GENMASK (_BCS (I915_MAX_BCS -1 ),BCS0 ); -if (aux_inv) - cmd +=10 ; - } +if (intel_engine_has_aux_inv (rq->engine)) + cmd +=10 ; } cs =intel_ring_begin (rq, cmd);@@ -371,14 +395,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) *cs++ =0 ;/* upper addr */ *cs++ =0 ;/* value */ -if (aux_inv) {/* hsdes: 1809175790 */ -if (rq->engine->class ==VIDEO_DECODE_CLASS ) - cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VD0_AUX_INV ); -else - cs =gen12_emit_aux_table_inv (rq->engine->gt, - cs,GEN12_VE0_AUX_INV ); - } + cs =intel_emit_aux_table_inv (rq->engine, cs);if (mode &EMIT_INVALIDATE ) *cs++ =preparser_disable (false);drivers/gpu/drm/i915/gt/gen8_engine_cs.h +2
-1@@ -13,6 +13,7 @@#include "intel_gt_regs.h" #include "intel_gpu_commands.h" +struct intel_engine_cs ;struct intel_gt ;struct i915_request ;@@ -46,7 +47,7 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);u32 *gen11_emit_fini_breadcrumb_rcs (struct i915_request *rq,u32 *cs);u32 *gen12_emit_fini_breadcrumb_rcs (struct i915_request *rq,u32 *cs); -u32 *gen12_emit_aux_table_inv (struct intel_gt *gt,u32 *cs,const i915_reg_t inv_reg); +u32 *intel_emit_aux_table_inv (struct intel_engine_cs *engine,u32 *cs);static inline u32 *__gen8_emit_pipe_control (u32 *batch,u32 flags0,u32 flags1,u32 offset)drivers/gpu/drm/i915/gt/intel_lrc.c +2
-15@@ -1371,10 +1371,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs) IS_DG2_G11(ce->engine->i915)) cs =gen8_emit_pipe_control (cs,PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE ,0 ); -/* hsdes: 1809175790 */ -if (!HAS_FLAT_CCS (ce->engine->i915)) - cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_CCS_AUX_INV ); + cs =intel_emit_aux_table_inv (ce->engine, cs);/* Wa_16014892111 */ if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||@@ -1399,17 +1396,7 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE , 0); -/* hsdes: 1809175790 */ -if (!HAS_FLAT_CCS (ce->engine->i915)) { -if (ce->engine->class ==VIDEO_DECODE_CLASS ) - cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VD0_AUX_INV ); -else if (ce->engine->class ==VIDEO_ENHANCEMENT_CLASS ) - cs =gen12_emit_aux_table_inv (ce->engine->gt, - cs,GEN12_VE0_AUX_INV ); - } - -return cs; +return intel_emit_aux_table_inv (ce->engine, cs); } static void
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Update AUX invalidation sequence (rev3)
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: Update AUX invalidation sequence (rev3)
URL : https://patchwork.freedesktop.org/series/119798/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13390 -> Patchwork_119798v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/index.html
Participating hosts (41 -> 42)
------------------------------
Additional (2): bat-atsm-1 fi-pnv-d510
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_119798v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- bat-adlp-11: NOTRUN -> [ABORT][1] ([i915#8011])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-adlp-11/igt@[email protected]
* igt@dmabuf@all-tests@dma_fence:
- fi-cfl-guc: [PASS][2] -> [DMESG-FAIL][3] ([i915#8141] / [i915#8145])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/fi-cfl-guc/igt@dmabuf@all-tests@dma_fence.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-cfl-guc/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@sanitycheck:
- fi-cfl-guc: [PASS][4] -> [ABORT][5] ([i915#8058] / [i915#8141] / [i915#8144])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/fi-cfl-guc/igt@dmabuf@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-cfl-guc/igt@dmabuf@[email protected]
* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-atsm-1: NOTRUN -> [DMESG-WARN][6] ([i915#8841]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@lmem0:
- bat-atsm-1: NOTRUN -> [DMESG-WARN][7] ([i915#8504] / [i915#8841])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@gem_exec_suspend@[email protected]
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@gem_render_tiled_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][9] ([i915#4079]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][10] ([i915#4077]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@i915_module_load@load:
- bat-mtlp-6: [PASS][11] -> [ABORT][12] ([i915#8141])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-mtlp-6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-mtlp-6/igt@[email protected]
- bat-mtlp-8: [PASS][13] -> [ABORT][14] ([i915#8141])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-mtlp-8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-mtlp-8/igt@[email protected]
* igt@i915_pm_rpm@basic-rte:
- fi-skl-guc: [PASS][15] -> [FAIL][16] ([i915#7940])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/fi-skl-guc/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-skl-guc/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][17] ([i915#6621])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@i915_selftest@live@reset:
- bat-rpls-2: [PASS][18] -> [ABORT][19] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#7981] / [i915#8347])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-rpls-2/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- fi-pnv-d510: NOTRUN -> [ABORT][20] ([i915#8844])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-pnv-d510/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][21] ([i915#6645])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][22] ([i915#6077]) +36 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-jsl-1: NOTRUN -> [SKIP][23] ([i915#7828])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-jsl-1/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][24] ([i915#6078]) +19 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-atsm-1: NOTRUN -> [SKIP][25] ([i915#6166]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-atsm-1: NOTRUN -> [SKIP][26] ([i915#6093]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][27] ([i915#1845] / [i915#5354]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-dg2-11/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-atsm-1: NOTRUN -> [SKIP][28] ([i915#1836]) +6 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][29] ([i915#7357])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: NOTRUN -> [SKIP][30] ([i915#1072])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][31] ([fdo#109271]) +37 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-atsm-1: NOTRUN -> [SKIP][32] ([i915#1072]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: NOTRUN -> [ABORT][33] ([i915#8260] / [i915#8668])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-rplp-1/igt@[email protected]
- bat-atsm-1: NOTRUN -> [SKIP][34] ([i915#6094])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][35] ([fdo#109295] / [i915#6078])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-atsm-1: NOTRUN -> [SKIP][36] ([fdo#109295] / [i915#4077]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][37] ([fdo#109295]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-atsm-1/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-skl-guc: [FAIL][38] ([i915#7940]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/fi-skl-guc/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-skl-guc/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [FAIL][40] ([i915#7940]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/fi-rkl-11600/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-rkl-11600/igt@[email protected]
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][42] ([i915#7699]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-dg2-11/igt@i915_selftest@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-dg2-11/igt@i915_selftest@[email protected]
- bat-jsl-1: [INCOMPLETE][44] ([i915#8504]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-jsl-1/igt@i915_selftest@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-jsl-1/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_module_load@load:
- bat-adlp-11: [ABORT][46] ([i915#4423]) -> [DMESG-WARN][47] ([i915#4423])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-adlp-11/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-adlp-11/igt@[email protected]
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][48] ([i915#8843]) -> [FAIL][49] ([i915#7940])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/fi-kbl-guc/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/fi-kbl-guc/igt@[email protected]
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: [ABORT][50] ([i915#8442] / [i915#8712]) -> [SKIP][51] ([i915#1072])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13390/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#486]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/486
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8058]: https://gitlab.freedesktop.org/drm/intel/issues/8058
[i915#8141]: https://gitlab.freedesktop.org/drm/intel/issues/8141
[i915#8144]: https://gitlab.freedesktop.org/drm/intel/issues/8144
[i915#8145]: https://gitlab.freedesktop.org/drm/intel/issues/8145
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8504]: https://gitlab.freedesktop.org/drm/intel/issues/8504
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8712]: https://gitlab.freedesktop.org/drm/intel/issues/8712
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843
[i915#8844]: https://gitlab.freedesktop.org/drm/intel/issues/8844
[i915#8879]: https://gitlab.freedesktop.org/drm/intel/issues/8879
Build changes
-------------
* Linux: CI_DRM_13390 -> Patchwork_119798v3
CI-20190529: 20190529
CI_DRM_13390: 3d28151face410f5cafffdb42710041f889dc733 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_119798v3: 3d28151face410f5cafffdb42710041f889dc733 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5a9b91e09c73 drm/i915/gt: Support aux invalidation on all engines 28c98e4dc8b7 drm/i915/gt: Poll aux invalidation register bit on invalidation abc04053d467 drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control dffa8c5697a4 drm/i915/gt: Ensure memory quiesced before invalidation 373db63d9fd0 drm/i915/gt: Cleanup aux invalidation registers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v3/index.html