Skip to contentSkip to conversation

arm64: tegra: Add 35°C trip point for Jetson Orin NX/Nano

PATCH In review Thierry Reding 1 participant 2 messages Jul 17, 2023 – Jul 21, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: tegra: Add 35°C trip point for Jetson Orin NX/Nano

From: Thierry Reding <[email protected]>

It turns out that these devices can get quite hot to the touch with the standard cooling configuration, so add another trip point at 35°C along with a cooling map to help keep the system reasonably cool at very low system load.

---
 arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi            | 8 +++++++-
 .../boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts    | 7 ++++++-
 .../boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dts    | 7 ++++++-
 3 files changed, 19 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi +7 -1
index a8aa6e7d8fbc..5f592f1d81e2 100644
@@ -106,12 +106,18 @@ tj-thermal {
 
 			trips {
 				tj_trip_active0: active-0 {
-					temperature = <74000>;
+					temperature = <35000>;
 					hysteresis = <4000>;
 					type = "active";
 				};
 
 				tj_trip_active1: active-1 {
+					temperature = <74000>;
+					hysteresis = <4000>;
+					type = "active";
+				};
+
+				tj_trip_active2: active-2 {
 					temperature = <95000>;
 					hysteresis = <4000>;
 					type = "active";
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts +6 -1
index 2de2f8ac640d..072e45ce2631 100644
@@ -205,7 +205,7 @@ key-suspend {
 	};
 
 	pwm-fan {
-		cooling-levels = <0 187 255>;
+		cooling-levels = <0 88 187 255>;
 	};
 
 	vdd_3v3_pcie: regulator-vdd-3v3-pcie {
@@ -233,6 +233,11 @@ map-active-1 {
 					cooling-device = <&fan 1 2>;
 					trip = <&tj_trip_active1>;
 				};
+
+				map-active-2 {
+					cooling-device = <&fan 2 3>;
+					trip = <&tj_trip_active2>;
+				};
 			};
 		};
 	};
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dts +6 -1
index 9b86aa6f7dbe..9e9bb9ca8be4 100644
@@ -12,7 +12,7 @@ / {
 	model = "NVIDIA Jetson Orin Nano Developer Kit";
 
 	pwm-fan {
-		cooling-levels = <0 187 255>;
+		cooling-levels = <0 88 187 255>;
 	};
 
 	thermal-zones {
@@ -27,6 +27,11 @@ map-active-1 {
 					cooling-device = <&fan 1 2>;
 					trip = <&tj_trip_active1>;
 				};
+
+				map-active-2 {
+					cooling-device = <&fan 2 3>;
+					trip = <&tj_trip_active2>;
+				};
 			};
 		};
 	};
Signature · 1 line
2.41.0

A message that is not in the archive (sent off-list or not yet received): DM6PR12MB5698F386CB76C29D3EE24D24B438A@DM6PR12MB5698.namprd12.prod.outlook.com

#2 lore raw
Quoted 3 lines · Yi-Wei Wang

Hi Thierry,

The patch looks good to me.

I've turned that into a Reviewed-by. Please see the kernel documentation here (Documentation/process/submitting-patches.rst) for how to use these. In a nutshell: if you respond with a Reviewed-by: line, several of the tools that maintainers use can pick that up automatically during patch application and simplify that task.

Also, don't top-post. The above document also goes into the details about how to properly reply.

Thierry