Skip to contentSkip to conversation

dt-bindings: clock: ast2600: Add I3C and MAC reset definitions

PATCH Applied Dylan Hung 3 participants 3 messages Jul 18, 2023 – Jul 19, 2023

Subsystems (2)
Device tree bindings Common clk
lore
Share & tools
lore

Dylan Hung

author
#0 lore raw

PATCH v3 1/1 dt-bindings: clock: ast2600: Add I3C and MAC reset definitions

Add reset definitions of AST2600 I3C and MAC controllers. In the case of the I3C reset, since there is no reset-line hardware available for ASPEED_RESET_I3C_DMA, a new macro ASPEED_RESET_I3C with the same ID is introduced to provide a more accurate representation of the hardware. The old macro ASPEED_RESET_I3C_DMA is kept to provide backward compatibility.

Signed-off-by Dylan Hung <[email protected]>

---
changes in v2:
- Added back ASPEED_RESET_I3C_DMA for backward compatibility
- link to v1: https://lore.kernel.org/all/[email protected]/

changes in v3:
- Added an explaination for adding a duplicate ID in the commit message
- Link to v2: https://lore.kernel.org/all/[email protected]/

 include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)
include/dt-bindings/clock/ast2600-clock.h +12 -0
index e149eee61588..712782177c90 100644
@@ -90,7 +90,19 @@
 /* Only list resets here that are not part of a clock gate + reset pair */
 #define ASPEED_RESET_ADC		55
 #define ASPEED_RESET_JTAG_MASTER2	54
+
+#define ASPEED_RESET_MAC4		53
+#define ASPEED_RESET_MAC3		52
+
+#define ASPEED_RESET_I3C5		45
+#define ASPEED_RESET_I3C4		44
+#define ASPEED_RESET_I3C3		43
+#define ASPEED_RESET_I3C2		42
+#define ASPEED_RESET_I3C1		41
+#define ASPEED_RESET_I3C0		40
+#define ASPEED_RESET_I3C		39
 #define ASPEED_RESET_I3C_DMA		39
+
 #define ASPEED_RESET_PWM		37
 #define ASPEED_RESET_PECI		36
 #define ASPEED_RESET_MII		35
Signature · 1 line
2.25.1
Acked-by on v3 1/1
#1 lore raw
Quoted 9 lines · Dylan Hung

Add reset definitions of AST2600 I3C and MAC controllers. In the case of the I3C reset, since there is no reset-line hardware available for ASPEED_RESET_I3C_DMA, a new macro ASPEED_RESET_I3C with the same ID is introduced to provide a more accurate representation of the hardware. The old macro ASPEED_RESET_I3C_DMA is kept to provide backward compatibility.

Signed-off-by Dylan Hung <[email protected]>

---

Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Dylan Hung

Quoting Dylan Hung (2023-07-17 23:26:16)

Quoted 9 lines

Add reset definitions of AST2600 I3C and MAC controllers. In the case of the I3C reset, since there is no reset-line hardware available for ASPEED_RESET_I3C_DMA, a new macro ASPEED_RESET_I3C with the same ID is introduced to provide a more accurate representation of the hardware. The old macro ASPEED_RESET_I3C_DMA is kept to provide backward compatibility.

Signed-off-by Dylan Hung <[email protected]>

---

Applied to clk-next