Skip to contentSkip to conversation

drm: adv7511: Fix low refresh rate register for ADV7533/5

PATCH Superseded Bogdan Togorean 5 participants 12 messages Jul 16, 2019 – Jul 21, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: adv7511: Fix low refresh rate register for ADV7533/5

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 9c8af882bf12: ("drm: Add adv7511 encoder driver")
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -2
index f6d2681f6927..4508a304d23f 100644
@@ -756,8 +756,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
 	else
 		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-	regmap_update_bits(adv7511->regmap, 0xfb,
-		0x6, low_refresh_rate << 1);
+	if (adv7511->type == ADV7511)
+		regmap_update_bits(adv7511->regmap, 0xfb,
+			0x6, low_refresh_rate << 1);
+	else
+		regmap_update_bits(adv7511->regmap, 0x4a,
+			0xc, low_refresh_rate << 2);
+
 	regmap_update_bits(adv7511->regmap, 0x17,
 		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
Signature · 1 line
2.22.0
#1 lore raw

PATCH v2 1/1 drm: adv7511: Fix low refresh rate register for ADV7533/5

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -2
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
 	else
 		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-	regmap_update_bits(adv7511->regmap, 0xfb,
-		0x6, low_refresh_rate << 1);
+	if (adv7511->type == ADV7511)
+		regmap_update_bits(adv7511->regmap, 0xfb,
+			0x6, low_refresh_rate << 1);
+	else
+		regmap_update_bits(adv7511->regmap, 0x4a,
+			0xc, low_refresh_rate << 2);
+
 	regmap_update_bits(adv7511->regmap, 0x17,
 		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
Signature · 1 line
2.41.0
#2 lore raw
Quoted 11 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :)

- Nuno Sá

Quoted 30 lines

Changelog v1 -> v2:
*
https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--

 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +0 -0
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,

        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb, +                       0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a, +                       0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));

#3 lore raw
Quoted 8 lines · Nuno Sá
Quoted 6 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Quoted 7 lines
Quoted 5 lines
Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :)

oops; yes;
will send a V3;

thanks for the notification;

Quoted 34 lines

- Nuno Sá

Quoted 30 lines

Changelog v1 -> v2:
*
https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -2
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb,
+                       0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a,
+                       0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
#4 lore raw

PATCH v3 1/1 drm: adv7511: Fix low refresh rate register for ADV7533/5

In reply to Bogdan Togorean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/[email protected]/T/#u
* Added my S-o-b tag back

Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -2
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
 	else
 		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-	regmap_update_bits(adv7511->regmap, 0xfb,
-		0x6, low_refresh_rate << 1);
+	if (adv7511->type == ADV7511)
+		regmap_update_bits(adv7511->regmap, 0xfb,
+			0x6, low_refresh_rate << 1);
+	else
+		regmap_update_bits(adv7511->regmap, 0x4a,
+			0xc, low_refresh_rate << 2);
+
 	regmap_update_bits(adv7511->regmap, 0x17,
 		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
Signature · 1 line
2.41.0
maintainer
#5 lore raw
Quoted 47 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/[email protected]/T/#u
* Added my S-o-b tag back

Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -3
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb,
+                       0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a,
+                       0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
--
Quoted 2 lines

2.41.0

This looks good, but I'm seeing some checkpatch style warnings, with those fixed feel free to add my r-b.

CHECK: Alignment should match open parenthesis #32: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:791:
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);

CHECK: Alignment should match open parenthesis #35: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:794:
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);

total: 0 errors, 0 warnings, 2 checks, 15 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 1955dfe734e4 ("drm: adv7511: Fix low refresh rate register for ADV7533/5") has style problems, please review.

NOTE: If any of the errors are false positives, please report

#6 lore raw
Quoted 48 lines · Robert Foss
Quoted 46 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/[email protected]/T/#u
* Added my S-o-b tag back

Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -2
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb,
+                       0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a,
+                       0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
Quoted 6 lines
Quoted 3 lines

--
2.41.0

This looks good, but I'm seeing some checkpatch style warnings, with those fixed feel free to add my r-b.

Thanks.
Will do.
May I ask what options you are using for checkpatch.pl? I don't seem to get those warnings.
And I'm basing on an "exynos-drm-fixes"branch from here
https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/
(I'll admit it may not be the correct branch)

# /scripts/checkpatch.pl
v3-0001-drm-adv7511-Fix-low-refresh-rate-register-for-ADV.patch
total: 0 errors, 0 warnings, 15 lines checked

v3-0001-drm-adv7511-Fix-low-refresh-rate-register-for-ADV.patch has no obvious style problems and is ready for submission.

Quoted 20 lines

CHECK: Alignment should match open parenthesis #32: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:791:

drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +2 -0
+        regmap_update_bits(adv7511->regmap, 0xfb,
+            0x6, low_refresh_rate << 1);

CHECK: Alignment should match open parenthesis #35: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:794:

drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +2 -0
+        regmap_update_bits(adv7511->regmap, 0x4a,
+            0xc, low_refresh_rate << 2);

total: 0 errors, 0 warnings, 2 checks, 15 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 1955dfe734e4 ("drm: adv7511: Fix low refresh rate register for ADV7533/5") has style problems, please review.

NOTE: If any of the errors are false positives, please report

#7 lore raw
Quoted 60 lines · Alexandru Ardelean
Quoted 52 lines · Robert Foss
Quoted 49 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

Changelog v2 -> v3:
*
https://lore.kernel.org/dri-devel/[email protected]/T/#u
* Added my S-o-b tag back

Changelog v1 -> v2:
*
https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--

 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +0 -0
index ddceafa7b637..09290a377957 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,

        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;

-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb, +                       0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a, +                       0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));

Quoted 6 lines
Quoted 3 lines

--
2.41.0

This looks good, but I'm seeing some checkpatch style warnings, with those fixed feel free to add my r-b.

Quoted 3 lines

Thanks.
Will do.
May I ask what options you are using for checkpatch.pl?

'--strict' should trigger those CHECKS...

Cool enough (or not) it seems the option is not really there when you type --help

- Nuno Sá

#8 lore raw

PATCH v4 1/1 drm: adv7511: Fix low refresh rate register for ADV7533/5

In reply to Bogdan Togorean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -2
index ddceafa7b637..8d6c93296503 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
 	else
 		low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-	regmap_update_bits(adv7511->regmap, 0xfb,
-		0x6, low_refresh_rate << 1);
+	if (adv7511->type == ADV7511)
+		regmap_update_bits(adv7511->regmap, 0xfb,
+				   0x6, low_refresh_rate << 1);
+	else
+		regmap_update_bits(adv7511->regmap, 0x4a,
+				   0xc, low_refresh_rate << 2);
+
 	regmap_update_bits(adv7511->regmap, 0x17,
 		0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
Signature · 1 line
2.41.0
#9 lore raw
Quoted 7 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Quoted 6 lines
Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")

---

Right.
I forgot a changelog here.
Apologies

Changelog v3 -> v4:
* Ran ./scripts/checkpatch.pl --strict
* Added Reviewed-by: Robert Foss <[email protected]>

Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/[email protected]/T/#u
* Added my S-o-b tag back

Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/[email protected]/
* added Fixes: tag
* added Reviewed-by: tag for Nuno

Quoted 26 lines
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +7 -3
index ddceafa7b637..8d6c93296503 100644
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
        else
                low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
 
-       regmap_update_bits(adv7511->regmap, 0xfb,
-               0x6, low_refresh_rate << 1);
+       if (adv7511->type == ADV7511)
+               regmap_update_bits(adv7511->regmap, 0xfb,
+                                  0x6, low_refresh_rate << 1);
+       else
+               regmap_update_bits(adv7511->regmap, 0x4a,
+                                  0xc, low_refresh_rate << 2);
+
        regmap_update_bits(adv7511->regmap, 0x17,
                0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
 
--

2.41.0

Reviewed-by on v4 1/1
#10 lore raw
In reply to Alexandru Ardelean
Quoted 11 lines · Alexandru Ardelean

From: Bogdan Togorean <[email protected]>

For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.

Fixes 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")