Skip to contentSkip to conversation

Makefile: Add missing quotes around sort --field-separator

PATCH In review Marek Vasut 3 participants 3 messages Jul 11, 2023 – Jul 18, 2023 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: Add missing quotes around sort --field-separator

Busybox sort does not handle --field-separator== , replace this with --field-separator='=' for maximum compatibility.

Fixes cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")

---
Cc: Christoph Niedermaier <[email protected]>
Cc: Marek Behún <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 8d9aef464d0..425641d0fe6 100644
@@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV  $@
 cmd_genenv = \
 	$(objtree)/tools/printinitialenv | \
 	sed -e '/^\s*$$/d' | \
-	sort --field-separator== -k1,1 --stable -o $@
+	sort --field-separator='=' -k1,1 --stable -o $@
 
 u-boot-initial-env: $(env_h) FORCE
 	$(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenv
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Marek Vasut

Busybox sort does not handle --field-separator== , replace this with --field-separator='=' for maximum compatibility.

Fixes cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")

---
Cc: Christoph Niedermaier <[email protected]>
Cc: Marek Behún <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
Cc: [email protected]

Quoted 3 lines
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)