PCI: layerscape: Add support for Link down notification
Subsystems (4)
Frank Li
maintainerPATCH v2 1/2 PCI: layerscape: Add support for Link down notification
Add support to pass Link down notification to Endpoint function driver so that the LINK_DOWN event can be processed by the function.
---
Change from v1 to v2
- move pci_epc_linkdown() after dev_dbg()
drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + 1 file changed, 1 insertion(+)
drivers/pci/controller/dwc/pci-layerscape-ep.c +1 -0
@@ -89,6 +89,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)dev_dbg (pci->dev,"Link up\n" ); }else if (val &PEX_PF0_PME_MES_DR_LDD ) {dev_dbg (pci->dev,"Link down\n" ); +pci_epc_linkdown (pci->ep.epc); }else if (val &PEX_PF0_PME_MES_DR_HRD ) {dev_dbg (pci->dev,"Hot reset\n" ); }
Signature · 1 line
2.34.1
Frank Li
maintainerPATCH v2 2/2 PCI: layerscape: Add the workaround for lost link capablities during reset
From: Xiaowei Bao <[email protected]>
A workaround for the issue where the PCI Express Endpoint (EP) controller loses the values of the Maximum Link Width and Supported Link Speed from the Link Capabilities Register, which initially configured by the Reset Configuration Word (RCW) during a link-down or hot reset event.
---
change from v1 to v2:
- add comments at restore register
- add fixes tag
.../pci/controller/dwc/pci-layerscape-ep.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
drivers/pci/controller/dwc/pci-layerscape-ep.c +19 -0
@@ -45,6 +45,7 @@ struct ls_pcie_ep {struct pci_epc_features *ls_epc;const struct ls_pcie_ep_drvdata *drvdata;int irq; +u32 lnkcap;bool big_endian; };
@@ -73,6 +74,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)struct ls_pcie_ep *pcie = dev_id;struct dw_pcie *pci = pcie->pci;u32 val, cfg; +u8 offset; val =ls_lut_readl (pcie,PEX_PF0_PME_MES_DR );ls_lut_writel (pcie,PEX_PF0_PME_MES_DR , val);
@@ -81,6 +83,19 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)return IRQ_NONE ;if (val &PEX_PF0_PME_MES_DR_LUD ) { + + offset =dw_pcie_find_capability (pci,PCI_CAP_ID_EXP ); + +/* +* The values of the Maximum Link Width and Supported Link +* Speed from the Link Capabilities Register will be lost +* during link down or hot reset. Restore initial value +* that configured by the Reset Configuration Word (RCW). +*/ +dw_pcie_dbi_ro_wr_en (pci); +dw_pcie_writel_dbi (pci, offset +PCI_EXP_LNKCAP , pcie->lnkcap); +dw_pcie_dbi_ro_wr_dis (pci); + cfg =ls_lut_readl (pcie,PEX_PF0_CONFIG ); cfg |=PEX_PF0_CFG_READY ;ls_lut_writel (pcie,PEX_PF0_CONFIG , cfg);
@@ -216,6 +231,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)struct ls_pcie_ep *pcie;struct pci_epc_features *ls_epc;struct resource *dbi_base; +u8 offset;int ret; pcie =devm_kzalloc (dev,sizeof (*pcie),GFP_KERNEL );
@@ -252,6 +268,9 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pcie); + offset =dw_pcie_find_capability (pci,PCI_CAP_ID_EXP ); + pcie->lnkcap =dw_pcie_readl_dbi (pci, offset +PCI_EXP_LNKCAP ); + ret =dw_pcie_ep_init (&pci->ep);if (ret)return ret;
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] PCI: layerscape: Add the workaround for lost link capablities during reset
Quoted 11 lines · Frank Li
From: Xiaowei Bao <[email protected]>
A workaround for the issue where the PCI Express Endpoint (EP) controller loses the values of the Maximum Link Width and Supported Link Speed from the Link Capabilities Register, which initially configured by the Reset Configuration Word (RCW) during a link-down or hot reset event.
Fixes a805770d8a22 ("PCI: layerscape: Add EP mode support")Signed-off-by Xiaowei Bao <[email protected]>Signed-off-by Hou Zhiqiang <[email protected]>Signed-off-by Frank Li <[email protected]>
- Mani
Quoted 69 lines
---
change from v1 to v2:
- add comments at restore register
- add fixes tag.../pci/controller/dwc/pci-layerscape-ep.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)drivers/pci/controller/dwc/pci-layerscape-ep.c +19
-0@@ -45,6 +45,7 @@ struct ls_pcie_ep {struct pci_epc_features *ls_epc;const struct ls_pcie_ep_drvdata *drvdata;int irq; +u32 lnkcap;bool big_endian; };@@ -73,6 +74,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)struct ls_pcie_ep *pcie = dev_id;struct dw_pcie *pci = pcie->pci;u32 val, cfg; +u8 offset; val =ls_lut_readl (pcie,PEX_PF0_PME_MES_DR );ls_lut_writel (pcie,PEX_PF0_PME_MES_DR , val);@@ -81,6 +83,19 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)return IRQ_NONE ;if (val &PEX_PF0_PME_MES_DR_LUD ) { + + offset =dw_pcie_find_capability (pci,PCI_CAP_ID_EXP ); + +/* +* The values of the Maximum Link Width and Supported Link +* Speed from the Link Capabilities Register will be lost +* during link down or hot reset. Restore initial value +* that configured by the Reset Configuration Word (RCW). +*/ +dw_pcie_dbi_ro_wr_en (pci); +dw_pcie_writel_dbi (pci, offset +PCI_EXP_LNKCAP , pcie->lnkcap); +dw_pcie_dbi_ro_wr_dis (pci); + cfg =ls_lut_readl (pcie,PEX_PF0_CONFIG ); cfg |=PEX_PF0_CFG_READY ;ls_lut_writel (pcie,PEX_PF0_CONFIG , cfg);@@ -216,6 +231,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)struct ls_pcie_ep *pcie;struct pci_epc_features *ls_epc;struct resource *dbi_base; +u8 offset;int ret; pcie =devm_kzalloc (dev,sizeof (*pcie),GFP_KERNEL );@@ -252,6 +268,9 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)platform_set_drvdata (pdev, pcie); + offset =dw_pcie_find_capability (pci,PCI_CAP_ID_EXP ); + pcie->lnkcap =dw_pcie_readl_dbi (pci, offset +PCI_EXP_LNKCAP ); + ret =dw_pcie_ep_init (&pci->ep);if (ret)return ret;Signature · 1 line
2.34.1
Signature · 1 line
மணிவண்ணன் சதாசிவம்