Skip to contentSkip to conversation

TinyDRM display driver for Philips PCD8544 display controller

PATCH In review Viktar Simanenka 4 participants 7 messages Jul 18, 2023 – Jul 19, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TinyDRM display driver for Philips PCD8544 display controller

Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.

---
 .../bindings/display/philips,pcd8544.yaml     |  92 ++++
 drivers/gpu/drm/tiny/Kconfig                  |  11 +
 drivers/gpu/drm/tiny/pcd8544.c                | 506 ++++++++++++++++++
 3 files changed, 609 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
 create mode 100644 drivers/gpu/drm/tiny/pcd8544.c
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +92 -0
new file mode 100644
index 000000000000..d56a0c747812
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Philips PCD8544 LCD Display Controller
+
+maintainers:
+  - Viktar Simanenka <[email protected]>
+
+description: |
+  Philips PCD8544 LCD Display Controller with SPI control bus.
+  This is a driver for monochrome 84x48 LCD displays,
+  such as Nokia 5110/3310 LCDs. May contain backlight LED.
+
+allOf:
+  - $ref: panel/panel-common.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    const: philips,pcd8544
+
+  dc-gpios:
+    maxItems: 1
+    description: Display data/command selection (D/CX)
+
+  reset-gpios:
+    maxItems: 1
+    description: Display hardware reset line (RST)
+
+  inverted:
+    maxItems: 1
+    description: Invert display colors
+
+  voltage_op:
+    maxItems: 1
+    description: Set operation voltage (contrast)
+
+  bias:
+    maxItems: 1
+    description: Bias voltage level
+
+  temperature_coeff:
+    maxItems: 1
+    description: Temperature coefficient
+
+required:
+  - compatible
+  - reg
+  - dc-gpios
+  - reset-gpios
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    display@0 {
+        compatible = "philips,pcd8544";
+        spi-max-frequency = <8000000>;
+        reg = <0>;
+
+        dc-gpios = <&pio 0 3 0>; /* DC=PA3 */
+        reset-gpios = <&pio 0 1 0>; /* RESET=PA1 */
+        backlight = <&display_backlight>;
+        write-only;
+
+        /* Default values: */
+        inverted = <0>;
+        voltage_op = <0>;
+        bias = <4>;
+        temperature_coeff = <0>;
+
+        width-mm = <35>;
+        height-mm = <28>;
+
+        panel-timing {
+            hactive = <84>;
+            vactive = <48>;
+            hback-porch = <0>;
+            vback-porch = <0>;
+
+            clock-frequency = <0>;
+            hfront-porch = <0>;
+            hsync-len = <0>;
+            vfront-porch = <0>;
+            vsync-len = <0>;
+        };
+    };
+
+...
drivers/gpu/drm/tiny/Kconfig +11 -0
index f6889f649bc1..10caa0818253 100644
@@ -172,6 +172,17 @@ config TINYDRM_MI0283QT
 	  DRM driver for the Multi-Inno MI0283QT display panel
 	  If M is selected the module will be called mi0283qt.
 
+config TINYDRM_PCD8544
+	tristate "DRM support for PCD8544 displays"
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_GEM_DMA_HELPER
+	select BACKLIGHT_CLASS_DEVICE
+	help
+	  DRM driver for PCD8544 (Nokia 5110/3310) 84x48 LCD displays.
+
+	  If M is selected the module will be called pcd8544.
+
 config TINYDRM_REPAPER
 	tristate "DRM support for Pervasive Displays RePaper panels (V231)"
 	depends on DRM && SPI
drivers/gpu/drm/tiny/pcd8544.c new file +506 -0

506 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 1 line · Viktar Simanenka

Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.

Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Quoted 4 lines
---
 .../bindings/display/philips,pcd8544.yaml     |  92 ++++

Bindings are always separate patches.

Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.

Quoted 16 lines
 drivers/gpu/drm/tiny/Kconfig                  |  11 +
 drivers/gpu/drm/tiny/pcd8544.c                | 506 ++++++++++++++++++
 3 files changed, 609 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
 create mode 100644 drivers/gpu/drm/tiny/pcd8544.c
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +4 -0
new file mode 100644
index 000000000000..d56a0c747812
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml#

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 14

Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Philips PCD8544 LCD Display Controller
+
+maintainers:
+  - Viktar Simanenka <[email protected]>
+
+description: |
+  Philips PCD8544 LCD Display Controller with SPI control bus.
+  This is a driver for monochrome 84x48 LCD displays,

LCD Display controller is a driver? Are you sure? Or maybe you are describing Linux driver? If so, drop references to drivers and describe the hardware.

Quoted 11 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +11 -0
+  such as Nokia 5110/3310 LCDs. May contain backlight LED.
+
+allOf:
+  - $ref: panel/panel-common.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    const: philips,pcd8544
+
+  dc-gpios:

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 35

Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10 -0
+    maxItems: 1
+    description: Display data/command selection (D/CX)
+
+  reset-gpios:
+    maxItems: 1
+    description: Display hardware reset line (RST)
+
+  inverted:
+    maxItems: 1
+    description: Invert display colors

Missing vendor prefix, ref/type, incorrect maxItems (???).

You described the desired Linux feature or behavior, not the actual hardware. The bindings are about the latter, so instead you need to rephrase the property and its description to match actual hardware capabilities/features/configuration etc.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 37

Quoted 2 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +2 -0
+
+  voltage_op:

No underscores in names.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 39

Quoted 2 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +2 -0
+    maxItems: 1
+    description: Set operation voltage (contrast)

What? Sorry, I don't understand.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 47

Quoted 8 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +8 -0
+
+  bias:
+    maxItems: 1
+    description: Bias voltage level
+
+  temperature_coeff:
+    maxItems: 1
+    description: Temperature coefficient

You just copied the property name into description. Very helpful.

You clearly did not test it.

Quoted 8 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +8 -0
+
+required:
+  - compatible
+  - reg
+  - dc-gpios
+  - reset-gpios
+
+unevaluatedProperties: false

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 65

Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10 -0
+
+examples:
+  - |
+    display@0 {
+        compatible = "philips,pcd8544";
+        spi-max-frequency = <8000000>;
+        reg = <0>;
+
+        dc-gpios = <&pio 0 3 0>; /* DC=PA3 */
+        reset-gpios = <&pio 0 1 0>; /* RESET=PA1 */

Use proper defines for flags.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 67

Quoted 2 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +2 -0
+        backlight = <&display_backlight>;
+        write-only;

It does not look like you tested the bindings, at least after quick look. Please run make dt_binding_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml line 73

Quoted 6 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +6 -0
+
+        /* Default values: */
+        inverted = <0>;
+        voltage_op = <0>;
+        bias = <4>;
+        temperature_coeff = <0>;

What? Your code is confusing.

Quoted 18 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +18 -0
+
+        width-mm = <35>;
+        height-mm = <28>;
+
+        panel-timing {
+            hactive = <84>;
+            vactive = <48>;
+            hback-porch = <0>;
+            vback-porch = <0>;
+
+            clock-frequency = <0>;
+            hfront-porch = <0>;
+            hsync-len = <0>;
+            vfront-porch = <0>;
+            vsync-len = <0>;
+        };
+    };
+

...

Documentation/devicetree/bindings/display/philips,pcd8544.yaml

Quoted 11 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +11 -0
+
+static int pcd8544_probe(struct spi_device *spi)
+{
+	struct device *dev = &spi->dev;
+	struct pcd8544_device *pcd8544_dev;
+	struct drm_device *drm;
+	int ret;
+	static const uint64_t modifiers[] = {
+		DRM_FORMAT_MOD_LINEAR,
+		DRM_FORMAT_MOD_INVALID
+	};

Missing blank line.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml

Quoted 2 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +2 -0
+	pcd8544_dev = devm_drm_dev_alloc(dev, &pcd8544_driver, struct pcd8544_device, drm);
+

Drop blank line.

Documentation/devicetree/bindings/display/philips,pcd8544.yaml

Quoted 8 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +8 -0
+	if (IS_ERR(pcd8544_dev))
+		return PTR_ERR(pcd8544_dev);
+
+	pcd8544_dev->spi = spi;
+
+	pcd8544_dev->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(pcd8544_dev->reset))
+		return dev_err_probe(dev, PTR_ERR(pcd8544_dev->reset), "Failed to get GPIO 'reset'\n");

You start in reset mode? Didn't you just confure values? 1 is reset.

Quoted 80 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +80 -0
+
+	pcd8544_dev->dc = devm_gpiod_get(dev, "dc", GPIOD_OUT_LOW);
+	if (IS_ERR(pcd8544_dev->dc))
+		return dev_err_probe(dev, PTR_ERR(pcd8544_dev->dc), "Failed to get GPIO 'dc'\n");
+
+	pcd8544_dev->backlight = devm_of_find_backlight(dev);
+	if (IS_ERR(pcd8544_dev->backlight))
+		return PTR_ERR(pcd8544_dev->backlight);
+
+	if (device_property_read_u32(dev, "inverted", &pcd8544_dev->inverted))
+		pcd8544_dev->inverted = 0;
+	if (device_property_read_u32(dev, "temperature_coeff", &pcd8544_dev->temperature_coeff))
+		pcd8544_dev->temperature_coeff = 0;
+	if (device_property_read_u32(dev, "bias", &pcd8544_dev->bias))
+		pcd8544_dev->bias = 4;
+	if (device_property_read_u32(dev, "voltage_op", &pcd8544_dev->voltage_op))
+		pcd8544_dev->voltage_op = 0;
+
+	if (!dev->coherent_dma_mask) {
+		ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32));
+		if (ret) {
+			dev_warn(dev, "Failed to set dma mask %d\n", ret);
+			return ret;
+		}
+	}
+
+	drm_mode_copy(&pcd8544_dev->mode, &pcd8544_mode);
+	pcd8544_dev->width = pcd8544_mode.hdisplay;
+	pcd8544_dev->height = pcd8544_mode.vdisplay;
+	pcd8544_dev->tx_buflen = pcd8544_dev->width * DIV_ROUND_UP(pcd8544_dev->height, 8);
+	pcd8544_dev->tx_buf = devm_kzalloc(dev, pcd8544_dev->tx_buflen, GFP_KERNEL);
+	if (!pcd8544_dev->tx_buf)
+		return -ENOMEM;
+
+	drm = &pcd8544_dev->drm;
+	ret = drmm_mode_config_init(drm);
+	if (ret)
+		return ret;
+
+	drm_connector_helper_add(&pcd8544_dev->connector, &pcd8544_connector_hfuncs);
+	ret = drm_connector_init(drm, &pcd8544_dev->connector, &pcd8544_connector_funcs, DRM_MODE_CONNECTOR_SPI);
+	if (ret)
+		return ret;
+
+	drm->mode_config.funcs = &pcd8544_mode_config_funcs;
+	drm->mode_config.min_width = pcd8544_dev->mode.hdisplay;
+	drm->mode_config.max_width = pcd8544_dev->mode.hdisplay;
+	drm->mode_config.min_height = pcd8544_dev->mode.vdisplay;
+	drm->mode_config.max_height = pcd8544_dev->mode.vdisplay;
+
+	ret = drm_simple_display_pipe_init(drm, &pcd8544_dev->pipe, &pcd8544_pipe_funcs,
+					pcd8544_formats, ARRAY_SIZE(pcd8544_formats),
+					modifiers, &pcd8544_dev->connector);
+	if (ret)
+		return ret;
+
+	drm_plane_enable_fb_damage_clips(&pcd8544_dev->pipe.plane);
+
+	spi_set_drvdata(spi, drm);
+
+	drm_mode_config_reset(drm);
+
+	ret = drm_dev_register(drm, 0);
+	if (ret)
+		return ret;
+
+	drm_dbg(drm, "SPI speed: %uMHz\n", spi->max_speed_hz / 1000000);
+
+	drm_fbdev_generic_setup(drm, 0);
+
+	return 0;
+}
+
+static void pcd8544_remove(struct spi_device *spi)
+{
+	struct drm_device *drm = spi_get_drvdata(spi);
+
+	drm_dev_unplug(drm);
+	drm_atomic_helper_shutdown(drm);
+}

Documentation/devicetree/bindings/display/philips,pcd8544.yaml

Quoted 10 lines
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +10 -0
+
+static void pcd8544_shutdown(struct spi_device *spi)
+{
+	drm_atomic_helper_shutdown(spi_get_drvdata(spi));
+}
+
+static struct spi_driver pcd8544_spi_driver = {
+	.driver = {
+		.name = "pcd8544",
+		.owner = THIS_MODULE,

Drop. And run coccinelle, smatch and sparse.

Best regards,
Krzysztof

#2 lore raw

PATCH 1/2 dt-bindings: add vendor-prefixes and bindings for pcd8544 displays

Quoted 2 lines · Krzysztof Kozlowski

Bindings are always separate patches.
Please run scripts/checkpatch.pl and fix reported warnings.

Added vendor-prefix to fix warning.

Quoted 7 lines

Review

Quoted 3 lines

+ inverted:

(quoted diff) +2 -0
+    maxItems: 1
+    description: Invert display colors

You described the desired Linux feature or behavior, not the actual hardware. The bindings are about the latter, so instead you need to rephrase the property and its description to match actual hardware capabilities/features/configuration etc.

revised the descriptions and added suitable types according to the documentation

Quoted 3 lines

Please run make dt_binding_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint.

cleaned up unneccessary fields (leftovers) from tested binding

Quoted 4 lines · Rob Herring

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date
Please check and re-submit after running the above command yourself.

upgraded dtschema and found all the warnings. thanks. seems to be fixed

---
 .../bindings/display/philips,pcd8544.yaml     | 89 +++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 2 files changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
Documentation/devicetree/bindings/display/philips,pcd8544.yaml new file +89 -0
new file mode 100644
index 000000000000..ac880d9d8cc1
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Philips PCD8544 LCD Display Controller
+
+maintainers:
+  - Viktar Simanenka <[email protected]>
+
+description: |
+  Philips PCD8544 LCD Display Controller with SPI control bus.
+  Monochrome 84x48 LCD displays, such as Nokia 5110/3310 LCDs.
+  May contain backlight LED.
+
+allOf:
+  - $ref: panel/panel-common.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - philips,pcd8544
+
+  dc-gpios:
+    maxItems: 1
+    description: Data/Command selection pin (D/CX)
+
+  reset-gpios:
+    maxItems: 1
+    description: Display Reset pin (RST)
+
+  philips,inverted:
+    type: boolean
+    description: Display color inversion
+
+  philips,voltage-op:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 127
+    description: Display liquid crystal operation voltage
+
+  philips,bias:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 7
+    description: Display bias voltage system value
+
+  philips,temperature-coeff:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 3
+    description: Display temperature compensation coefficient
+
+required:
+  - compatible
+  - reg
+  - dc-gpios
+  - reset-gpios
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        display@0 {
+            compatible = "philips,pcd8544";
+            spi-max-frequency = <8000000>;
+            reg = <0>;
+
+            dc-gpios = <&pio 0 3 GPIO_ACTIVE_HIGH>; /* DC=PA3 */
+            reset-gpios = <&pio 0 1 GPIO_ACTIVE_HIGH>; /* RESET=PA1 */
+            backlight = <&backlight>;
+
+            philips,inverted;
+            philips,voltage-op = <0>;
+            philips,bias = <4>;
+            philips,temperature-coeff = <0>;
+        };
+    };
+
+...
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index af60bf1a6664..0c3844af6776 100644
@@ -1037,6 +1037,8 @@ patternProperties:
     description: Pervasive Displays, Inc.
   "^phicomm,.*":
     description: PHICOMM Co., Ltd.
+  "^philips,.*":
+    description: Koninklijke Philips N.V.
   "^phytec,.*":
     description: PHYTEC Messtechnik GmbH
   "^picochip,.*":
Signature · 1 line
2.34.1
#3 lore raw

PATCH 2/2 drm/tiny: add display driver for philips pcd8544 display controller

Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.

Quoted 4 lines · Krzysztof Kozlowski

Review

Quoted 3 lines
(quoted diff) +3 -0
+    pcd8544_dev->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+    if (IS_ERR(pcd8544_dev->reset))
+        return dev_err_probe(dev, PTR_ERR(pcd8544_dev->reset), "Failed to get GPIO 'reset'\n");

You start in reset mode? Didn't you just confure values? 1 is reset.

On this controller RESET is active LOW. I start it in normal mode.

Quoted 1 line

Drop. And run coccinelle, smatch and sparse.

Run through and fixed warnings with smatch and sparse.

---
 drivers/gpu/drm/tiny/Kconfig   |  11 +
 drivers/gpu/drm/tiny/Makefile  |   1 +
 drivers/gpu/drm/tiny/pcd8544.c | 506 +++++++++++++++++++++++++++++++++
 3 files changed, 518 insertions(+)
 create mode 100644 drivers/gpu/drm/tiny/pcd8544.c
drivers/gpu/drm/tiny/Kconfig +11 -0
index f6889f649bc1..10caa0818253 100644
@@ -172,6 +172,17 @@ config TINYDRM_MI0283QT
 	  DRM driver for the Multi-Inno MI0283QT display panel
 	  If M is selected the module will be called mi0283qt.
 
+config TINYDRM_PCD8544
+	tristate "DRM support for PCD8544 displays"
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_GEM_DMA_HELPER
+	select BACKLIGHT_CLASS_DEVICE
+	help
+	  DRM driver for PCD8544 (Nokia 5110/3310) 84x48 LCD displays.
+
+	  If M is selected the module will be called pcd8544.
+
 config TINYDRM_REPAPER
 	tristate "DRM support for Pervasive Displays RePaper panels (V231)"
 	depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +1 -0
index 76dde89a044b..75bc112a02f9 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_TINYDRM_ILI9225)		+= ili9225.o
 obj-$(CONFIG_TINYDRM_ILI9341)		+= ili9341.o
 obj-$(CONFIG_TINYDRM_ILI9486)		+= ili9486.o
 obj-$(CONFIG_TINYDRM_MI0283QT)		+= mi0283qt.o
+obj-$(CONFIG_TINYDRM_PCD8544)		+= pcd8544.o
 obj-$(CONFIG_TINYDRM_REPAPER)		+= repaper.o
 obj-$(CONFIG_TINYDRM_ST7586)		+= st7586.o
 obj-$(CONFIG_TINYDRM_ST7735R)		+= st7735r.o
drivers/gpu/drm/tiny/pcd8544.c new file +506 -0

506 lines not on this page · raw message

Signature · 1 line
2.34.1
#4 lore raw

Re: [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for pcd8544 displays

In reply to Viktar Simanenka
Quoted 24 lines · Viktar Simanenka
Quoted 2 lines · Krzysztof Kozlowski

Bindings are always separate patches.
Please run scripts/checkpatch.pl and fix reported warnings.

Added vendor-prefix to fix warning.

Quoted 7 lines

Review

Quoted 3 lines

+ inverted:

(quoted diff) +2 -0
+    maxItems: 1
+    description: Invert display colors

You described the desired Linux feature or behavior, not the actual hardware. The bindings are about the latter, so instead you need to rephrase the property and its description to match actual hardware capabilities/features/configuration etc.

revised the descriptions and added suitable types according to the documentation

Quoted 3 lines

Please run make dt_binding_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint.

cleaned up unneccessary fields (leftovers) from tested binding

On 2023-07-18 9:19, Rob Herring wrote:

Quoted 8 lines
Quoted 4 lines

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date
Please check and re-submit after running the above command yourself.

upgraded dtschema and found all the warnings. thanks. seems to be fixed

No clue what is this - is it a reply or new patch to review... does not look like the latter, so I will just skip it. Please version your patches, provide changelog and send proper patchsets.

Best regards,
Krzysztof

maintainer
#5 lore raw
In reply to Viktar Simanenka
Quoted 11 lines · Viktar Simanenka

Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.

---
 .../bindings/display/philips,pcd8544.yaml     |  92 ++++
 drivers/gpu/drm/tiny/Kconfig                  |  11 +
 drivers/gpu/drm/tiny/pcd8544.c                | 506 ++++++++++++++++++
 3 files changed, 609 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
 create mode 100644 drivers/gpu/drm/tiny/pcd8544.c

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/philips,pcd8544.example.dts:21.13-23: Warning (reg_format): /example-0/display@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/philips,pcd8544.example.dtb: display@0: Unevaluated properties are not allowed ('write-only' was unexpected)
from schema $id: http://devicetree.org/schemas/display/philips,pcd8544.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

#6 lore raw
In reply to Viktar Simanenka
Quoted 10 lines · Viktar Simanenka

Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays.

---
 .../bindings/display/philips,pcd8544.yaml     |  92 ++++
 drivers/gpu/drm/tiny/Kconfig                  |  11 +
 drivers/gpu/drm/tiny/pcd8544.c                | 506 ++++++++++++++++++
 3 files changed, 609 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
 create mode 100644 drivers/gpu/drm/tiny/pcd8544.c

Why is there no change to the Makefile?

Signature · 1 line
~Randy