rtc: bq4802: add sparc dependency
PATCH v2 1/1 rtc: bq4802: add sparc dependency
From: Arnd Bergmann <[email protected]>
The added HAS_IOPORT dependency might not actually be necessary as Geert points out, but the driver is also only used on one architecture. Sparc is also a special case here since it converts port numbers into virtual addresses rather than having them mapped into a particular part of the __iomem address space, so the difference is actually not important here.
Add a dependency on sparc, but allow compile-testing otherwise, to make this clearer without anyone having to spend much time modernizing the driver beyond that.
---
v2: split dependency into two lines, as suggested by Geert
--- drivers/rtc/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/rtc/Kconfig +1 -0
@@ -1196,6 +1196,7 @@ config RTC_DRV_MSM6242 config RTC_DRV_BQ4802 tristate "TI BQ4802" depends on HAS_IOMEM && HAS_IOPORT + depends on SPARC || COMPILE_TEST help If you say Y here you will get support for the TI BQ4802 RTC chip.
Signature · 1 line
2.39.2
Quoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The added
HAS_IOPORTdependency might not actually be necessary as Geert points out, but the driver is also only used on one architecture. Sparc is also a special case here since it converts port numbers into virtual addresses rather than having them mapped into a particular part of the__iomemaddress space, so the difference is actually not important here.Add a dependency on sparc, but allow compile-testing otherwise, to make this clearer without anyone having to spend much time modernizing the driver beyond that.
Quoted 6 lines
Reported-by Geert Uytterhoeven <[email protected]>Cc David S. Miller <[email protected]>Link https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@mail.gmail.com/ open hereSigned-off-by Arnd Bergmann <[email protected]>---
v2: split dependency into two lines, as suggested by Geert
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 11 lines · Arnd Bergmann
The added
HAS_IOPORTdependency might not actually be necessary as Geert points out, but the driver is also only used on one architecture. Sparc is also a special case here since it converts port numbers into virtual addresses rather than having them mapped into a particular part of the__iomemaddress space, so the difference is actually not important here.Add a dependency on sparc, but allow compile-testing otherwise, to make this clearer without anyone having to spend much time modernizing the driver beyond that.
[...]
Applied, thanks!
[1/1] rtc: bq4802: add sparc dependency
commit: 766c3f8a092b4d42abd68ee0338349838430a5ee
Best regards,
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com