Skip to contentSkip to conversation

soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static

PATCH In review Min-Hua Chen 2 participants 2 messages Jul 19, 2023 – Jul 20, 2023 Arm/Apple machine support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static

This patch fixes the following sparse warnings:

drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?

No functional change intended.

---
 drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/apple/apple-pmgr-pwrstate.c +1 -1
index d62a776c89a1..9467235110f4 100644
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
 	return !!(reg & APPLE_PMGR_RESET);
 }
 
-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
 	.assert		= apple_pmgr_reset_assert,
 	.deassert	= apple_pmgr_reset_deassert,
 	.reset		= apple_pmgr_reset_reset,
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Min-Hua Chen

This patch fixes the following sparse warnings:

drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?

No functional change intended.

---

Thanks,

Sven

Quoted 20 lines
 drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/apple/apple-pmgr-pwrstate.c +0 -0
index d62a776c89a1..9467235110f4 100644
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct 

reset_controller_dev *rcdev, unsigned

drivers/soc/apple/apple-pmgr-pwrstate.c +1 -1
 	return !!(reg & APPLE_PMGR_RESET);
 }
 
-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
 	.assert		= apple_pmgr_reset_assert,
 	.deassert	= apple_pmgr_reset_deassert,
 	.reset		= apple_pmgr_reset_reset,
Signature · 1 line
2.34.1