Skip to contentSkip to conversation

igc: Decrease PTM short interval from 10 us to 1 us

PATCH In review Sasha Neftin 3 participants 3 messages Jul 20, 2023 – Aug 14, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 igc: Decrease PTM short interval from 10 us to 1 us

With the 10us interval, we were seeing PTM transactions take around 12us. Hardware team suggested this interval could be lowered to 1us which was confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took around 2us.

---
v1->v2: Fixed commit message

---
 drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc_defines.h +1 -1
index 44a507029946..c3722f524ea7 100644
@@ -549,7 +549,7 @@
 #define IGC_PTM_CTRL_SHRT_CYC(usec)	(((usec) & 0x2f) << 2)
 #define IGC_PTM_CTRL_PTM_TO(usec)	(((usec) & 0xff) << 8)
 
-#define IGC_PTM_SHORT_CYC_DEFAULT	10  /* Default Short/interrupted cycle interval */
+#define IGC_PTM_SHORT_CYC_DEFAULT	1   /* Default short cycle interval */
 #define IGC_PTM_CYC_TIME_DEFAULT	5   /* Default PTM cycle time */
 #define IGC_PTM_TIMEOUT_DEFAULT		255 /* Default timeout for PTM errors */
 
Signature · 6 lines
2.34.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by Reviewed-by on v2 1/1
#1 lore raw

Hi Sasha,

Quoted 31 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Sasha Neftin
Sent: Thursday, 20 July, 2023 11:49 AM
To: [email protected]
Subject: [Intel-wired-lan] [PATCH iwl-next v2 1/1] igc: Decrease PTM short interval from 10 us to 1 us

With the 10us interval, we were seeing PTM transactions take around 12us. Hardware team suggested this interval could be lowered to 1us which was confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took around 2us.

---
v1->v2: Fixed commit message

---
 drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc_defines.h +0 -1
index 44a507029946..c3722f524ea7 100644
@@ -549,7 +549,7 @@
 #define IGC_PTM_CTRL_SHRT_CYC(usec)	(((usec) & 0x2f) << 2)
 #define IGC_PTM_CTRL_PTM_TO(usec)	(((usec) & 0xff) << 8)
 
-#define IGC_PTM_SHORT_CYC_DEFAULT	10  /* Default
Quoted 7 lines

Short/interrupted cycle interval */
+#define IGC_PTM_SHORT_CYC_DEFAULT 1 /* Default short cycle
interval */
#define IGC_PTM_CYC_TIME_DEFAULT 5 /* Default PTM cycle time
*/
#define IGC_PTM_TIMEOUT_DEFAULT 255 /* Default
timeout for PTM errors */

I tested this setting with my TGL-U board(back-2-back). As of now, I see no problem.

LGTM.

Quoted 8 lines

--
2.34.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Tested-by on v2 1/1
#2 lore raw
In reply to Sasha Neftin
Quoted 5 lines · Sasha Neftin

With the 10us interval, we were seeing PTM transactions take around 12us. Hardware team suggested this interval could be lowered to 1us which was confirmed with PCIe sniffer. With the 1us interval, PTM dialogs took around 2us.

Quoted 7 lines

---
v1->v2: Fixed commit message

---
  drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan