Makefile: Use sort shortopts
PATCH 1/1 Makefile: Use sort shortopts
POSIX does not defined longopts for sort, use shortops for even more compatibility.
---
Cc: Christoph Niedermaier <[email protected]>
Cc: Marek Behún <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV $@ cmd_genenv = \ $(objtree)/tools/printinitialenv | \ sed -e '/^\s*$$/d' | \ - sort --field-separator='=' -k1,1 --stable -o $@ + sort -t '=' -k 1,1 -s -o $@ u-boot-initial-env: $(env_h) FORCE $(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenv
Signature · 1 line
2.40.1
Quoted 5 lines
From: Marek Vasut <[email protected]>
Date: Thu, 20 Jul 2023 14:50:42 +0200POSIX does not defined longopts for sort, use shortops for even more compatibility.
Even though OpenBSD's sort does implement the long options this is still good to have!
Quoted 31 lines
Fixes cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")Reported-by Milan P. Stanić <[email protected]>Signed-off-by Marek Vasut <[email protected]>---
Cc: Christoph Niedermaier <[email protected]>
Cc: Marek Behún <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
Cc: [email protected]--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-1@@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV $@ cmd_genenv = \ $(objtree)/tools/printinitialenv | \ sed -e '/^\s*$$/d' | \ - sort --field-separator='=' -k1,1 --stable -o $@ + sort -t '=' -k 1,1 -s -o $@ u-boot-initial-env: $(env_h) FORCE $(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenvSignature · 1 line
2.40.1
Quoted 6 lines · Marek Vasut
POSIX does not defined longopts for sort, use shortops for even more compatibility.
Fixes cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")Reported-by Milan P. Stanić <[email protected]>Signed-off-by Marek Vasut <[email protected]>
small note: single quotes are not needed aroud = (equal sign)
Quoted 27 lines
---
Cc: Christoph Niedermaier <[email protected]>
Cc: Marek Behún <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
Cc: [email protected]--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-1@@ -2444,7 +2444,7 @@ quiet_cmd_genenv = GENENV $@ cmd_genenv = \ $(objtree)/tools/printinitialenv | \ sed -e '/^\s*$$/d' | \ - sort --field-separator='=' -k1,1 --stable -o $@ + sort -t '=' -k 1,1 -s -o $@ u-boot-initial-env: $(env_h) FORCE $(Q)$(MAKE) $(build)=tools $(objtree)/tools/printinitialenvSignature · 1 line
2.40.1
Quoted 8 lines · Marek Vasut
POSIX does not defined longopts for sort, use shortops for even more compatibility.
Fixes cc5a490cf465 ("Makefile: Sort u-boot-initial-env output")Reported-by Milan P. Stanić <[email protected]>Signed-off-by Marek Vasut <[email protected]>Reviewed-by Mark Kettenis <[email protected]>Tested-by Milan P. Stanić <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom