gpio :lp3943 :remove unneeded platform_set_drvdata() call
PATCH 1/1 gpio :lp3943 :remove unneeded platform_set_drvdata() call
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
--- drivers/gpio/gpio-lp3943.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpio/gpio-lp3943.c +0 -2
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev) lp3943_gpio->chip = lp3943_gpio_chip; lp3943_gpio->chip.parent = &pdev->dev; -platform_set_drvdata (pdev, lp3943_gpio); -return devm_gpiochip_add_data (&pdev->dev, &lp3943_gpio->chip, lp3943_gpio); }
Signature · 1 line
2.34.1
Quoted 5 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
I got this twice, moreover the Subject is broken.
Signature · 2 lines
With Best Regards, Andy Shevchenko