Skip to contentSkip to conversation

tracing: add missing spaces after ';'

PATCH NAK [email protected] 2 participants 2 messages Jul 20, 2023 1 message not in the archive Tracing

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 tracing: add missing spaces after ';'

Remove spaces to clear checkpatch errors.

ERROR: space required after that ';' (ctx:VxV)

---
 include/trace/stages/stage4_event_fields.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/stages/stage4_event_fields.h +1 -1
index b6f679ae21aa..9627e081a990 100644
@@ -2,7 +2,7 @@
 
 /* Stage 4 definitions for creating trace events */
 
-#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
+#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; })))
 
 #undef __field_ext
 #define __field_ext(_type, _item, _filter_type) {            \
maintainer NAK
#2 lore raw
Quoted 3 lines · On Thu, 20 Jul 2023 10:30:36 +0800 [email protected] wrote:

Remove spaces to clear checkpatch errors.

ERROR: space required after that ';' (ctx:VxV)

PLEASE DO NOT RUN CHECKPATCH ON CURRENT CODE!!!!

As the name suggests, checkpatch is for patches and not for existing code. It is used as a guideline tool to make clean patches. But checkpatch is *NOT* the rule of the kernel. There's lots of issues that checkpatch reports that can be ignored. That is decided when the patch is submitted, and SHOULD NOT be revisited once it has been accepted. Not to mention this particular error is silly.

NACK!!!

-- Steve

Quoted 20 lines
---
  include/trace/stages/stage4_event_fields.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/stages/stage4_event_fields.h +1 -1
index b6f679ae21aa..9627e081a990 100644
@@ -2,7 +2,7 @@
 
  /* Stage 4 definitions for creating trace events */
 
-#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;})))
+#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; })))
 
  #undef __field_ext
  #define __field_ext(_type, _item, _filter_type) {            \