Skip to contentSkip to conversation

rpi-libcamera-apps: fix Illegal Instruction

PATCH In review Vivien Didelot 2 participants 2 messages Jul 21, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rpi-libcamera-apps: fix Illegal Instruction

With armv8-neon being enforced for all ARM based machines, running any libcamera app on raspberrypi (e.g. Raspberry Pi B Rev 2) results in Illegal Instruction.

To fix this, defaults to TARGET_ARCH for non-aarch64 machines.

---
 recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb | 1 -
 1 file changed, 1 deletion(-)
recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb +0 -1
index 062ded9..3460065 100644
@@ -30,7 +30,6 @@ EXTRA_OECMAKE = "\
 
 LIBCAMERA_ARCH = "${TARGET_ARCH}"
 LIBCAMERA_ARCH:aarch64 = "arm64"
-LIBCAMERA_ARCH:arm = "armv8-neon"
 EXTRA_OECMAKE += "-DENABLE_COMPILE_FLAGS_FOR_TARGET=${LIBCAMERA_ARCH}"
 
 PACKAGECONFIG[x11] = "-DENABLE_X11=1,-DENABLE_X11=0"
Signature · 1 line
2.41.0
#1 lore raw

Hi,

Quoted 17 lines · Vivien Didelot

With armv8-neon being enforced for all ARM based machines, running any libcamera app on raspberrypi (e.g. Raspberry Pi B Rev 2) results in Illegal Instruction.

To fix this, defaults to TARGET_ARCH for non-aarch64 machines.

---
 recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb | 1 -
 1 file changed, 1 deletion(-)
recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb +0 -0
index 062ded9..3460065 100644

recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb EXTRA_OECMAKE = "\ · line 34

Quoted 6 lines
recipes-multimedia/libcamera-apps/rpi-libcamera-apps_git.bb +0 -1
@@ -30,7 +30,6 @@ EXTRA_OECMAKE = "\
 
 LIBCAMERA_ARCH = "${TARGET_ARCH}"
 LIBCAMERA_ARCH:aarch64 = "arm64"
-LIBCAMERA_ARCH:arm = "armv8-neon"
 EXTRA_OECMAKE += "-DENABLE_COMPILE_FLAGS_FOR_TARGET=${LIBCAMERA_ARCH}"
 

Thanks for this. It looks good. Would you be able to send it as an MR in Github so we can CI it as well?

Andrei