Skip to contentSkip to conversation

package/opensc: link with -latomic if needed

PATCH In review Bernd Kuhls 2 participants 3 messages Jul 20, 2023 – Jul 24, 2023 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/opensc: link with -latomic if needed

Fixes:
http://autobuild.buildroot.net/results/fb4/fb4c6a97ac666a3a75345229a320769df6c0a909/

---
 package/opensc/opensc.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/opensc/opensc.mk +4 -0
index 253b6b26f8..8944b6c7ed 100644
@@ -13,4 +13,8 @@ OPENSC_DEPENDENCIES = openssl pcsc-lite
 OPENSC_INSTALL_STAGING = YES
 OPENSC_CONF_OPTS = --disable-cmocka --disable-strict
 
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+OPENSC_CONF_ENV += LIBS=-latomic
+endif
+
 $(eval $(autotools-package))
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 7 lines · On Thu, 20 Jul 2023 20:54:45 +0200 Bernd Kuhls <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/fb4/fb4c6a97ac666a3a75345229a320769df6c0a909/

---
 package/opensc/opensc.mk | 4 ++++
 1 file changed, 4 insertions(+)

I continue to think this is not the right way of handling this issue. opensc is using pkg-config to detect openssl, so it is the openssl .pc files that should have -latomic. This will fix the issue once for all for all users of openssl, without chasing them down one by one.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

A message that is not in the archive (sent off-list or not yet received): 20230720231717.33ed6806__30743.4139352821$1689887867$gmane$org@windsurf

#3 lore raw

Am Thu, 20 Jul 2023 23:17:17 +0200 schrieb Thomas Petazzoni via buildroot:

Quoted 4 lines

I continue to think this is not the right way of handling this issue. opensc is using pkg-config to detect openssl, so it is the openssl .pc files that should have -latomic. This will fix the issue once for all for all users of openssl, without chasing them down one by one.

Hi Thomas,

openssl has everything in place for statically linking to libatomic:

cat output/per-package/opensc/host/arceb-buildroot-linux-uclibc/sysroot/ usr/lib/pkgconfig/libcrypto.pc | grep atomic

Libs.private: -ldl -pthread -latomic -latomic

It's just the build system of opensc which does not make use of it. Due to my limited coding skills I only managed to disable building the test binaries which include the broken file:
https://patchwork.ozlabs.org/project/buildroot/patch/
[email protected]/

Regards, Bernd

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot