Skip to contentSkip to conversation

MAINTAINERS: Update TTY layer for lists and recently added files

PATCH In review Tony Lindgren 5 participants 11 messages Jul 21, 2023 – Aug 3, 2023 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Update TTY layer for lists and recently added files

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
@@ -21628,11 +21628,17 @@ F:	Documentation/translations/zh_TW/
 TTY LAYER
 M:	Greg Kroah-Hartman <[email protected]>
 M:	Jiri Slaby <[email protected]>
+L:	[email protected]
+L:	[email protected]
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
 F:	Documentation/driver-api/serial/
 F:	drivers/tty/
+F:	drivers/tty/serial/serial_base.h
+F:	drivers/tty/serial/serial_base_bus.c
 F:	drivers/tty/serial/serial_core.c
+F:	drivers/tty/serial/serial_ctrl.c
+F:	drivers/tty/serial/serial_port.c
 F:	include/linux/selection.h
 F:	include/linux/serial.h
 F:	include/linux/serial_core.h
Signature · 1 line
2.41.0
#1 lore raw
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

Regards,

Tony

#3 lore raw
Quoted 10 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

thanks,

greg k-h

#4 lore raw
Quoted 7 lines · Greg Kroah-Hartman
Quoted 6 lines · Tony Lindgren
Quoted 5 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

thanks,

greg k-h

#5 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

If Jiri does not care about all the serial port device drivers, we could have the following three entries:

TTY LAYER
SERIAL CORE LAYER
SERIAL DRIVERS

Regards,

Tony

maintainer
#6 lore raw
In reply to Greg Kroah-Hartman
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

No problem. I actually didn't realize they are separate. So feel free to submit a patch, so we have a single MAINTAINTERS file entry...

Signature · 2 lines
js
suse labs
#7 lore raw
Quoted 14 lines · Jiri Slaby
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

No problem. I actually didn't realize they are separate. So feel free to submit a patch, so we have a single MAINTAINTERS file entry...

How about something like this?

Tony

8< ----------------------

MAINTAINERS +2 -13
@@ -19319,13 +19319,6 @@ F:	Documentation/devicetree/bindings/serial/serial.yaml
 F:	drivers/tty/serdev/
 F:	include/linux/serdev.h
 
-SERIAL DRIVERS
-M:	Greg Kroah-Hartman <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	Documentation/devicetree/bindings/serial/
-F:	drivers/tty/serial/
-
 SERIAL IR RECEIVER
 M:	Sean Young <[email protected]>
 L:	[email protected]
@@ -21760,20 +21753,16 @@ W:	https://github.com/srcres258/linux-doc
 T:	git git://github.com/srcres258/linux-doc.git doc-zh-tw
 F:	Documentation/translations/zh_TW/
 
-TTY LAYER
+TTY LAYER AND SERIAL DRIVERS
 M:	Greg Kroah-Hartman <[email protected]>
 M:	Jiri Slaby <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
+F:	Documentation/devicetree/bindings/serial/
 F:	Documentation/driver-api/serial/
 F:	drivers/tty/
-F:	drivers/tty/serial/serial_base.h
-F:	drivers/tty/serial/serial_base_bus.c
-F:	drivers/tty/serial/serial_core.c
-F:	drivers/tty/serial/serial_ctrl.c
-F:	drivers/tty/serial/serial_port.c
 F:	include/linux/selection.h
 F:	include/linux/serial.h
 F:	include/linux/serial_core.h
Signature · 1 line
2.41.0
#8 lore raw
Quoted 59 lines · Tony Lindgren
Quoted 14 lines · Jiri Slaby
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

No problem. I actually didn't realize they are separate. So feel free to submit a patch, so we have a single MAINTAINTERS file entry...

How about something like this?

Tony

8< ----------------------

MAINTAINERS +2 -8
@@ -19319,13 +19319,6 @@ F:	Documentation/devicetree/bindings/serial/serial.yaml
 F:	drivers/tty/serdev/
 F:	include/linux/serdev.h
 
-SERIAL DRIVERS
-M:	Greg Kroah-Hartman <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	Documentation/devicetree/bindings/serial/
-F:	drivers/tty/serial/
-
 SERIAL IR RECEIVER
 M:	Sean Young <[email protected]>
 L:	[email protected]
@@ -21760,20 +21753,16 @@ W:	https://github.com/srcres258/linux-doc
 T:	git git://github.com/srcres258/linux-doc.git doc-zh-tw
 F:	Documentation/translations/zh_TW/
 
-TTY LAYER
+TTY LAYER AND SERIAL DRIVERS
 M:	Greg Kroah-Hartman <[email protected]>
 M:	Jiri Slaby <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
+F:	Documentation/devicetree/bindings/serial/

MAINTAINERS W: https://github.com/srcres258/linux-doc · line 21768

Quoted 10 lines
MAINTAINERS +0 -5
 F:	Documentation/driver-api/serial/
 F:	drivers/tty/
-F:	drivers/tty/serial/serial_base.h
-F:	drivers/tty/serial/serial_base_bus.c
-F:	drivers/tty/serial/serial_core.c
-F:	drivers/tty/serial/serial_ctrl.c
-F:	drivers/tty/serial/serial_port.c
 F:	include/linux/selection.h
 F:	include/linux/serial.h
 F:	include/linux/serial_core.h

Fine with me.

maintainer Acked-by
#9 lore raw
In reply to Tony Lindgren
Quoted 18 lines · Tony Lindgren
Quoted 17 lines · Jiri Slaby
Quoted 16 lines · Greg Kroah-Hartman
Quoted 14 lines · Greg Kroah-Hartman
Quoted 10 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

No problem. I actually didn't realize they are separate. So feel free to submit a patch, so we have a single MAINTAINTERS file entry...

How about something like this?

Signature · 2 lines
js
suse labs
#10 lore raw
In reply to Tony Lindgren
Quoted 59 lines · Tony Lindgren
Quoted 14 lines · Jiri Slaby
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Tony Lindgren
Quoted 6 lines · Andy Shevchenko
Quoted 3 lines · Tony Lindgren

Add mailing lists for linux-serial and lkml for the TTY layer. And let's list the recently added files. This makes it easier for get_maintainer.pl to include linux-serial for patches.

Shouldn't serial_* stuff go to the "SERIAL DRIVERS" section?

Not sure if there's some reason we have "TTY LAYER" with serial_core files. If not, yeah let's move the serial files.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll take this patch, can you send a new one that removes the serial files from this entry as I don't think they are needed in here anymore.

Better yet, they should be merged probably. Although I don't know if Jiri wants to be responsible for serial stuff, that's his call...

No problem. I actually didn't realize they are separate. So feel free to submit a patch, so we have a single MAINTAINTERS file entry...

How about something like this?

Tony

8< ----------------------

MAINTAINERS +2 -8
@@ -19319,13 +19319,6 @@ F:	Documentation/devicetree/bindings/serial/serial.yaml
 F:	drivers/tty/serdev/
 F:	include/linux/serdev.h
 
-SERIAL DRIVERS
-M:	Greg Kroah-Hartman <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	Documentation/devicetree/bindings/serial/
-F:	drivers/tty/serial/
-
 SERIAL IR RECEIVER
 M:	Sean Young <[email protected]>
 L:	[email protected]
@@ -21760,20 +21753,16 @@ W:	https://github.com/srcres258/linux-doc
 T:	git git://github.com/srcres258/linux-doc.git doc-zh-tw
 F:	Documentation/translations/zh_TW/
 
-TTY LAYER
+TTY LAYER AND SERIAL DRIVERS
 M:	Greg Kroah-Hartman <[email protected]>
 M:	Jiri Slaby <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
+F:	Documentation/devicetree/bindings/serial/

MAINTAINERS W: https://github.com/srcres258/linux-doc · line 21768

Quoted 10 lines
MAINTAINERS +0 -5
 F:	Documentation/driver-api/serial/
 F:	drivers/tty/
-F:	drivers/tty/serial/serial_base.h
-F:	drivers/tty/serial/serial_base_bus.c
-F:	drivers/tty/serial/serial_core.c
-F:	drivers/tty/serial/serial_ctrl.c
-F:	drivers/tty/serial/serial_port.c
 F:	include/linux/selection.h
 F:	include/linux/serial.h
 F:	include/linux/serial_core.h

The separation of these two has always felt a bit artificial to me.

Signature · 1 line
 i.