Skip to contentSkip to conversation

gpio: mt7621: remove unnecessary call to platfrom_set_drvdata()

PATCH In review Andrei Coardos 2 participants 3 messages Jul 21, 2023 – Jul 25, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: mt7621: remove unnecessary call to platfrom_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/gpio/gpio-mt7621.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-mt7621.c +0 -1
index 93facbebb80e..c0c715167d9c 100644
@@ -315,7 +315,6 @@ mediatek_gpio_probe(struct platform_device *pdev)
 		return mtk->gpio_irq;
 
 	mtk->dev = dev;
-	platform_set_drvdata(pdev, mtk);
 
 	for (i = 0; i < MTK_BANK_CNT; i++) {
 		ret = mediatek_gpio_bank_probe(dev, i);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver.

Not true.

Quoted 4 lines
Quoted 2 lines

Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

I have to withdraw this, the patch is wrong.
NAK.

Sorry for the confusion (I have looked for the wrong pattern).

Signature · 2 lines
With Best Regards,
Andy Shevchenko