s390: use obj-y to descend into drivers/s390/
PATCH 1/1 s390: use obj-y to descend into drivers/s390/
I like to use obj-y in as many places as possible.
Change the drivers-y to obj-y. It moves the objects from drivers/s390/ to slightly lower address, but fixes the single build issue. [1]
[1]: https://lore.kernel.org/linux-kbuild/[email protected]/T/#m27f781ab60acadfed8a9e9642f30d5414a5e2df3
---
arch/s390/Makefile | 1 - drivers/Makefile | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)
arch/s390/Makefile +0 -1
@@ -119,7 +119,6 @@ export KBUILD_CFLAGS_DECOMPRESSOR OBJCOPYFLAGS := -O binary libs-y += arch/s390/lib/ -drivers-y += drivers/s390/ boot := arch/s390/boot syscalls := arch/s390/kernel/syscalls
drivers/Makefile +2 -0
@@ -195,3 +195,5 @@ obj-$(CONFIG_PECI) += peci/ obj-$(CONFIG_HTE) += hte/ obj-$(CONFIG_DRM_ACCEL) += accel/ obj-$(CONFIG_CDX_BUS) += cdx/ + +obj-$(CONFIG_S390) += s390/
Signature · 1 line
2.39.2
Christian Borntraeger
reviewerAm 21.07.23 um 15:41 schrieb Masahiro Yamada:
Quoted 1 line
I like to use obj-y in as many places as possible.
Please do not use "I like". That is just too polite.
This fixes a bug as outlined below and maybe make it a clear statement that the current use is non-standard and needs to be fixed - I think.
Quoted 36 lines
Change the drivers-y to obj-y. It moves the objects from
drivers/s390/to slightly lower address, but fixes the single build issue. [1][1]: https://lore.kernel.org/linux-kbuild/[email protected]/T/#m27f781ab60acadfed8a9e9642f30d5414a5e2df3
Signed-off-by Masahiro Yamada <[email protected]>Tested-by Jiri Slaby <[email protected]>---
arch/s390/Makefile | 1 - drivers/Makefile | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)arch/s390/Makefile +0
-1@@ -119,7 +119,6 @@ export KBUILD_CFLAGS_DECOMPRESSOR OBJCOPYFLAGS := -O binary libs-y += arch/s390/lib/ -drivers-y += drivers/s390/ boot := arch/s390/boot syscalls := arch/s390/kernel/syscallsdrivers/Makefile +2
-0@@ -195,3 +195,5 @@ obj-$(CONFIG_PECI) += peci/ obj-$(CONFIG_HTE) += hte/ obj-$(CONFIG_DRM_ACCEL) += accel/ obj-$(CONFIG_CDX_BUS) += cdx/ + +obj-$(CONFIG_S390) += s390/