Skip to contentSkip to conversation

tests/xe: Boost command streamer prefetch size

PATCH In review Matt Roper 3 participants 3 messages Jul 21, 2023

lore
Share & tools
lore

Matt Roper

author
#0 lore raw

PATCH 1/1 tests/xe: Boost command streamer prefetch size

The actual prefetch size variest by platform and by engine. MTL's RCS engine currently has the highest prefetch size of 2KB.

Bspec: 45718

---
 lib/xe/xe_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/xe/xe_ioctl.c +1 -1
index 0b5c7a4fc..1f9240cd9 100644
@@ -47,7 +47,7 @@
 
 uint32_t xe_cs_prefetch_size(int fd)
 {
-	return 512;
+	return 2048;
 }
 
 uint32_t xe_vm_create(int fd, uint32_t flags, uint64_t ext)
Signature · 1 line
2.41.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Matt Roper

The actual prefetch size variest by platform and by engine. MTL's RCS engine currently has the highest prefetch size of 2KB.

Bspec: 45718

We also need to update Xe too, in particular this function:

17 static int bb_prefetch(struct xe_gt *gt)
18 {
19 struct xe_device *xe = gt_to_xe(gt);
20
21 if (GRAPHICS_VERx100(xe) >= 1250 && !xe_gt_is_media_type(gt))
22 /*

 23                  * RCS and CCS require 1K, although other engines would be
 24                  * okay with 512.
 25                  */

26 return SZ_1K;
27 else
28 return SZ_512;
29 }

I'll post a patch and CC you.

Matt

Quoted 20 lines
---
 lib/xe/xe_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/xe/xe_ioctl.c +1 -1
index 0b5c7a4fc..1f9240cd9 100644
@@ -47,7 +47,7 @@
 
 uint32_t xe_cs_prefetch_size(int fd)
 {
-	return 512;
+	return 2048;
 }
 
 uint32_t xe_vm_create(int fd, uint32_t flags, uint64_t ext)
Signature · 1 line
2.41.0
#2 lore raw

[Intel-xe] ✗ CI.Patch_applied: failure for tests/xe: Boost command streamer prefetch size

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: tests/xe: Boost command streamer prefetch size
URL : https://patchwork.freedesktop.org/series/121151/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: === Base commit: 786d2a4f3 drm/xe: Only alloc userptr part of xe_vma for userptrs === git am output follows ===
error: lib/xe/xe_ioctl.c: does not exist in index
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: tests/xe: Boost command streamer prefetch size
Patch failed at 0001 tests/xe: Boost command streamer prefetch size When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".