Skip to contentSkip to conversation

Fix warnings occurred during compilation

PATCH In review Nikhil M Jain 2 participants 10 messages Jun 21, 2023 – Jul 21, 2023

lore
Share & tools
lore
#0 lore raw

v2 cover Fix warnings occurred during compilation

This patch series aims at fixing warnings which occur during compilation, by including required header files and using appropriate types for variables which are typecasted.

Changes in V2:
- Type cast bmp_load_addr to uintptr_t at places necessary rather than changing argument type.

Nikhil M Jain (2):
board: ti: am62x: evm: Include necessary header files
common: splash_source: Fix type casting errors.

 board/ti/am62x/evm.c   | 1 +
 common/splash_source.c | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 1/2 board: ti: am62x: evm: Include necessary header files

At the time of compilation evm.c gives below warning for implicit declaration of enable_caches, to mitigate this include cpu_func.h.

board/ti/am62x/evm.c: In function ‘spl_board_init’:
board/ti/am62x/evm.c:90:9: warning: implicit declaration of function ‘enable_caches’ [-Wimplicit-function-declaration]
90 | enable_caches();

---
V2:
- No change.

 board/ti/am62x/evm.c | 1 +
 1 file changed, 1 insertion(+)
board/ti/am62x/evm.c +1 -0
index d3c1786cd9..ad93908840 100644
@@ -12,6 +12,7 @@
 #include <init.h>
 #include <video.h>
 #include <splash.h>
+#include <cpu_func.h>
 #include <k3-ddrss.h>
 #include <fdt_support.h>
 #include <asm/io.h>
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH V2 1/2] board: ti: am62x: evm: Include necessary header files

Quoted 8 lines · Nikhil M Jain

At the time of compilation evm.c gives below warning for implicit declaration of enable_caches, to mitigate this include cpu_func.h.

board/ti/am62x/evm.c: In function ‘spl_board_init’:
board/ti/am62x/evm.c:90:9: warning: implicit declaration of function ‘enable_caches’ [-Wimplicit-function-declaration]
90 | enable_caches();

Applied to u-boot/master, thanks!

Signature · 1 line
Tom
#3 lore raw

PATCH v2 2/2 common: splash_source: Fix type casting errors

In reply to Nikhil M Jain

During compilation splash_source puts out below warning for type conversion in splash_load_fit for bmp_load_addr and fit_header. Change their type to uintptr_t to fix the warnings.

common/splash_source.c: In function ‘splash_load_fit’:
common/splash_source.c:366:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
366 | img_header = (struct legacy_img_hdr *)bmp_load_addr;
| ^
common/splash_source.c:376:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
376 | res = splash_storage_read_raw(location, (u32)fit_header, fit_size);
| ^
common/splash_source.c:401:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
401 | memmove((void *)bmp_load_addr, internal_splash_data, internal_splash_size);

The above warnings are generated if CONFIG_FIT is enabled.

---
V2:
- Type cast bmp_load_addr to uintptr_t at places necessary instead of changing argument type for splash_load_fit as done in splash_load_raw.

 common/splash_source.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/splash_source.c +3 -3
index a260137619..7223a1aae7 100644
@@ -363,7 +363,7 @@ static int splash_load_fit(struct splash_location *location, u32 bmp_load_addr)
 	if (res < 0)
 		return res;
 
-	img_header = (struct legacy_img_hdr *)bmp_load_addr;
+	img_header = (struct legacy_img_hdr *)(uintptr_t)bmp_load_addr;
 	if (image_get_magic(img_header) != FDT_MAGIC) {
 		printf("Could not find FDT magic\n");
 		return -EINVAL;
@@ -373,7 +373,7 @@ static int splash_load_fit(struct splash_location *location, u32 bmp_load_addr)
 
 	/* Read in entire FIT */
 	fit_header = (const u32 *)(bmp_load_addr + header_size);
-	res = splash_storage_read_raw(location, (u32)fit_header, fit_size);
+	res = splash_storage_read_raw(location, (uintptr_t)fit_header, fit_size);
 	if (res < 0)
 		return res;
 
@@ -398,7 +398,7 @@ static int splash_load_fit(struct splash_location *location, u32 bmp_load_addr)
 	/* Extract the splash data from FIT */
 	/* 1. Test if splash is in FIT internal data. */
 	if (!fit_image_get_data(fit_header, node_offset, &internal_splash_data, &internal_splash_size))
-		memmove((void *)bmp_load_addr, internal_splash_data, internal_splash_size);
+		memmove((void *)(uintptr_t)bmp_load_addr, internal_splash_data, internal_splash_size);
 	/* 2. Test if splash is in FIT external data with fixed position. */
 	else if (!fit_image_get_data_position(fit_header, node_offset, &external_splash_addr))
 		is_splash_external = true;
Signature · 1 line
2.34.1
#4 lore raw

Re: [PATCH V2 2/2] common: splash_source: Fix type casting errors

Quoted 14 lines · Nikhil M Jain

During compilation splash_source puts out below warning for type conversion in splash_load_fit for bmp_load_addr and fit_header. Change their type to uintptr_t to fix the warnings.

common/splash_source.c: In function ‘splash_load_fit’:
common/splash_source.c:366:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
366 | img_header = (struct legacy_img_hdr *)bmp_load_addr;
| ^
common/splash_source.c:376:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
376 | res = splash_storage_read_raw(location, (u32)fit_header, fit_size);
| ^
common/splash_source.c:401:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
401 | memmove((void *)bmp_load_addr, internal_splash_data, internal_splash_size);

Quoted 3 lines

The above warnings are generated if CONFIG_FIT is enabled.

Applied to u-boot/master, thanks!

Signature · 1 line
Tom
#5 lore raw
In reply to Nikhil M Jain

Hi Tom,

Seems like this series fell through the cracks, so a gentle reminder on this.

Quoted 8 lines · Nikhil M Jain

This patch series aims at fixing warnings which occur during compilation, by including required header files and using appropriate types for variables which are typecasted.

Changes in V2:
- Type cast bmp_load_addr to uintptr_t at places necessary rather than changing argument type.

Quoted 8 lines

Nikhil M Jain (2):
board: ti: am62x: evm: Include necessary header files
common: splash_source: Fix type casting errors.

  board/ti/am62x/evm.c   | 1 +
  common/splash_source.c | 6 +++---
  2 files changed, 4 insertions(+), 3 deletions(-)

Thanks,
Nikhil

#6 lore raw
Quoted 21 lines · Nikhil M Jain

Hi Tom,

Seems like this series fell through the cracks, so a gentle reminder on this.

Quoted 15 lines · Nikhil M Jain

This patch series aims at fixing warnings which occur during compilation, by including required header files and using appropriate types for variables which are typecasted.

Changes in V2:
- Type cast bmp_load_addr to uintptr_t at places necessary rather than changing argument type.

Nikhil M Jain (2):
board: ti: am62x: evm: Include necessary header files
common: splash_source: Fix type casting errors.

  board/ti/am62x/evm.c   | 1 +
  common/splash_source.c | 6 +++---
  2 files changed, 4 insertions(+), 3 deletions(-)

This depends on the other series that you just reposted I believe you had said before.

Signature · 1 line
Tom
#7 lore raw

Hi Tom,

Quoted 19 lines · Tom Rini
Quoted 18 lines · Nikhil M Jain

Hi Tom,

Seems like this series fell through the cracks, so a gentle reminder on this.

Quoted 12 lines · Nikhil M Jain

This patch series aims at fixing warnings which occur during compilation, by including required header files and using appropriate types for variables which are typecasted.

Changes in V2:
- Type cast bmp_load_addr to uintptr_t at places necessary rather than changing argument type.

Nikhil M Jain (2):
board: ti: am62x: evm: Include necessary header files
common: splash_source: Fix type casting errors.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
   board/ti/am62x/evm.c   | 1 +
   common/splash_source.c | 6 +++---
   2 files changed, 4 insertions(+), 3 deletions(-)

This depends on the other series that you just reposted I believe you had said before.

This series is independent and doesn't depend on the series I have reposted yesterday.

Thanks,
Nikhil

#8 lore raw
Quoted 26 lines · Nikhil M Jain

Hi Tom,

Quoted 23 lines · Tom Rini
Quoted 21 lines · Nikhil M Jain

Hi Tom,

Seems like this series fell through the cracks, so a gentle reminder on this.

Quoted 15 lines · Nikhil M Jain

This patch series aims at fixing warnings which occur during compilation, by including required header files and using appropriate types for variables which are typecasted.

Changes in V2:
- Type cast bmp_load_addr to uintptr_t at places necessary rather than changing argument type.

Nikhil M Jain (2):
board: ti: am62x: evm: Include necessary header files
common: splash_source: Fix type casting errors.

   board/ti/am62x/evm.c   | 1 +
   common/splash_source.c | 6 +++---
   2 files changed, 4 insertions(+), 3 deletions(-)
Quoted 6 lines
Quoted 3 lines

This depends on the other series that you just reposted I believe you had said before.

This series is independent and doesn't depend on the series I have reposted yesterday.

What is it against then? It didn't apply before, I could have sworn I reported.

Signature · 1 line
Tom
#9 lore raw

Hi Tom,

Quoted 31 lines · Tom Rini
Quoted 30 lines · Nikhil M Jain

Hi Tom,

Quoted 26 lines · Tom Rini
Quoted 21 lines · Nikhil M Jain

Hi Tom,

Seems like this series fell through the cracks, so a gentle reminder on this.

Quoted 15 lines · Nikhil M Jain

This patch series aims at fixing warnings which occur during compilation, by including required header files and using appropriate types for variables which are typecasted.

Changes in V2:
- Type cast bmp_load_addr to uintptr_t at places necessary rather than changing argument type.

Nikhil M Jain (2):
board: ti: am62x: evm: Include necessary header files
common: splash_source: Fix type casting errors.

board/ti/am62x/evm.c | 1 +
common/splash_source.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)

This depends on the other series that you just reposted I believe you had said before.

Quoted 6 lines
Quoted 2 lines

This series is independent and doesn't depend on the series I have reposted yesterday.

What is it against then? It didn't apply before, I could have sworn I reported.

I have checked, these patches can be applied on tip of next independently. Below are the logs.

[1] https://gist.github.com/NikMJain/336831817fc79d6bf3d512d6d2663d59

Thanks,
Nikhil