Skip to contentSkip to conversation

include: events: remove spaces after '(' and before ')'

PATCH NAK [email protected] 2 participants 2 messages Jul 19, 2023 – Jul 23, 2023 1 message not in the archive Tracing

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 include: events: remove spaces after '(' and before ')'

Fix four occurrences of the checkpatch error:

ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'

---
 include/trace/events/nmi.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
include/trace/events/nmi.h +3 -3
index 18e0411398ba..99abd0bc8ebd 100644
@@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
 	TP_ARGS(handler, delta_ns, handled),
 
 	TP_STRUCT__entry(
-		__field(	void *,		handler	)
-		__field(	s64,		delta_ns)
-		__field(	int,		handled	)
+		__field(void *,	handler)
+		__field(s64, delta_ns)
+		__field(int, handled)
 	),
 
 	TP_fast_assign(
maintainer NAK
#2 lore raw
Quoted 15 lines · On Wed, 19 Jul 2023 11:21:03 +0800 [email protected] wrote:

Fix four occurrences of the checkpatch error:

ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'

---
  include/trace/events/nmi.h | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
include/trace/events/nmi.h +0 -0
index 18e0411398ba..99abd0bc8ebd 100644

include/trace/events/nmi.h TRACE_EVENT(nmi_handler, · line 20

Quoted 9 lines
include/trace/events/nmi.h +3 -3
@@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
  	TP_ARGS(handler, delta_ns, handled),
 
  	TP_STRUCT__entry(
-		__field(	void *,		handler	)
-		__field(	s64,		delta_ns)
-		__field(	int,		handled	)
+		__field(void *,	handler)
+		__field(s64, delta_ns)
+		__field(int, handled)

NACK!

Which version looks better?

checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!

-- Steve

Quoted 3 lines
include/trace/events/nmi.h +0 -0
  	),
 
  	TP_fast_assign(