Skip to contentSkip to conversation

drm/amd: remove repeat code for mes_add_queue_pkt

PATCH In review Bob Zhou 2 participants 2 messages Jul 24, 2023

Subsystems (2)
lore
Share & tools
lore

Bob Zhou

author
#0 lore raw

PATCH 1/1 drm/amd: remove repeat code for mes_add_queue_pkt

The setting of mes_add_queue_pkt is repeat, so remove it.

---
 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +0 -4
index 8e67e965f7ea..e806331fee42 100644
@@ -210,10 +210,6 @@ static int mes_v11_0_add_hw_queue(struct amdgpu_mes *mes,
 	mes_add_queue_pkt.is_aql_queue = input->is_aql_queue;
 	mes_add_queue_pkt.gds_size = input->queue_size;
 
-	/* For KFD, gds_size is re-used for queue size (needed in MES for AQL queues) */
-	mes_add_queue_pkt.is_aql_queue = input->is_aql_queue;
-	mes_add_queue_pkt.gds_size = input->queue_size;
-
 	mes_add_queue_pkt.exclusively_scheduled = input->exclusively_scheduled;
 
 	return mes_v11_0_submit_pkt_and_poll_completion(mes,
Signature · 1 line
2.34.1
#1 lore raw

[Public]

It's better to use prefix "drm/amdgpu: ..." in subject. With it fixed, this patch is: Reviewed-by: Guchun Chen <[email protected]>

Regards,
Guchun

Quoted 36 lines

-----Original Message-----
From: Bob Zhou <[email protected]>
Sent: Monday, July 24, 2023 10:55 AM
To: [email protected]; Kim, Jonathan <[email protected]>
Cc: Chen, Guchun <[email protected]>; Zhou, Bob <[email protected]>
Subject: [PATCH] drm/amd: remove repeat code for mes_add_queue_pkt

The setting of mes_add_queue_pkt is repeat, so remove it.

---
 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +0 -1
index 8e67e965f7ea..e806331fee42 100644
@@ -210,10 +210,6 @@ static int mes_v11_0_add_hw_queue(struct
 amdgpu_mes *mes,
      mes_add_queue_pkt.is_aql_queue = input->is_aql_queue;
      mes_add_queue_pkt.gds_size = input->queue_size;
 
-     /* For KFD, gds_size is re-used for queue size (needed in MES for AQL

queues) */

drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +0 -3
-     mes_add_queue_pkt.is_aql_queue = input->is_aql_queue;
-     mes_add_queue_pkt.gds_size = input->queue_size;
-
      mes_add_queue_pkt.exclusively_scheduled = input-
Quoted 1 line

exclusively_scheduled;

return mes_v11_0_submit_pkt_and_poll_completion(mes,
--
2.34.1