Skip to contentSkip to conversation

Revert "wifi: ath6k: silence false positive -Wno-dangling-pointer warning on GCC 12"

PATCH In review Kalle Valo 1 participant 2 messages Jul 24, 2023 – Jul 26, 2023 Atheros ATH6KL wireless driver

lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

PATCH 1/1 Revert "wifi: ath6k: silence false positive -Wno-dangling-pointer warning on GCC 12"

This reverts commit bd1d129daa3ede265a880e2c6a7f91eab0f4dc62.

The dangling-pointer warnings were disabled kernel-wide by commit 49beadbd47c2 ("gcc-12: disable '-Wdangling-pointer' warning for now") for v5.19. So this hack in ath6kl is not needed anymore.

---
 drivers/net/wireless/ath/ath6kl/Makefile | 5 -----
 1 file changed, 5 deletions(-)
drivers/net/wireless/ath/ath6kl/Makefile +0 -5
index a75bfa9fd1cf..dc2b3b46781e 100644
@@ -36,11 +36,6 @@ ath6kl_core-y += wmi.o
 ath6kl_core-y += core.o
 ath6kl_core-y += recovery.o
 
-# FIXME: temporarily silence -Wdangling-pointer on non W=1+ builds
-ifndef KBUILD_EXTRA_WARN
-CFLAGS_htc_mbox.o += $(call cc-disable-warning, dangling-pointer)
-endif
-
 ath6kl_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
 ath6kl_core-$(CONFIG_ATH6KL_TRACING) += trace.o
 

base-commit: ac528649f7c63bc233cc0d33cff11f767cc666e3

Signature · 1 line
2.39.2
author
#1 lore raw
Quoted 7 lines · Kalle Valo

This reverts commit bd1d129daa3ede265a880e2c6a7f91eab0f4dc62.

The dangling-pointer warnings were disabled kernel-wide by commit 49beadbd47c2 ("gcc-12: disable '-Wdangling-pointer' warning for now") for v5.19. So this hack in ath6kl is not needed anymore.

Patch applied to wireless.git, thanks.

a1ce186db7f0 Revert "wifi: ath6k: silence false positive -Wno-dangling-pointer warning on GCC 12"

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches