Skip to contentSkip to conversation

misc_cgroup: Fix the obsolete comment around 'struct misc_res'

PATCH In review Kai Huang 2 participants 3 messages Jul 24, 2023 cgroup

lore
Share & tools
lore

Kai Huang

author
#0 lore raw

PATCH 1/1 misc_cgroup: Fix the obsolete comment around 'struct misc_res'

The comment of the 'failed' member of 'struct misc_res' is obsolete since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log flood"), which removed the 'failed' member from the structure. Remove the obsolete comment.

Also add the missing comment for the 'events' field, which should come with commit f279294b3293 ("misc_cgroup: introduce misc.events to count failures") where the 'events' member was added.

---
 include/linux/misc_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/misc_cgroup.h +1 -1
index c238207d1615..41aa213a1125 100644
@@ -31,7 +31,7 @@ struct misc_cg;
  * struct misc_res: Per cgroup per misc type resource
  * @max: Maximum limit on the resource.
  * @usage: Current usage of the resource.
- * @failed: True if charged failed for the resource in a cgroup.
+ * @events: Charge failure event counter of the resource.
  */
 struct misc_res {
 	unsigned long max;

base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c

Signature · 1 line
2.41.0
#1 lore raw
Quoted 8 lines · Kai Huang

The comment of the 'failed' member of 'struct misc_res' is obsolete since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log flood"), which removed the 'failed' member from the structure. Remove the obsolete comment.

Also add the missing comment for the 'events' field, which should come with commit f279294b3293 ("misc_cgroup: introduce misc.events to count failures") where the 'events' member was added.

This has been fixed by:
https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org/

Quoted 21 lines
---
 include/linux/misc_cgroup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/misc_cgroup.h +1 -1
index c238207d1615..41aa213a1125 100644
@@ -31,7 +31,7 @@ struct misc_cg;
  * struct misc_res: Per cgroup per misc type resource
  * @max: Maximum limit on the resource.
  * @usage: Current usage of the resource.
- * @failed: True if charged failed for the resource in a cgroup.
+ * @events: Charge failure event counter of the resource.
  */
 struct misc_res {
 	unsigned long max;

base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c

Signature · 2 lines
Thanks,
Kamalesh
author
#2 lore raw
Quoted 7 lines · Kamalesh Babulal
Quoted 5 lines · Kai Huang

The comment of the 'failed' member of 'struct misc_res' is obsolete since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log flood"), which removed the 'failed' member from the structure. Remove the obsolete comment.

Quoted 8 lines
Quoted 3 lines

Also add the missing comment for the 'events' field, which should come with commit f279294b3293 ("misc_cgroup: introduce misc.events to count failures") where the 'events' member was added.

This has been fixed by:
https://lore.kernel.org/lkml/[email protected]/

Quoted 1 line

Ah I missed this. Then please ignore this patch. Thanks!