Skip to contentSkip to conversation

scsi: ufs: qcom: remove unused variable

PATCH Applied Arnd Bergmann 5 participants 6 messages Jul 24, 2023 – Jul 31, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: qcom: remove unused variable

From: Arnd Bergmann <[email protected]>

A recent change removed the only user of a local variable that needs to now also be removed:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]

Fixes 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
---
 drivers/ufs/host/ufs-qcom.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ufs/host/ufs-qcom.c +0 -1
index 3ee5ff905f9a6..5728e94b6527b 100644
@@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
 	struct msi_desc *desc = data;
 	struct device *dev = msi_desc_to_dev(desc);
 	struct ufs_hba *hba = dev_get_drvdata(dev);
-	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
 	u32 id = desc->msi_index;
 	struct ufs_hw_queue *hwq = &hba->uhq[id];
 
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent change removed the only user of a local variable that needs to now also be removed:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]

Fixes 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
Quoted 19 lines
---
 drivers/ufs/host/ufs-qcom.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ufs/host/ufs-qcom.c +0 -1
index 3ee5ff905f9a6..5728e94b6527b 100644
@@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
 	struct msi_desc *desc = data;
 	struct device *dev = msi_desc_to_dev(desc);
 	struct ufs_hba *hba = dev_get_drvdata(dev);
-	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
 	u32 id = desc->msi_index;
 	struct ufs_hw_queue *hwq = &hba->uhq[id];
 
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent change removed the only user of a local variable that needs to now also be removed:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]

Fixes 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")

- Mani

Quoted 19 lines
---
 drivers/ufs/host/ufs-qcom.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ufs/host/ufs-qcom.c +0 -1
index 3ee5ff905f9a6..5728e94b6527b 100644
@@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
 	struct msi_desc *desc = data;
 	struct device *dev = msi_desc_to_dev(desc);
 	struct ufs_hba *hba = dev_get_drvdata(dev);
-	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
 	u32 id = desc->msi_index;
 	struct ufs_hw_queue *hwq = &hba->uhq[id];
 
Signature · 1 line
2.39.2
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Reviewed-by on v1 1/1
#3 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent change removed the only user of a local variable that needs to now also be removed:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]

Fixes 8f2b78652d055 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")

Thanks for the patch!

Quoted 19 lines
---
 drivers/ufs/host/ufs-qcom.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ufs/host/ufs-qcom.c +0 -1
index 3ee5ff905f9a6..5728e94b6527b 100644
@@ -1649,7 +1649,6 @@ static irqreturn_t ufs_qcom_mcq_esi_handler(int irq, void *data)
 	struct msi_desc *desc = data;
 	struct device *dev = msi_desc_to_dev(desc);
 	struct ufs_hba *hba = dev_get_drvdata(dev);
-	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
 	u32 id = desc->msi_index;
 	struct ufs_hw_queue *hwq = &hba->uhq[id];
 
Signature · 1 line
2.39.2
#4 lore raw
In reply to Arnd Bergmann

Arnd,

Quoted 5 lines

A recent change removed the only user of a local variable that needs to now also be removed:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]

Applied to 6.6/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#5 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

A recent change removed the only user of a local variable that needs to now also be removed:

drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: error: unused variable 'host' [-Werror=unused-variable]

[...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: ufs: qcom: remove unused variable

      https://git.kernel.org/mkp/scsi/c/65aca38b8ce7
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering