MIPS: semi-random code improvements
Subsystems (2)
cover MIPS: semi-random code improvements
Denis Orlov (21):
MIPS: addrspace: rectify ksseg segment naming
MIPS: addrspace: simplify the header
MIPS: main_entry-pbl: remove unused variable
MIPS: barebox.lds: remove extra whitespace
MIPS: reloc: mark relocate_code() as noreturn
MIPS: cpuinfo: use appropriate format specifiers in printf
MIPS: print BadVAddr CP0 register on exception
MIPS: malta: merge GT64120 headers
MIPS: pbl_macros: use .asciiz instead of .ascii + .byte 0
MIPS: malta: remove duplicated barebox magic code
MIPS: pbl: put mips_barebox_10h into ENTRY_FUNCTION
MIPS: pbl: make sure to disable interrupts/watchpoints on entry
MIPS: pbl: do enable 64-bit addressing in PBL
MIPS: clean up barebox proper entry point
MIPS: main_entry: properly set XTLB handler for 64-bit mode
MIPS: main_entry: remove exception vector array
MIPS: c-r4k: prettify code in __BUILD_BLAST_CACHE_RANGE
MIPS: c-r4k: generate blast_*cache functions via macros
MIPS: c-r4k: do flush secondary cache
MIPS: c-r4k: remove extra function declaration
MIPS: reloc: use IS_ALIGNED macro to check for an alignment
arch/mips/boards/8devices-lima/lowlevel.S | 2 +-
arch/mips/boards/dlink-dir-320/lowlevel.S | 4 +-
arch/mips/boards/img-ci20/lowlevel.S | 2 +-
arch/mips/boards/loongson-ls1b/lowlevel.S | 4 +-
arch/mips/boards/netgear-wg102/lowlevel.S | 4 +-
arch/mips/boards/qemu-malta/lowlevel.S | 17 +----
arch/mips/boards/ritmix-rzx50/lowlevel.S | 2 +-
arch/mips/boards/tplink-wdr4300/lowlevel.S | 2 +-
arch/mips/boot/main_entry-pbl.c | 4 --
arch/mips/boot/main_entry.c | 41 +++--------
arch/mips/boot/start.S | 46 -------------
arch/mips/boot/start.c | 17 +++++
arch/mips/include/asm/addrspace.h | 47 ++++++-------
arch/mips/include/asm/asm.h | 4 +-
arch/mips/include/asm/cacheops.h | 5 ++
arch/mips/include/asm/pbl_macros.h | 20 +++++-
arch/mips/include/asm/stackframe.h | 4 ++
arch/mips/lib/barebox.lds.S | 2 -
arch/mips/lib/c-r4k.c | 68 ++++++++++---------
arch/mips/lib/cpuinfo.c | 6 +-
arch/mips/lib/genex.S | 29 +++-----
arch/mips/lib/reloc.c | 6 +-
arch/mips/lib/traps.c | 3 +-
.../mips/mach-ath79/include/mach/pbl_macros.h | 4 +-
.../asm => mach-malta/include/mach}/gt64120.h | 13 ++--
.../mach-malta/include/mach/mach-gt64120.h | 17 -----
arch/mips/mach-malta/pci.c | 4 +-
27 files changed, 147 insertions(+), 230 deletions(-)
delete mode 100644 arch/mips/boot/start.S
create mode 100644 arch/mips/boot/start.c
rename arch/mips/{include/asm => mach-malta/include/mach}/gt64120.h (92%)
delete mode 100644 arch/mips/mach-malta/include/mach/mach-gt64120.hSignature · 1 line
2.41.0
PATCH 1/21 MIPS: addrspace: rectify ksseg segment naming
There was a slight confusion in macro definitions for various memory segments. In the 64-bit mode, there was CKSEG2ADDR defined without a corresponding CKSEG2 definition, which led to errors when trying to actually use it. Instead there was a CKSSEG definition that stands for exactly the same memory segment.
Change the name of this memory segment macro into KSSEG/CKSSEG for the 32/64-bit mode respectively and also rename the corresponding *ADDR macros as this is how this segment is actually named in the MIPS architecture specification. This makes the naming more consistent.
--- arch/mips/include/asm/addrspace.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/mips/include/asm/addrspace.h +5 -5
@@ -67,7 +67,7 @@#define CKSEG0ADDR (a) (CPHYSADDR(a) | CKSEG0)#define CKSEG1ADDR (a) (CPHYSADDR(a) | CKSEG1) -#define CKSEG2ADDR (a) (CPHYSADDR(a) | CKSEG2) +#define CKSSEGADDR (a) (CPHYSADDR(a) | CKSSEG)#define CKSEG3ADDR (a) (CPHYSADDR(a) | CKSEG3)/*
@@ -94,7 +94,7 @@#define CKSEG0ADDR (a) (CPHYSADDR(a) | KSEG0)#define CKSEG1ADDR (a) (CPHYSADDR(a) | KSEG1) -#define CKSEG2ADDR (a) (CPHYSADDR(a) | KSEG2) +#define CKSSEGADDR (a) (CPHYSADDR(a) | KSSEG)#define CKSEG3ADDR (a) (CPHYSADDR(a) | KSEG3)/*
@@ -102,7 +102,7 @@*/ #define KSEG0ADDR (a) (CPHYSADDR(a) | KSEG0)#define KSEG1ADDR (a) (CPHYSADDR(a) | KSEG1) -#define KSEG2ADDR (a) (CPHYSADDR(a) | KSEG2) +#define KSSEGADDR (a) (CPHYSADDR(a) | KSSEG)#define KSEG3ADDR (a) (CPHYSADDR(a) | KSEG3)/*
@@ -112,13 +112,13 @@#define KUSEG 0x00000000#define KSEG0 0x80000000#define KSEG1 0xa0000000 -#define KSEG2 0xc0000000 +#define KSSEG 0xc0000000#define KSEG3 0xe0000000#define CKUSEG 0x00000000#define CKSEG0 0x80000000#define CKSEG1 0xa0000000 -#define CKSEG2 0xc0000000 +#define CKSSEG 0xc0000000#define CKSEG3 0xe0000000#endif
Signature · 1 line
2.41.0
PATCH 2/21 MIPS: addrspace: simplify the header
In reply to Denis OrlovDeduplicate some of the definitions for 32/64-bit targets and make KSEG* 32-bit defines available for 64-bit builds, as those might still be useful in certain cases.
--- arch/mips/include/asm/addrspace.h | 45 ++++++++++++++----------------- 1 file changed, 20 insertions(+), 25 deletions(-)
arch/mips/include/asm/addrspace.h +20 -25
@@ -49,6 +49,16 @@#define XPHYSADDR (a) ((_ACAST64_(a)) & \ _CONST64_(0x000000ffffffffff)) +/* +* Memory segments (32bit kernel mode addresses) +* These are the traditional names used in the 32-bit universe. +*/ +#define KUSEG 0x00000000 +#define KSEG0 0x80000000 +#define KSEG1 0xa0000000 +#define KSSEG 0xc0000000 +#define KSEG3 0xe0000000 +#ifdef CONFIG_64BIT /*
@@ -65,11 +75,6 @@#define CKSSEG _CONST64_(0xffffffffc0000000)#define CKSEG3 _CONST64_(0xffffffffe0000000) -#define CKSEG0ADDR (a) (CPHYSADDR(a) | CKSEG0) -#define CKSEG1ADDR (a) (CPHYSADDR(a) | CKSEG1) -#define CKSSEGADDR (a) (CPHYSADDR(a) | CKSSEG) -#define CKSEG3ADDR (a) (CPHYSADDR(a) | CKSEG3) -/* * Cache modes for XKPHYS address conversion macros */
@@ -92,11 +97,6 @@#else -#define CKSEG0ADDR (a) (CPHYSADDR(a) | KSEG0) -#define CKSEG1ADDR (a) (CPHYSADDR(a) | KSEG1) -#define CKSSEGADDR (a) (CPHYSADDR(a) | KSSEG) -#define CKSEG3ADDR (a) (CPHYSADDR(a) | KSEG3) -/* * Map an address to a certain kernel segment */
@@ -105,22 +105,17 @@#define KSSEGADDR (a) (CPHYSADDR(a) | KSSEG)#define KSEG3ADDR (a) (CPHYSADDR(a) | KSEG3) -/* -* Memory segments (32bit kernel mode addresses) -* These are the traditional names used in the 32-bit universe. -*/ -#define KUSEG 0x00000000 -#define KSEG0 0x80000000 -#define KSEG1 0xa0000000 -#define KSSEG 0xc0000000 -#define KSEG3 0xe0000000 - -#define CKUSEG 0x00000000 -#define CKSEG0 0x80000000 -#define CKSEG1 0xa0000000 -#define CKSSEG 0xc0000000 -#define CKSEG3 0xe0000000 +#define CKUSEG KUSEG +#define CKSEG0 KSEG0 +#define CKSEG1 KSEG1 +#define CKSSEG KSSEG +#define CKSEG3 KSEG3#endif +#define CKSEG0ADDR (a) (CPHYSADDR(a) | CKSEG0) +#define CKSEG1ADDR (a) (CPHYSADDR(a) | CKSEG1) +#define CKSSEGADDR (a) (CPHYSADDR(a) | CKSSEG) +#define CKSEG3ADDR (a) (CPHYSADDR(a) | CKSEG3) +#endif /* _ASM_ADDRSPACE_H */
Signature · 1 line
2.41.0
PATCH 3/21 MIPS: main_entry-pbl: remove unused variable
In reply to Denis OrlovFor some reason we do set 'ttb' global variable, however we never end up using it.
--- arch/mips/boot/main_entry-pbl.c | 4 ---- 1 file changed, 4 deletions(-)
arch/mips/boot/main_entry-pbl.c +0 -4
@@ -20,16 +20,12 @@ unsigned long free_mem_end_ptr;void pbl_main_entry (void *fdt,void *fdt_end,u32 ram_size); -static unsigned long *ttb; -static void barebox_uncompress (void *compressed_start,unsigned int len) {/* set 128 KiB at the end of the MALLOC_BASE for early malloc */ free_mem_ptr =TEXT_BASE -SZ_128K ; free_mem_end_ptr = free_mem_ptr +SZ_128K ; - ttb = (void *)((free_mem_ptr -0x4000 ) & ~0x3fff ); -pbl_barebox_uncompress ((void *)TEXT_BASE , compressed_start, len); }
Signature · 1 line
2.41.0
PATCH 4/21 MIPS: barebox.lds: remove extra whitespace
In reply to Denis Orlov--- arch/mips/lib/barebox.lds.S | 2 -- 1 file changed, 2 deletions(-)
arch/mips/lib/barebox.lds.S +0 -2
@@ -3,7 +3,6 @@ * Copyright (C) 2011 Antony Pavlov <[email protected]> */ - #include <asm/barebox.lds.h> OUTPUT_ARCH(BAREBOX_OUTPUT_ARCH)
@@ -67,5 +66,4 @@ SECTIONS . = ALIGN(4); __bss_stop = .; } - }
Signature · 1 line
2.41.0
PATCH 5/21 MIPS: reloc: mark relocate_code() as noreturn
In reply to Denis OrlovAfter relocating the code we jump straight to it, with the function having an 'unreachable()' call at the end. So add an appropriate attribute.
--- arch/mips/lib/reloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/lib/reloc.c +2 -2
@@ -41,7 +41,7 @@#include <asm-generic/memory_layout.h> void main_entry (void *fdt,u32 fdt_size); -void relocate_code (void *fdt,u32 fdt_size,u32 relocaddr); +void __noreturn relocate_code (void *fdt,u32 fdt_size,u32 relocaddr);/** * read_uint() - Read an unsigned integer from the buffer
@@ -106,7 +106,7 @@ static void apply_reloc(unsigned int type, void *addr, long off) } } -void relocate_code (void *fdt,u32 fdt_size,u32 ram_size) +void __noreturn relocate_code (void *fdt,u32 fdt_size,u32 ram_size) {unsigned long addr, length, bss_len, relocaddr, new_stack;uint8_t *buf;
Signature · 1 line
2.41.0
PATCH 6/21 MIPS: cpuinfo: use appropriate format specifiers in printf
In reply to Denis Orlov--- arch/mips/lib/cpuinfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/mips/lib/cpuinfo.c +3 -3
@@ -25,12 +25,12 @@ static int do_cpuinfo(int argc, char *argv[]) icache_size = c->icache.sets * c->icache.ways * c->icache.linesz; dcache_size = c->dcache.sets * c->dcache.ways * c->dcache.linesz; -printk ("Primary instruction cache %ldkB, %s, %s, linesize %d bytes.\n" , +printk ("Primary instruction cache %ukB, %s, %s, linesize %d bytes.\n" , icache_size >>10 , c->icache.flags &MIPS_CACHE_VTAG ?"VIVT" :"VIPT" , way_string[c->icache.ways], c->icache.linesz); - printk("Primary data cache %ldkB, %s, %s, %s, linesize %d bytes\n", + printk("Primary data cache %ukB, %s, %s, %s, linesize %d bytes\n", dcache_size >> 10, way_string[c->dcache.ways], (c->dcache.flags & MIPS_CACHE_PINDEX) ? "PIPT" : "VIPT", (c->dcache.flags & MIPS_CACHE_ALIASES) ?
@@ -39,7 +39,7 @@ static int do_cpuinfo(int argc, char *argv[])if (c->scache.flags &MIPS_CACHE_NOT_PRESENT )return 0 ; scache_size = c->scache.sets * c->scache.ways * c->scache.linesz; - printk("Secondary data cache %ldkB, %s, %s, %s, linesize %d bytes\n", + printk("Secondary data cache %ukB, %s, %s, %s, linesize %d bytes\n", scache_size >> 10, way_string[c->scache.ways], (c->scache.flags & MIPS_CACHE_PINDEX) ? "PIPT" : "VIPT", (c->scache.flags & MIPS_CACHE_ALIASES) ?
Signature · 1 line
2.41.0
PATCH 7/21 MIPS: print BadVAddr CP0 register on exception
In reply to Denis OrlovThis register contains the failing address on Address Error and some TLB-related exceptions, and is useful for debugging purposes.
--- arch/mips/include/asm/stackframe.h | 4 ++++ arch/mips/lib/traps.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-)
arch/mips/include/asm/stackframe.h +4 -0
@@ -89,8 +89,10 @@#endif LONG_S v1, PT_EPC(sp) LONG_S $25, PT_R25(sp) + MFC0 v1, CP0_BADVADDR LONG_S $28, PT_R28(sp) LONG_S $31, PT_R31(sp) + LONG_S v1, PT_BVADDR(sp) .set pop .endm
@@ -157,11 +159,13 @@MTC0 v1,CP0_EPC LONG_L $31, PT_R31(sp) LONG_L $28, PT_R28(sp) + LONG_L v1, PT_BVADDR(sp) LONG_L $25, PT_R25(sp)#ifdef CONFIG_64BIT LONG_L $8, PT_R8(sp) LONG_L $9, PT_R9(sp)#endif +MTC0 v0,CP0_BADVADDR LONG_L $7, PT_R7(sp) LONG_L $6, PT_R6(sp) LONG_L $5, PT_R5(sp)
arch/mips/lib/traps.c +2 -1
@@ -153,7 +153,8 @@ static void show_regs(const struct pt_regs *regs)printf ("Status: %08x\n" , (uint32_t )regs->cp0_status);printf ("Cause : %08x\n" , (uint32_t )regs->cp0_cause); -printf ("Config: %08x\n\n" ,read_c0_config ()); +printf ("Config: %08x\n" ,read_c0_config ()); +printf ("BadVA : %0*lx\n\n" , field, regs->cp0_badvaddr); }void barebox_exc_handler (struct pt_regs *regs)
Signature · 1 line
2.41.0
PATCH 8/21 MIPS: malta: merge GT64120 headers
In reply to Denis OrlovThe various definitions related to GT64120 system controller were split between two headers: 'asm/gt64120.h' and 'mach/mach-gt64120.h'. It seems that they were taken from Linux in this form. No reason to keep it like that though, so unify them into 'mach/gt64120.h'.
---
arch/mips/boards/qemu-malta/lowlevel.S | 5 ++---
.../asm => mach-malta/include/mach}/gt64120.h | 13 ++++++++-----
.../mips/mach-malta/include/mach/mach-gt64120.h | 17 -----------------
arch/mips/mach-malta/pci.c | 4 +---
4 files changed, 11 insertions(+), 28 deletions(-)
rename arch/mips/{include/asm => mach-malta/include/mach}/gt64120.h (92%)
delete mode 100644 arch/mips/mach-malta/include/mach/mach-gt64120.harch/mips/boards/qemu-malta/lowlevel.S +2 -3
@@ -11,10 +11,9 @@ #include <asm/pbl_macros.h> #include <asm/pbl_nmon.h> #include <linux/sizes.h> - #include <asm/addrspace.h> -#include <asm/gt64120.h> -#include <mach/mach-gt64120.h> + +#include <mach/gt64120.h> #ifdef CONFIG_CPU_LITTLE_ENDIAN #define GT_CPU_TO_LE32(x) (x)
arch/mips/mach-malta/include/mach/gt64120.h renamed from arch/mips/include/asm/gt64120.h +8 -5
@@ -6,12 +6,15 @@* Maciej W. Rozycki <[email protected]> * Copyright (C) 2005 Ralf Baechle ([email protected]) */ -#ifndef _ASM_GT64120_H -#define _ASM_GT64120_H -#define MSK (n) ((1 << (n)) - 1) +#ifndef _MALTA_GT64120_H +#define _MALTA_GT64120_H -#define GT_DEF_BASE 0x14000000 +#define GT_DEF_BASE 0x14000000 +#define MIPS_GT_BASE 0x1be00000 +#define GT64120_BASE CKSEG1ADDR(MIPS_GT_BASE) + +#define MSK (n) ((1 << (n)) - 1)/* * Register offset addresses
@@ -85,4 +88,4 @@#define GT_READ (ofs) le32_to_cpu(__GT_READ(ofs))#define GT_WRITE (ofs, data) __GT_WRITE(ofs, cpu_to_le32(data)) -#endif /* _ASM_GT64120_H */ +#endif /* _MALTA_GT64120_H */
arch/mips/mach-malta/include/mach/mach-gt64120.h deleted +0 -17
@@ -1,17 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* -* This is a direct copy of the ev96100.h file, with a global -* search and replace. The numbers are the same. -* -* The reason I'm duplicating this is so that the 64120/96100 -* defines won't be confusing in the source code. -*/ -#ifndef _ASM_MACH_MIPS_MACH_GT64120_DEP_H -#define _ASM_MACH_MIPS_MACH_GT64120_DEP_H - -#define MIPS_GT_BASE 0x1be00000 - -#define GT64120_BASE CKSEG1ADDR(MIPS_GT_BASE) - -#endif /* _ASM_MACH_MIPS_MACH_GT64120_DEP_H */
arch/mips/mach-malta/pci.c +1 -3
@@ -7,11 +7,9 @@#include <mach/hardware.h> #include <asm/io.h> #include <asm/addrspace.h> -#include <linux/pci.h> -#include <asm/gt64120.h> -#include <mach/mach-gt64120.h> +#include <mach/gt64120.h> #define PCI_ACCESS_READ 0#define PCI_ACCESS_WRITE 1
Signature · 1 line
2.41.0
PATCH 9/21 MIPS: pbl_macros: use .asciiz instead of .ascii + .byte 0
In reply to Denis OrlovGAS allows to use '.asciz'/'.asciiz' instead of manually writing '.byte 0' to null-terminate the string specified in '.ascii' directive. Do just that in 'mips_barebox_10h'. The malta-specific entry code currently does the same.
--- arch/mips/include/asm/pbl_macros.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/mips/include/asm/pbl_macros.h +1 -2
@@ -170,8 +170,7 @@ nop .org 0x10 - .ascii "barebox" - .byte 0 + .asciiz "barebox" .align 4 1:
Signature · 1 line
2.41.0
PATCH 10/21 MIPS: malta: remove duplicated barebox magic code
In reply to Denis OrlovUse 'mips_barebox_10h' macro instead. Remove the comment about the same address being reserved for a Board ID as we don't really do anything about it anyway.
--- arch/mips/boards/qemu-malta/lowlevel.S | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
arch/mips/boards/qemu-malta/lowlevel.S +1 -10
@@ -31,17 +31,8 @@ #define GT_HD(x) (GT_CPU_TO_LE32(((x) >> 21) & 0x7f)) ENTRY_FUNCTION(BOARD_PBL_START) - b __start - nop - /* - On MIPS Technologies boards - 0x1fc00010 address is reserved for BoardID - */ - .org 0x10 - .asciiz "barebox" - -__start: + mips_barebox_10h mips_disable_interrupts /* cpu specific setup ... */
Signature · 1 line
2.41.0
PATCH 11/21 MIPS: pbl: put mips_barebox_10h into ENTRY_FUNCTION
In reply to Denis OrlovRemove duplicated macro calls by moving it into a common macro, as is done in ARM code. Some boards were missing this one for no good reason, it seems. Well, now they don't.
--- arch/mips/boards/8devices-lima/lowlevel.S | 2 -- arch/mips/boards/dlink-dir-320/lowlevel.S | 2 -- arch/mips/boards/loongson-ls1b/lowlevel.S | 2 -- arch/mips/boards/netgear-wg102/lowlevel.S | 2 -- arch/mips/boards/qemu-malta/lowlevel.S | 1 - arch/mips/boards/tplink-wdr4300/lowlevel.S | 2 -- arch/mips/include/asm/asm.h | 4 ++-- arch/mips/mach-ath79/include/mach/pbl_macros.h | 4 ---- 8 files changed, 2 insertions(+), 17 deletions(-)
arch/mips/boards/8devices-lima/lowlevel.S +0 -2
@@ -15,8 +15,6 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_barebox_10h - debug_ll_ath79_init hornet_mips24k_cp0_setup
arch/mips/boards/dlink-dir-320/lowlevel.S +0 -2
@@ -13,8 +13,6 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_barebox_10h - mips_disable_interrupts /* CPU/SoC specific setup ... */
arch/mips/boards/loongson-ls1b/lowlevel.S +0 -2
@@ -17,8 +17,6 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_barebox_10h - mips_disable_interrupts pbl_blt 0xbf000000 skip_pll_ram_config t0
arch/mips/boards/netgear-wg102/lowlevel.S +0 -2
@@ -14,8 +14,6 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_barebox_10h - mips_disable_interrupts pbl_ar2312_pll
arch/mips/boards/qemu-malta/lowlevel.S +0 -1
@@ -32,7 +32,6 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_barebox_10h mips_disable_interrupts /* cpu specific setup ... */
arch/mips/boards/tplink-wdr4300/lowlevel.S +0 -2
@@ -15,8 +15,6 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_barebox_10h - debug_ll_ath79_init hornet_mips24k_cp0_setup
arch/mips/include/asm/asm.h +2 -2
@@ -83,8 +83,8 @@ symbol: .frame sp, framesize, rpc .set noreorder; \ .section .text_head_entry.symbol; \ .align 4; \ - \ -EXPORT (symbol) +EXPORT (symbol) \ + mips_barebox_10h/* * ENTRY_FUNCTION_END - mark end of entry function
arch/mips/mach-ath79/include/mach/pbl_macros.h +0 -4
@@ -374,8 +374,6 @@ .set push .set noreorder - mips_barebox_10h - pbl_blt 0xbf000000 skip_pll_ram_config t8 hornet_mips24k_cp0_setup
@@ -406,8 +404,6 @@ .set push .set noreorder - mips_barebox_10h - hornet_mips24k_cp0_setup hornet_1_1_war
Signature · 1 line
2.41.0
PATCH 12/21 MIPS: pbl: make sure to disable interrupts/watchpoints on entry
In reply to Denis OrlovThe first thing that we should do on entry is to disable interrupts and watchpoints, as who knows in what state we got there. The former was not being done consistently on every board, while the latter was only being done in the barebox proper for some reason. Add a macro that combines both of those actions and ensure that it's used in every board's entry code.
--- arch/mips/boards/8devices-lima/lowlevel.S | 2 ++ arch/mips/boards/dlink-dir-320/lowlevel.S | 2 +- arch/mips/boards/img-ci20/lowlevel.S | 2 +- arch/mips/boards/loongson-ls1b/lowlevel.S | 2 +- arch/mips/boards/netgear-wg102/lowlevel.S | 2 +- arch/mips/boards/qemu-malta/lowlevel.S | 2 +- arch/mips/boards/ritmix-rzx50/lowlevel.S | 2 +- arch/mips/boards/tplink-wdr4300/lowlevel.S | 2 ++ arch/mips/include/asm/pbl_macros.h | 16 ++++++++++++++++ arch/mips/mach-ath79/include/mach/pbl_macros.h | 4 ++++ 10 files changed, 30 insertions(+), 6 deletions(-)
arch/mips/boards/8devices-lima/lowlevel.S +2 -0
@@ -15,6 +15,8 @@ ENTRY_FUNCTION(BOARD_PBL_START) + mips_cpu_setup + debug_ll_ath79_init hornet_mips24k_cp0_setup
arch/mips/boards/dlink-dir-320/lowlevel.S +1 -1
@@ -13,7 +13,7 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_disable_interrupts + mips_cpu_setup /* CPU/SoC specific setup ... */ /* ... absent */
arch/mips/boards/img-ci20/lowlevel.S +1 -1
@@ -14,7 +14,7 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_disable_interrupts + mips_cpu_setup /* CPU/SoC specific setup ... */ /* ... absent */
arch/mips/boards/loongson-ls1b/lowlevel.S +1 -1
@@ -17,7 +17,7 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_disable_interrupts + mips_cpu_setup pbl_blt 0xbf000000 skip_pll_ram_config t0
arch/mips/boards/netgear-wg102/lowlevel.S +1 -1
@@ -14,7 +14,7 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_disable_interrupts + mips_cpu_setup pbl_ar2312_pll
arch/mips/boards/qemu-malta/lowlevel.S +1 -1
@@ -32,7 +32,7 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_disable_interrupts + mips_cpu_setup /* cpu specific setup ... */ /* ... absent */
arch/mips/boards/ritmix-rzx50/lowlevel.S +1 -1
@@ -14,7 +14,7 @@ ENTRY_FUNCTION(BOARD_PBL_START) - mips_disable_interrupts + mips_cpu_setup /* CPU/SoC specific setup ... */ /* ... absent */
arch/mips/boards/tplink-wdr4300/lowlevel.S +2 -0
@@ -15,6 +15,8 @@ ENTRY_FUNCTION(BOARD_PBL_START) + mips_cpu_setup + debug_ll_ath79_init hornet_mips24k_cp0_setup
arch/mips/include/asm/pbl_macros.h +16 -0
@@ -151,6 +151,14 @@ .set pop .endm + .macro mips_disable_watchpoints + .set push + .set noreorder + mtc0 zero, CP0_WATCHLO + mtc0 zero, CP0_WATCHHI + .set pop + .endm + .macro mips64_enable_64bit_addressing #ifdef CONFIG_64BIT .set push
@@ -162,6 +170,14 @@#endif .endm + .macro mips_cpu_setup + .set push + .set noreorder +mips_disable_interrupts + mips_disable_watchpoints + .set pop + .endm + .macro mips_barebox_10h .set push .set noreorder
arch/mips/mach-ath79/include/mach/pbl_macros.h +4 -0
@@ -374,6 +374,8 @@ .set push .set noreorder + mips_cpu_setup + pbl_blt 0xbf000000 skip_pll_ram_config t8 hornet_mips24k_cp0_setup
@@ -404,6 +406,8 @@ .set push .set noreorder + mips_cpu_setup + hornet_mips24k_cp0_setup hornet_1_1_war
Signature · 1 line
2.41.0
PATCH 13/21 MIPS: pbl: do enable 64-bit addressing in PBL
In reply to Denis OrlovIt seems more reasonable to do that in PBL code that initializes all the other appropriate CP0 register bits. This also makes a corresponding call in barebox proper entry code redundant, paving the way to its removal.
--- arch/mips/include/asm/pbl_macros.h | 1 + 1 file changed, 1 insertion(+)
arch/mips/include/asm/pbl_macros.h +1 -0
@@ -175,6 +175,7 @@ .set noreorder mips_disable_interrupts mips_disable_watchpoints + mips64_enable_64bit_addressing .set pop .endm
Signature · 1 line
2.41.0
PATCH 14/21 MIPS: clean up barebox proper entry point
In reply to Denis OrlovFor MIPS, we don't actually have boards which lack PBL in the resulting image. As such, the code in _start() is mostly redundant: the stack was setup in ENTRY_FUNCTION_END, while copying the code to the link location is not needed - it should already be executing at TEXT_BASE, where we have decompressed it. Other than that, disabling interrupts with watchpoints and enabling 64-bit addressing was already moved into PBL, so we don't really need to repeat it there.
Replace the assembly implementation of _start() with the C one, as the only thing it now does is jump straight into 'relocate_code()'.
--- arch/mips/boot/start.S | 46 ------------------------------------------ arch/mips/boot/start.c | 17 ++++++++++++++++ 2 files changed, 17 insertions(+), 46 deletions(-) delete mode 100644 arch/mips/boot/start.S create mode 100644 arch/mips/boot/start.c
arch/mips/boot/start.S deleted +0 -46
@@ -1,46 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * Startup Code for MIPS CPU - * - * Copyright (C) 2011, 2015 Antony Pavlov <[email protected]> - */ - -#include <asm/pbl_macros.h> - - .set noreorder - .section ".text_entry" - .align 4 - -EXPORT(_start) - - mips_barebox_10h - - /* save dtb pointer */ - move s0, a0 - move s1, a1 - move s2, a2 - - /* disable watchpoints */ - mtc0 zero, CP0_WATCHLO - mtc0 zero, CP0_WATCHHI - - mips_disable_interrupts - - mips64_enable_64bit_addressing - - copy_to_link_location _start - - stack_setup - - /* restore dtb pointer */ - move a0, s0 - move a1, s1 - move a2, s2 - PTR_LA v0, relocate_code - jal v0 - nop - - /* No return */ -__error: - b __error - nop
arch/mips/boot/start.c new file +17 -0
@@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Startup Code for MIPS CPU +* +* Copyright (C) 2011, 2015 Antony Pavlov <[email protected]> +*/ + +#include <linux/kernel.h> + +void __noreturn _start (void *fdt,u32 fdt_size,u32 relocaddr); +void __noreturn relocate_code (void *fdt,u32 fdt_size,u32 relocaddr); + +void __noreturn __section(.text_entry) _start(void *fdt, u32 fdt_size, + u32 relocaddr) +{ +relocate_code (fdt, fdt_size, relocaddr); +}
Signature · 1 line
2.41.0
PATCH 15/21 MIPS: main_entry: properly set XTLB handler for 64-bit mode
In reply to Denis OrlovThe offset of the TLB Load exception is different when 64-bit addressing is enabled - 0x80 is used instead of 0x0. To simplify things, just copy the handler code twice, for each of the cases.
While at it, also remove the incomprehensible cpu_has_4kex check. All of the supported CPUs have MIPS R4K compatible exception handling scheme (and we even hardcode that), so what are we trying to achieve there anyway?
--- arch/mips/boot/main_entry.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/mips/boot/main_entry.c +1 -3
@@ -50,11 +50,9 @@ static void trap_init(void)set_except_vector (i, &handle_reserved); } -if (!cpu_has_4kex) -memcpy ((void *)(ebase +0x080 ), &except_vec3_generic,0x80 ); -/* FIXME: handle tlb */ memcpy ((void *)(ebase), &except_vec3_generic,0x80 ); +memcpy ((void *)(ebase +0x080 ), &except_vec3_generic,0x80 );/* unset BOOT EXCEPTION VECTOR bit */ write_c0_status (read_c0_status () & ~ST0_BEV );
Signature · 1 line
2.41.0
PATCH 16/21 MIPS: main_entry: remove exception vector array
In reply to Denis OrlovThis code must have been taken from Linux, where such a mechanism allows for an efficient exception vector replacement for board-specific code. We don't really need that. If some extensions for exception vector are to be required, this may be done inside the generic handler code anyway. As we are not using this code, it seems reasonable to just remove it.
Also properly calculate the size of the handler that we are copying into the designated vectors. Originally, we just made a copy of a fixed size, copying more than actually needed. We could have just hardcoded this value there, as the code to copy now consists of just two instructions. However it feels more safe to calculate that in code instead, so that we don't have to update this value if some code is added there in the future.
--- arch/mips/boot/main_entry.c | 39 ++++++++----------------------------- arch/mips/lib/genex.S | 29 ++++++++------------------- 2 files changed, 16 insertions(+), 52 deletions(-)
arch/mips/boot/main_entry.c +8 -31
@@ -14,45 +14,22 @@#include <asm/addrspace.h> #include <linux/sizes.h> -extern void handle_reserved (void ); +extern void exception_vec (void ); +extern void exception_vec_end (void );void main_entry (void *fdt,u32 fdt_size); -unsigned long exception_handlers[32 ]; - -static void set_except_vector (int n,void *addr) -{ -unsigned long handler = (unsigned long ) addr; - - exception_handlers[n] = handler; -} -static void trap_init (void ) { -extern char except_vec3_generic; -int i; - -unsigned long ebase; - - ebase =CKSEG1 ; - -/* -* Copy the generic exception handlers to their final destination. -* This will be overriden later as suitable for a particular -* configuration. -*/ -memcpy ((void *)(ebase +0x180 ), &except_vec3_generic,0x80 ); +const unsigned long vec_size = exception_vec_end - exception_vec; +const unsigned long ebase =CKSEG1 ; -/* -* Setup default vectors -*/ -for (i =0 ; i <=31 ; i++) { -set_except_vector (i, &handle_reserved); - } +/* copy the generic exception handlers to their final destination */ +memcpy ((void *)(ebase +0x180 ), &exception_vec, vec_size);/* FIXME: handle tlb */ -memcpy ((void *)(ebase), &except_vec3_generic,0x80 ); -memcpy ((void *)(ebase +0x080 ), &except_vec3_generic,0x80 ); +memcpy ((void *)(ebase), &exception_vec, vec_size); +memcpy ((void *)(ebase +0x80 ), &exception_vec, vec_size);/* unset BOOT EXCEPTION VECTOR bit */ write_c0_status (read_c0_status () & ~ST0_BEV );
arch/mips/lib/genex.S +8 -21
@@ -2,7 +2,6 @@ #include <asm/asm.h> #include <asm/regdef.h> -#include <asm/mipsregs.h> #include <asm/stackframe.h> .text
@@ -11,31 +10,19 @@ .set noreorder .align 5 -/* Exception vector */ -NESTED(handle_reserved, 0, sp) +NESTED(exception_vec, 0, sp) + j handle_reserved + nop +EXPORT(exception_vec_end) +END(exception_vec) + +handle_reserved: SAVE_ALL PTR_LA k0, barebox_exc_handler - jal k0 + j k0 move a0, sp - /* will never return here */ - END(handle_reserved) - -/* General exception vector */ -NESTED(except_vec3_generic, 0, sp) - .set noat - mfc0 k1, CP0_CAUSE - PTR_LA k0, exception_handlers - andi k1, k1, 0x7c - PTR_ADDU k0, k0, k1 - PTR_L k0, (k0) - nop - jr k0 - nop - END(except_vec3_generic) - .set at FEXPORT(ret_from_exception) .set noat RESTORE_ALL_AND_RET - nop .set at
Signature · 1 line
2.41.0
PATCH 17/21 MIPS: c-r4k: prettify code in __BUILD_BLAST_CACHE_RANGE
In reply to Denis OrlovEven though the original code was taken from Linux, it is quite old and crufty. Replace the 'while (1)' loop with the 'for' one, use const for constant variables and use ALIGN_DOWN macro instead of repeating its code.
--- arch/mips/lib/c-r4k.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
arch/mips/lib/c-r4k.c +5 -8
@@ -27,19 +27,16 @@ static inline void blast_##pfx##cache##_range(unsigned long start, \unsigned long end) \ { \ -unsigned long lsize = current_cpu_data.desc.linesz; \ -unsigned long addr = start & ~(lsize -1 ); \ -unsigned long aend = (end -1 ) & ~(lsize -1 ); \ +const unsigned long lsize = current_cpu_data.desc.linesz; \ +const unsigned long astart =ALIGN_DOWN (start, lsize); \ +const unsigned long aend =ALIGN_DOWN (end -1 , lsize); \ +unsigned long addr; \ \if (current_cpu_data.desc.flags &MIPS_CACHE_NOT_PRESENT ) \return ; \ \ -while (1 ) { \ +for (addr = astart; addr <= aend; addr += lsize) \cache_op (hitop, addr); \ -if (addr == aend) \ -break ; \ - addr += lsize; \ - } \ }__BUILD_BLAST_CACHE_RANGE (d, dcache, Hit_Writeback_Inv_D)
Signature · 1 line
2.41.0
PATCH 18/21 MIPS: c-r4k: generate blast_*cache functions via macros
In reply to Denis OrlovThis gets us rid of this logic repeated in 'flush_cache_all()' for each cache and allows to use blast_*cache funcs elsewhere if such a need arises.
--- arch/mips/lib/c-r4k.c | 41 ++++++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 17 deletions(-)
arch/mips/lib/c-r4k.c +24 -17
@@ -13,6 +13,8 @@#include <asm/cpu-info.h> #include <asm/bitops.h> +#define INDEX_BASE CKSEG0 +#define cache_op (op,addr) \ __asm__ __volatile__( \ " .set push \n" \
@@ -23,6 +25,23 @@ : \ : "i" (op), "R" (*(unsigned char *)(addr))) +#define __BUILD_BLAST_CACHE (pfx, desc, indexop) \ +static inline void blast_##pfx##cache(void) \ +{ \ + const unsigned long lsize = current_cpu_data.desc.linesz; \ + const unsigned long start = INDEX_BASE; \ + const unsigned long size = current_cpu_data.desc.waysize \ + * current_cpu_data.desc.ways; \ + const unsigned long aend = start + size - 1; \ + unsigned long addr; \ + \ + if (current_cpu_data.desc.flags & MIPS_CACHE_NOT_PRESENT) \ + return; \ + \ + for (addr = start; addr <= aend; addr += lsize) \ + cache_op(indexop, addr); \ +} +#define __BUILD_BLAST_CACHE_RANGE (pfx, desc, hitop) \ static inline void blast_##pfx##cache##_range(unsigned long start, \ unsigned long end) \
@@ -39,28 +58,16 @@ static inline void blast_##pfx##cache##_range(unsigned long start, \cache_op (hitop, addr); \ } +__BUILD_BLAST_CACHE(d, dcache, Index_Writeback_Inv_D) +__BUILD_BLAST_CACHE(i, icache, Index_Invalidate_I) + __BUILD_BLAST_CACHE_RANGE(d, dcache, Hit_Writeback_Inv_D) __BUILD_BLAST_CACHE_RANGE(inv_d, dcache, Hit_Invalidate_D)void flush_cache_all (void ) { -struct cpuinfo_mips *c = ¤t_cpu_data; -unsigned long lsize; -unsigned long addr; -unsigned long aend; -unsigned int icache_size, dcache_size; - - dcache_size = c->dcache.waysize * c->dcache.ways; - lsize = c->dcache.linesz; - aend = (CKSEG0 + dcache_size -1 ) & ~(lsize -1 ); -for (addr =CKSEG0 ; addr <= aend; addr += lsize) -cache_op (Index_Writeback_Inv_D, addr); - - icache_size = c->icache.waysize * c->icache.ways; - lsize = c->icache.linesz; - aend = (CKSEG0 + icache_size -1 ) & ~(lsize -1 ); -for (addr =CKSEG0 ; addr <= aend; addr += lsize) -cache_op (Index_Invalidate_I, addr); +blast_dcache (); +blast_icache ();/* secondatory cache skipped */ }
Signature · 1 line
2.41.0
PATCH 19/21 MIPS: c-r4k: do flush secondary cache
In reply to Denis OrlovEven though we probe for the secondary cache, we don't actually utilize it when flushing. It seems that the reason for this is that no MIPS board currently supported in barebox actually has secondary caches and thus requires the additional logic in handling them.
Add the required functions and calls to them. This will make it easier to add support for boards that do happen to have secondary caches.
--- arch/mips/include/asm/cacheops.h | 5 +++++ arch/mips/lib/c-r4k.c | 12 ++++++------ 2 files changed, 11 insertions(+), 6 deletions(-)
arch/mips/include/asm/cacheops.h +5 -0
@@ -12,6 +12,7 @@*/ #define Cache_I 0x00#define Cache_D 0x01 +#define Cache_SD 0x03#define Index_Writeback_Inv 0x00#define Index_Store_Tag 0x08
@@ -23,9 +24,13 @@*/ #define Index_Invalidate_I (Cache_I | Index_Writeback_Inv)#define Index_Writeback_Inv_D (Cache_D | Index_Writeback_Inv) +#define Index_Writeback_Inv_SD (Cache_SD | Index_Writeback_Inv)#define Index_Store_Tag_I (Cache_I | Index_Store_Tag)#define Index_Store_Tag_D (Cache_D | Index_Store_Tag) +#define Index_Store_Tag_SD (Cache_SD | Index_Store_Tag)#define Hit_Invalidate_D (Cache_D | Hit_Invalidate) +#define Hit_Invalidate_SD (Cache_SD | Hit_Invalidate)#define Hit_Writeback_Inv_D (Cache_D | Hit_Writeback_Inv) +#define Hit_Writeback_Inv_SD (Cache_SD | Hit_Writeback_Inv)#endif /* __ASM_CACHEOPS_H */
arch/mips/lib/c-r4k.c +6 -6
@@ -60,30 +60,30 @@ static inline void blast_##pfx##cache##_range(unsigned long start, \ __BUILD_BLAST_CACHE(d, dcache, Index_Writeback_Inv_D) __BUILD_BLAST_CACHE(i, icache, Index_Invalidate_I) +__BUILD_BLAST_CACHE(s, scache, Index_Writeback_Inv_SD) __BUILD_BLAST_CACHE_RANGE(d, dcache, Hit_Writeback_Inv_D) +__BUILD_BLAST_CACHE_RANGE(s, scache, Hit_Writeback_Inv_SD) __BUILD_BLAST_CACHE_RANGE(inv_d, dcache, Hit_Invalidate_D) +__BUILD_BLAST_CACHE_RANGE(inv_s, scache, Hit_Invalidate_SD)void flush_cache_all (void ) {blast_dcache ();blast_icache (); - -/* secondatory cache skipped */ +blast_scache (); }void dma_flush_range (unsigned long start,unsigned long end) {blast_dcache_range (start, end); - -/* secondatory cache skipped */ +blast_scache_range (start, end); }void dma_inv_range (unsigned long start,unsigned long end) {blast_inv_dcache_range (start, end); - -/* secondatory cache skipped */ +blast_inv_scache_range (start, end); }void r4k_cache_init (void );
Signature · 1 line
2.41.0
PATCH 20/21 MIPS: c-r4k: remove extra function declaration
In reply to Denis Orlov'r4k_cache_init()' is already declared in the appropriate 'asm/cache.h' header.
--- arch/mips/lib/c-r4k.c | 2 -- 1 file changed, 2 deletions(-)
arch/mips/lib/c-r4k.c +0 -2
@@ -86,8 +86,6 @@ void dma_inv_range(unsigned long start, unsigned long end)blast_inv_scache_range (start, end); } -void r4k_cache_init (void ); -static void probe_pcache (void ) {struct cpuinfo_mips *c = ¤t_cpu_data;
Signature · 1 line
2.41.0
PATCH 21/21 MIPS: reloc: use IS_ALIGNED macro to check for an alignment
In reply to Denis OrlovImproves the code readability a tiny little bit.
--- arch/mips/lib/reloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/lib/reloc.c +1 -1
@@ -133,7 +133,7 @@ void __noreturn relocate_code(void *fdt, u32 fdt_size, u32 ram_size)* space in the Barebox binary & complexity in handling them. */ off = relocaddr - (unsigned long )__image_start; -if (off &0xffff ) +if (!IS_ALIGNED (off,SZ_64K ))panic ("Mis-aligned relocation\n" );/* Copy Barebox to RAM */
Signature · 1 line
2.41.0
Sascha Hauer
AppliedQuoted 14 lines · Denis Orlov
Denis Orlov (21):
MIPS: addrspace: rectify ksseg segment naming
MIPS: addrspace: simplify the header
MIPS: main_entry-pbl: remove unused variable
MIPS:barebox.lds: remove extra whitespace
MIPS: reloc: markrelocate_code()as noreturn
MIPS: cpuinfo: use appropriate format specifiers in printf
MIPS: print BadVAddr CP0 register on exception
MIPS: malta: merge GT64120 headers
MIPS:pbl_macros: use .asciiz instead of .ascii + .byte 0
MIPS: malta: remove duplicated barebox magic code
MIPS: pbl: putmips_barebox_10hintoENTRY_FUNCTION
MIPS: pbl: make sure to disable interrupts/watchpoints on entry
MIPS: pbl: do enable 64-bit addressing in PBL
Quoted 8 lines
MIPS: clean up barebox proper entry point
MIPS:main_entry: properly set XTLB handler for 64-bit mode
MIPS:main_entry: remove exception vector array
MIPS: c-r4k: prettify code in__BUILD_BLAST_CACHE_RANGE
MIPS: c-r4k: generate blast_*cache functions via macros
MIPS: c-r4k: do flush secondary cache
MIPS: c-r4k: remove extra function declaration
MIPS: reloc: useIS_ALIGNEDmacro to check for an alignment
Applied, thanks
Sascha
Quoted 38 lines
arch/mips/boards/8devices-lima/lowlevel.S | 2 +- arch/mips/boards/dlink-dir-320/lowlevel.S | 4 +- arch/mips/boards/img-ci20/lowlevel.S | 2 +- arch/mips/boards/loongson-ls1b/lowlevel.S | 4 +- arch/mips/boards/netgear-wg102/lowlevel.S | 4 +- arch/mips/boards/qemu-malta/lowlevel.S | 17 +---- arch/mips/boards/ritmix-rzx50/lowlevel.S | 2 +- arch/mips/boards/tplink-wdr4300/lowlevel.S | 2 +- arch/mips/boot/main_entry-pbl.c | 4 -- arch/mips/boot/main_entry.c | 41 +++-------- arch/mips/boot/start.S | 46 ------------- arch/mips/boot/start.c | 17 +++++ arch/mips/include/asm/addrspace.h | 47 ++++++------- arch/mips/include/asm/asm.h | 4 +- arch/mips/include/asm/cacheops.h | 5 ++ arch/mips/include/asm/pbl_macros.h | 20 +++++- arch/mips/include/asm/stackframe.h | 4 ++ arch/mips/lib/barebox.lds.S | 2 - arch/mips/lib/c-r4k.c | 68 ++++++++++--------- arch/mips/lib/cpuinfo.c | 6 +- arch/mips/lib/genex.S | 29 +++----- arch/mips/lib/reloc.c | 6 +- arch/mips/lib/traps.c | 3 +- .../mips/mach-ath79/include/mach/pbl_macros.h | 4 +- .../asm => mach-malta/include/mach}/gt64120.h | 13 ++-- .../mach-malta/include/mach/mach-gt64120.h | 17 ----- arch/mips/mach-malta/pci.c | 4 +- 27 files changed, 147 insertions(+), 230 deletions(-) delete mode 100644 arch/mips/boot/start.S create mode 100644 arch/mips/boot/start.c rename arch/mips/{include/asm => mach-malta/include/mach}/gt64120.h (92%) delete mode 100644 arch/mips/mach-malta/include/mach/mach-gt64120.hSignature · 1 line
2.41.0
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |