Skip to contentSkip to conversation

hwmon: (hp-wmi-sensors) Initialize pevents in hp_wmi_sensors_init()

PATCH Applied James Seo 2 participants 3 messages Jul 25, 2023

Subsystems (3)
lore
Share & tools
lore

James Seo

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (hp-wmi-sensors) Initialize pevents in hp_wmi_sensors_init()

The following warning is given by the Smatch static checker:

drivers/hwmon/hp-wmi-sensors.c:1937 hp_wmi_sensors_init()
error: uninitialized symbol 'pevents'.

If there are no instances of the HPBIOS_PlatformEvents WMI object available, init_platform_events() never initializes this pointer, which may then be passed to hp_wmi_debugfs_init() uninitialized.

The impact should be limited because hp_wmi_debugfs_init() uses this pointer only if the count of HPBIOS_PlatformEvents instances is _not_ zero, while conversely, it will be uninitialized only if the count of such instances _is_ zero. However, passing it uninitialized still constitutes a bug.

---
 drivers/hwmon/hp-wmi-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/hp-wmi-sensors.c +1 -1
index 3a99cc5f44b2..17ae62f88bbf 100644
@@ -1913,7 +1913,7 @@ static bool add_event_handler(struct hp_wmi_sensors *state)
 static int hp_wmi_sensors_init(struct hp_wmi_sensors *state)
 {
 	struct hp_wmi_info *connected[HP_WMI_MAX_INSTANCES];
-	struct hp_wmi_platform_events *pevents;
+	struct hp_wmi_platform_events *pevents = NULL;
 	struct device *dev = &state->wdev->dev;
 	struct hp_wmi_info *info;
 	struct device *hwdev;

base-commit: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7

Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 15 lines · James Seo

The following warning is given by the Smatch static checker:

drivers/hwmon/hp-wmi-sensors.c:1937 hp_wmi_sensors_init()
error: uninitialized symbol 'pevents'.

If there are no instances of the HPBIOS_PlatformEvents WMI object available, init_platform_events() never initializes this pointer, which may then be passed to hp_wmi_debugfs_init() uninitialized.

The impact should be limited because hp_wmi_debugfs_init() uses this pointer only if the count of HPBIOS_PlatformEvents instances is _not_ zero, while conversely, it will be uninitialized only if the count of such instances _is_ zero. However, passing it uninitialized still constitutes a bug.

Quoted 3 lines

Applied.

Thanks,
Guenter

Quoted 20 lines
---
 drivers/hwmon/hp-wmi-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7

drivers/hwmon/hp-wmi-sensors.c +1 -1
index 3a99cc5f44b2..17ae62f88bbf 100644
@@ -1913,7 +1913,7 @@ static bool add_event_handler(struct hp_wmi_sensors *state)
 static int hp_wmi_sensors_init(struct hp_wmi_sensors *state)
 {
 	struct hp_wmi_info *connected[HP_WMI_MAX_INSTANCES];
-	struct hp_wmi_platform_events *pevents;
+	struct hp_wmi_platform_events *pevents = NULL;
 	struct device *dev = &state->wdev->dev;
 	struct hp_wmi_info *info;
 	struct device *hwdev;
maintainer Applied
#2 lore raw
In reply to James Seo
Quoted 15 lines · James Seo

The following warning is given by the Smatch static checker:

drivers/hwmon/hp-wmi-sensors.c:1937 hp_wmi_sensors_init()
error: uninitialized symbol 'pevents'.

If there are no instances of the HPBIOS_PlatformEvents WMI object available, init_platform_events() never initializes this pointer, which may then be passed to hp_wmi_debugfs_init() uninitialized.

The impact should be limited because hp_wmi_debugfs_init() uses this pointer only if the count of HPBIOS_PlatformEvents instances is _not_ zero, while conversely, it will be uninitialized only if the count of such instances _is_ zero. However, passing it uninitialized still constitutes a bug.

Quoted 3 lines

Applied.

Thanks,
Guenter

Quoted 20 lines
---
 drivers/hwmon/hp-wmi-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7

drivers/hwmon/hp-wmi-sensors.c +1 -1
index 3a99cc5f44b2..17ae62f88bbf 100644
@@ -1913,7 +1913,7 @@ static bool add_event_handler(struct hp_wmi_sensors *state)
 static int hp_wmi_sensors_init(struct hp_wmi_sensors *state)
 {
 	struct hp_wmi_info *connected[HP_WMI_MAX_INSTANCES];
-	struct hp_wmi_platform_events *pevents;
+	struct hp_wmi_platform_events *pevents = NULL;
 	struct device *dev = &state->wdev->dev;
 	struct hp_wmi_info *info;
 	struct device *hwdev;