accel/qaic: remove redundant assignment to pointer pexec
Subsystems (4)
PATCH 1/1 accel/qaic: remove redundant assignment to pointer pexec
Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed.
--- drivers/accel/qaic/qaic_data.c | 1 - 1 file changed, 1 deletion(-)
drivers/accel/qaic/qaic_data.c +0 -1
@@ -1320,7 +1320,6 @@ static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct dr user_data =u64_to_user_ptr (args->data); exec =kcalloc (args->hdr.count, size,GFP_KERNEL ); - pexec = (struct qaic_partial_execute_entry *)exec;if (!exec)return -ENOMEM ;
Signature · 1 line
2.39.2
Quoted 4 lines · Colin Ian King
Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>
Quoted 13 lines · Colin Ian King
Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>--- drivers/accel/qaic/qaic_data.c | 1 - 1 file changed, 1 deletion(-)drivers/accel/qaic/qaic_data.c +0
-0
drivers/accel/qaic/qaic_data.c static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct dr · line 1325
Quoted 7 lines
drivers/accel/qaic/qaic_data.c +0
-1@@ -1320,7 +1320,6 @@ static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct dr user_data =u64_to_user_ptr (args->data); exec =kcalloc (args->hdr.count, size,GFP_KERNEL ); - pexec = (struct qaic_partial_execute_entry *)exec;if (!exec)return -ENOMEM ;
It does look like pexec is not used in this function after it was refactored. Shouldn't the declaration at the beginning of the function also be removed?
Quoted 9 lines · Jeffrey Hugo
Quoted 8 lines · Colin Ian King
Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>---
drivers/accel/qaic/qaic_data.c| 1 -1 file changed, 1 deletion(-)
Quoted 13 lines
Quoted 11 lines
drivers/accel/qaic/qaic_data.c +0
-0@@ -1320,7 +1320,6 @@ static int __qaic_execute_bo_ioctl(struct
drm_device*dev, void *data, struct druser_data=u64_to_user_ptr(args->data); exec =kcalloc(args->hdr.count, size, GFP_KERNEL); - pexec = (structqaic_partial_execute_entry*)exec; if (!exec)
return-ENOMEM;It does look like pexec is not used in this function after it was refactored. Shouldn't the declaration at the beginning of the function also be removed?
Yeah we should remove the declaration as well. Although it is used some where to calculate its size i.e. sizeof(*pexec). We need to directly use the type in sizeof() i.e. sizeof(struct qaic_partial_execute_entry).
Quoted 26 lines · Pranjal Ramajor Asha Kanojiya
Quoted 9 lines · Jeffrey Hugo
Quoted 8 lines · Colin Ian King
Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>---
drivers/accel/qaic/qaic_data.c| 1 -1 file changed, 1 deletion(-)Quoted 13 lines
Quoted 11 lines
drivers/accel/qaic/qaic_data.c +0
-0@@ -1320,7 +1320,6 @@ static int __qaic_execute_bo_ioctl(struct
drm_device*dev, void *data, struct druser_data=u64_to_user_ptr(args->data); exec =kcalloc(args->hdr.count, size, GFP_KERNEL); - pexec = (structqaic_partial_execute_entry*)exec; if (!exec)
return-ENOMEM;It does look like pexec is not used in this function after it was refactored. Shouldn't the declaration at the beginning of the function also be removed?
Quoted 1 line
Yeah we should remove the declaration as well. Although it is used some where to calculate its size i.e.
sizeof(*pexec). We need to directly use the type insizeof()i.e.sizeof(struct qaic_partial_execute_entry).
I didn't remove the variable because of the sizeof(), but it makes sense to remove it. I'll send a V2 today