Skip to contentSkip to conversation

ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

PATCH In review Marek Vasut 3 participants 3 messages Jul 25, 2023 – Sep 4, 2023 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

This board certainly does use default 'run distro_bootcmd' boot command, make sure this is set in 'bootcmd' variable.

Fixes 970bf8603b8 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig")

---
Cc: Andreas Geisreiter <[email protected]>
Cc: Christoph Niedermaier <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]

---
 configs/dh_imx6_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/dh_imx6_defconfig +0 -1
index c3f2782f748..79e86330002 100644
@@ -37,7 +37,6 @@ CONFIG_FIT_VERBOSE=y
 CONFIG_SPL_FIT=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=3
-# CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
 CONFIG_SYS_SPL_MALLOC=y
 CONFIG_SPL_SPI_LOAD=y
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Marek Vasut

This board certainly does use default 'run distro_bootcmd' boot command, make sure this is set in 'bootcmd' variable.

Fixes 970bf8603b8 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig")

This is also:

Fixes fa2c14676c7c ("configs: Re-sync with CONFIG_DISTRO_DEFAULTS")

As that's where we set CONFIG_USE_BOOTCOMMAND=n but missed that include/configs/dh_imx6.h was defining CONFIG_BOOTCOMMAND to the default distro bootcmd. Doing a step back in time to that commit I see that this was the only case where a platform was in fact setting CONFIG_BOOTCOMMAND to "run distro_boot" instead of something custom.

Signature · 1 line
Tom
#2 lore raw

PATCH 1/1 ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

In reply to Marek Vasut
Quoted 5 lines

This board certainly does use default 'run distro_bootcmd' boot command, make sure this is set in 'bootcmd' variable.

Fixes 970bf8603b8 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig")

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================