Skip to contentSkip to conversation

tests/xe/xe_exec_store: Fix the num of placements check to run test on all engines.

PATCH In review [email protected] 3 participants 3 messages Jul 26, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/xe/xe_exec_store: Fix the num of placements check to run test on all engines.

From: Sai Gowtham Ch <[email protected]>

Intension is to submit workload on all engine instances, this change will make test to run on all engines including render and copy engines.

---
 tests/xe/xe_exec_store.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xe/xe_exec_store.c +1 -1
index ab1bde36e..fbce1aecc 100644
@@ -149,7 +149,7 @@ static void store_all(int fd, int gt, int class)
 		eci[num_placements++] = *hwe;
 	}
 
-	igt_require(num_placements > 1);
+	igt_require(num_placements);
 
 	for (i = 0; i < num_placements; i++) {
 		struct drm_xe_engine_create create = {
Signature · 1 line
2.39.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Ch, Sai Gowtham <[email protected]>
Sent: 26 July 2023 11:54
To: [email protected]; Kumar, Janga Rahul <[email protected]>; Ch, Sai Gowtham <[email protected]>
Subject: [PATCH i-g-t] tests/xe/xe_exec_store: Fix the num of placements check to run test on all engines.

Quoted 4 lines

From: Sai Gowtham Ch <[email protected]>

Intension is to submit workload on all engine instances, this change will make test to run on all engines including render and copy engines.

^including engines which have single instance.

Quoted 20 lines
---
 tests/xe/xe_exec_store.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xe/xe_exec_store.c index renamed from tests/xe/xe_exec_store.c +0 -0

ab1bde36e..fbce1aecc 100644

tests/xe/xe_exec_store.c +1 -2
@@ -149,7 +149,7 @@ static void store_all(int fd, int gt, int class)
 		eci[num_placements++] = *hwe;
 	}
 
-	igt_require(num_placements > 1);
+	igt_require(num_placements);
 
 	for (i = 0; i < num_placements; i++) {
 		struct drm_xe_engine_create create = {
--
Quoted 1 line

2.39.1

Update commit description

LGTM

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/xe/xe_exec_store: Fix the num of placements check to run test on all engines.

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: tests/xe/xe_exec_store: Fix the num of placements check to run test on all engines.
URL : https://patchwork.freedesktop.org/series/121342/
State : failure

== Summary ==

Series 121342 revision 1 was fully merged or fully failed: no git log