target/i386: Truncate ESP when exiting from long mode
RFC PATCH 1/1 target/i386: Truncate ESP when exiting from long mode
While working on some EFI boot changes for Linux/x86, I noticed that TCG deviates from bare metal when it comes to how it handles the value of the stack pointer register RSP when dropping out of long mode.
On bare metal, RSP is truncated to 32 bits, even if the code that runs in 32-bit protected mode never uses the stack at all (and uses a long jump rather than long return to switch back to long mode). This means 64-bit code cannot rely on RSP surviving any excursions into 32-bit protected mode (with paging disabled).
Let's align TCG with this behavior, so that code that relies on RSP retaining its value does not inadvertently work while bare metal does not.
Observed on Intel Ice Lake cores.
---
I used this patch locally to reproduce an issue that was reported on Ice Lake but didn't trigger in my QEMU testing.
Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
target/i386/helper.c | 1 + 1 file changed, 1 insertion(+)
target/i386/helper.c +1 -0
@@ -149,6 +149,7 @@ void cpu_x86_update_cr0(CPUX86State *env, uint32_t new_cr0) env->efer &= ~MSR_EFER_LMA ; env->hflags &= ~(HF_LMA_MASK |HF_CS64_MASK ); env->eip &=0xffffffff ; + env->regs[R_ESP] &= 0xffffffff; }#endif env->cr[0 ] = new_cr0 |CR0_ET_MASK ;
Signature · 1 line
2.39.2
Quoted 14 lines · Ard Biesheuvel
While working on some EFI boot changes for Linux/x86, I noticed that TCG deviates from bare metal when it comes to how it handles the value of the stack pointer register RSP when dropping out of long mode.
On bare metal, RSP is truncated to 32 bits, even if the code that runs in 32-bit protected mode never uses the stack at all (and uses a long jump rather than long return to switch back to long mode). This means 64-bit code cannot rely on RSP surviving any excursions into 32-bit protected mode (with paging disabled).
Let's align TCG with this behavior, so that code that relies on RSP retaining its value does not inadvertently work while bare metal does not.
Observed on Intel Ice Lake cores.
Quoted 8 lines
Cc: Paolo Bonzini<[email protected]> Cc: Richard
Henderson<[email protected]> Cc: Eduardo Habkost<[email protected]> Link:https://lore.kernel.org/all/[email protected]/ Signed-off-by: Ard Biesheuvel<[email protected]> --- I used this patch locally to reproduce an issue that was reported on Ice Lake but didn't trigger in my QEMU
testing.Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
No idea about chapter and verse, but it has the feel of being part and parcel with the
truncation of eip. While esp is always special, I suspect that none of the GPRs can be relied on carrying all bits.
I'm happy with the change though, since similar behaviour can be observed on hw.
r~
Quoted 7 lines · Richard Henderson
Quoted 3 lines · Ard Biesheuvel
Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
No idea about chapter and verse, but it has the feel of being part and parcel with the
truncation of eip. While esp is always special, I suspect that none of the GPRs can be relied on carrying all bits.
Coincidentally, I was having a gander at the newly announced APX extension [1], and happened across
3.1.4.1.2 Extended GPR Access (Direct and Indirect)
... Entering/leaving 64-bit mode via traditional (explicit) control flow does not directly alter the content of the EGPRs (EGPRs behave similar to R8-R15 in this regard).
which suggests to me that the 8 low registers are squashed to 32-bit on transition to 32-bit IA-32e mode.
I still have not found similar language in the main architecture manual.
r~
Quoted 16 lines · Richard Henderson
Quoted 8 lines · Richard Henderson
Quoted 3 lines · Ard Biesheuvel
Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
No idea about chapter and verse, but it has the feel of being part and parcel with the truncation of eip. While esp is always special, I suspect that none of the GPRs can be relied on carrying all bits.
Coincidentally, I was having a gander at the newly announced APX extension [1], and happened across
3.1.4.1.2 Extended GPR Access (Direct and Indirect)
Quoted 9 lines
... Entering/leaving 64-bit mode via traditional (explicit) control flow does not directly alter the content of the EGPRs (EGPRs behave similar to R8-R15 in this regard).
which suggests to me that the 8 low registers are squashed to 32-bit on transition to 32-bit IA-32e mode.
I still have not found similar language in the main architecture manual.
Interesting - that matches my observations on those Ice Lake cores:
RSP will be truncated, but preserving/restoring it to/from R8 across the exit from long mode works fine.
Quoted 25 lines · Ard Biesheuvel
Quoted 23 lines · Richard Henderson
Quoted 8 lines · Richard Henderson
Quoted 3 lines · Ard Biesheuvel
Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
No idea about chapter and verse, but it has the feel of being part and parcel with the truncation of eip. While esp is always special, I suspect that none of the GPRs can be relied on carrying all bits.
Coincidentally, I was having a gander at the newly announced APX extension [1], and happened across
3.1.4.1.2 Extended GPR Access (Direct and Indirect)
... Entering/leaving 64-bit mode via traditional (explicit) control flow does not directly alter the content of the EGPRs (EGPRs behave similar to R8-R15 in this regard).
which suggests to me that the 8 low registers are squashed to 32-bit on transition to 32-bit IA-32e mode.
Quoted 6 lines
Quoted 2 lines
I still have not found similar language in the main architecture manual.
Interesting - that matches my observations on those Ice Lake cores:
RSP will be truncated, but preserving/restoring it to/from R8 across the exit from long mode works fine.
Found it:
Volume 1 Basic Architecture
3.4.1.1 General-Purpose Registers in 64-Bit Mode
# Registers only available in 64-bit mode (R8-R15 and XMM8-XMM15)
# are preserved across transitions from 64-bit mode into compatibility mode # then back into 64-bit mode. However, values of R8-R15 and XMM8-XMM15 are # undefined after transitions from 64-bit mode through compatibility mode # to legacy or real mode and then back through compatibility mode to 64-bit mode.
r~
Quoted 36 lines · Richard Henderson
Quoted 25 lines · Ard Biesheuvel
Quoted 23 lines · Richard Henderson
Quoted 8 lines · Richard Henderson
Quoted 3 lines · Ard Biesheuvel
Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
No idea about chapter and verse, but it has the feel of being part and parcel with the truncation of eip. While esp is always special, I suspect that none of the GPRs can be relied on carrying all bits.
Coincidentally, I was having a gander at the newly announced APX extension [1], and happened across
3.1.4.1.2 Extended GPR Access (Direct and Indirect)
... Entering/leaving 64-bit mode via traditional (explicit) control flow does not directly alter the content of the EGPRs (EGPRs behave similar to R8-R15 in this regard).
which suggests to me that the 8 low registers are squashed to 32-bit on transition to 32-bit IA-32e mode.
Quoted 6 lines
Quoted 2 lines
I still have not found similar language in the main architecture manual.
Interesting - that matches my observations on those Ice Lake cores:
RSP will be truncated, but preserving/restoring it to/from R8 across the exit from long mode works fine.Found it:
Quoted 9 lines
Volume 1 Basic Architecture
3.4.1.1 General-Purpose Registers in 64-Bit Mode# Registers only available in 64-bit mode (R8-R15 and XMM8-XMM15)
# are preserved across transitions from 64-bit mode into compatibility mode # then back into 64-bit mode. However, values of R8-R15 and XMM8-XMM15 are # undefined after transitions from 64-bit mode through compatibility mode # to legacy or real mode and then back through compatibility mode to 64-bit mode.
Thanks. Not what I was hoping though ...
Quoted 27 lines · Richard Henderson
Quoted 16 lines · Ard Biesheuvel
While working on some EFI boot changes for Linux/x86, I noticed that TCG deviates from bare metal when it comes to how it handles the value of the stack pointer register RSP when dropping out of long mode.
On bare metal, RSP is truncated to 32 bits, even if the code that runs in 32-bit protected mode never uses the stack at all (and uses a long jump rather than long return to switch back to long mode). This means 64-bit code cannot rely on RSP surviving any excursions into 32-bit protected mode (with paging disabled).
Let's align TCG with this behavior, so that code that relies on RSP retaining its value does not inadvertently work while bare metal does not.
Observed on Intel Ice Lake cores.
Cc: Paolo Bonzini<[email protected]> Cc: Richard Henderson<[email protected]> Cc: Eduardo Habkost<[email protected]>
Quoted 8 lines
reproduce an issue that was reported on Ice Lake but didn't trigger in my QEMU testing.
Hints welcome on where the architectural behavior is specified, and in particular, whether or not other 64-bit GPRs can be relied upon to preserve their full 64-bit length values.
Quoted 8 lines
No idea about chapter and verse, but it has the feel of being part and parcel with the truncation of eip. While esp is always special, I suspect that none of the GPRs can be relied on carrying all bits.
I'm happy with the change though, since similar behaviour can be observed on hw.
I experimented with truncating all GPRs that exist in 32-bit mode, and this actually breaks kexec on Linux if it happens to load the kernel above 4G (which it appears to do reproducibly when sufficient memory is available)
This is due to the 4/5 level paging switch trampoline, which is called while RBX, RBP and RSI are live and refer to assets in memory that may reside above 4G.
I am fixing that code, but it does mean we should probably limit this change to ESP (as apparently, current hw only happens to truncate ESP but no other GPRs)