soc: starfive: remove stale Makefile entry
PATCH 1/2 soc: starfive: remove stale Makefile entry
From: Arnd Bergmann <[email protected]>
After the only starfive driver was moved out to the genpd subsystem, we get a build failure:
scripts/Makefile.build:41: drivers/soc/starfive/Makefile: No such file or directory
Reported=by: kernel test robot <[email protected]
--- drivers/soc/Makefile | 1 - 1 file changed, 1 deletion(-)
drivers/soc/Makefile +0 -1
@@ -29,7 +29,6 @@ obj-y += renesas/ obj-y += rockchip/ obj-$(CONFIG_SOC_SAMSUNG) += samsung/ obj-y += sifive/ -obj-$(CONFIG_SOC_STARFIVE) += starfive/ obj-y += sunxi/ obj-$(CONFIG_ARCH_TEGRA) += tegra/ obj-y += ti/
Signature · 1 line
2.39.2
PATCH 2/2 genpd: move owl-sps-helper.c from drivers/soc
From: Arnd Bergmann <[email protected]>
Moving only one of the two files in drivers/soc/actions to drivers/genpd caused a link failure in allmodconfig, as drivers/genpd is entered for compile testing, but drivers/soc/actions accidentally got skipped:
x86_64-linux-gnu-ld: vmlinux.o: in function `owl_sps_set_power':
owl-sps.c:(.text+0x16e259d): undefined reference to `owl_sps_set_pg'
Move the other one as well to allow build testing to work correctly.
---
drivers/genpd/actions/Makefile | 1 +
drivers/{soc => genpd}/actions/owl-sps-helper.c | 0
drivers/soc/Makefile | 1 -
drivers/soc/actions/Makefile | 3 ---
4 files changed, 1 insertion(+), 4 deletions(-)
rename drivers/{soc => genpd}/actions/owl-sps-helper.c (100%)
delete mode 100644 drivers/soc/actions/Makefiledrivers/genpd/actions/Makefile +1 -0
@@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0+ +obj-$(CONFIG_OWL_PM_DOMAINS_HELPER) += owl-sps-helper.o obj-$(CONFIG_OWL_PM_DOMAINS) += owl-sps.o
drivers/genpd/actions/owl-sps-helper.c renamed from drivers/soc/actions/owl-sps-helper.c +0 -0
drivers/soc/Makefile +0 -1
@@ -3,7 +3,6 @@ # Makefile for the Linux Kernel SOC specific device drivers. # -obj-$(CONFIG_ARCH_ACTIONS) += actions/ obj-y += apple/ obj-y += aspeed/ obj-$(CONFIG_ARCH_AT91) += atmel/
drivers/soc/actions/Makefile deleted +0 -3
@@ -1,3 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0+ - -obj-$(CONFIG_OWL_PM_DOMAINS_HELPER) += owl-sps-helper.o
Signature · 1 line
2.39.2
Re: [PATCH 2/2] genpd: move owl-sps-helper.c from drivers/soc
Quoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Moving only one of the two files in
drivers/soc/actionstodrivers/genpdcaused a link failure in allmodconfig, asdrivers/genpdis entered for compile testing, butdrivers/soc/actionsaccidentally got skipped:
Quoted 7 lines
x86_64-linux-gnu-ld: vmlinux.o: in function `owl_sps_set_power':
owl-sps.c:(.text+0x16e259d): undefined reference to `owl_sps_set_pg'Move the other one as well to allow build testing to work correctly.
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>
Thanks Arnd!
I have added this to my immutable genpd branch too:
git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git genpd_create_dir
Kind regards
Uffe
Quoted 45 lines
--- drivers/genpd/actions/Makefile | 1 + drivers/{soc => genpd}/actions/owl-sps-helper.c | 0 drivers/soc/Makefile | 1 - drivers/soc/actions/Makefile | 3 --- 4 files changed, 1 insertion(+), 4 deletions(-) rename drivers/{soc => genpd}/actions/owl-sps-helper.c (100%) delete mode 100644 drivers/soc/actions/Makefiledrivers/genpd/actions/Makefile +1
-0@@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0+ +obj-$(CONFIG_OWL_PM_DOMAINS_HELPER) += owl-sps-helper.o obj-$(CONFIG_OWL_PM_DOMAINS) += owl-sps.odrivers/genpd/actions/owl-sps-helper.c renamed from drivers/soc/actions/owl-sps-helper.c +0
-0drivers/soc/Makefile +0
-1@@ -3,7 +3,6 @@ # Makefile for the Linux Kernel SOC specific device drivers. # -obj-$(CONFIG_ARCH_ACTIONS) += actions/ obj-y += apple/ obj-y += aspeed/ obj-$(CONFIG_ARCH_AT91) += atmel/drivers/soc/actions/Makefile deleted +0
-4@@ -1,3 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0+ - -obj-$(CONFIG_OWL_PM_DOMAINS_HELPER) += owl-sps-helper.o --2.39.2
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
After the only starfive driver was moved out to the genpd subsystem, we get a build failure:
scripts/Makefile.build:41:drivers/soc/starfive/Makefile: No such file or directoryFixes f3fb16291f486 ("soc: starfive: Move the power-domain driver to the genpd dir")Reported=by: kernel test robot <[email protected]
Signed-off-by Arnd Bergmann <[email protected]>
Thanks Arnd!
I have added this to my immutable genpd branch too:
git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git genpd_create_dir
Kind regards
Uffe
Quoted 19 lines
--- drivers/soc/Makefile | 1 - 1 file changed, 1 deletion(-)drivers/soc/Makefile +0
-2@@ -29,7 +29,6 @@ obj-y += renesas/ obj-y += rockchip/ obj-$(CONFIG_SOC_SAMSUNG) += samsung/ obj-y += sifive/ -obj-$(CONFIG_SOC_STARFIVE) += starfive/ obj-y += sunxi/ obj-$(CONFIG_ARCH_TEGRA) += tegra/ obj-y += ti/ --2.39.2
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
After the only starfive driver was moved out to the genpd subsystem, we get a build failure:
scripts/Makefile.build:41:drivers/soc/starfive/Makefile: No such file or directoryFixes f3fb16291f486 ("soc: starfive: Move the power-domain driver to the genpd dir")Reported=by: kernel test robot <[email protected]
There's a - & a missing > in this tag.
Otherwise,
Reminds me, I need to also send a patch moving the Kconfig entry & delete the directory and MAINTAINERS entry.
Thanks,
Conor.