Skip to contentSkip to conversation

drm/amdgpu: Fix style issues in amdgpu_debugfs.c

PATCH In review Praful Swarnakar 3 participants 3 messages Jul 26, 2023 – Jul 27, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Fix style issues in amdgpu_debugfs.c

Fixes the following to align to linux coding style:

WARNING: Missing a blank line after declarations
WARNING: sizeof *rd should be sizeof(*rd)

Cc Christian König <[email protected]>
Cc Alex Deucher <[email protected]>
Cc Guchun Chen <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2 -1
index 00ab0b3c8277..a4faea4fa0b5 100644
@@ -375,7 +375,7 @@ static int amdgpu_debugfs_gprwave_open(struct inode *inode, struct file *file)
 {
 	struct amdgpu_debugfs_gprwave_data *rd;
 
-	rd = kzalloc(sizeof *rd, GFP_KERNEL);
+	rd = kzalloc(sizeof(*rd), GFP_KERNEL);
 	if (!rd)
 		return -ENOMEM;
 	rd->adev = file_inode(file)->i_private;
@@ -388,6 +388,7 @@ static int amdgpu_debugfs_gprwave_open(struct inode *inode, struct file *file)
 static int amdgpu_debugfs_gprwave_release(struct inode *inode, struct file *file)
 {
 	struct amdgpu_debugfs_gprwave_data *rd = file->private_data;
+
 	mutex_destroy(&rd->lock);
 	kfree(file->private_data);
 	return 0;
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 38 lines · Praful Swarnakar

Fixes the following to align to linux coding style:

WARNING: Missing a blank line after declarations
WARNING: sizeof *rd should be sizeof(*rd)

Cc Christian König <[email protected]>
Cc Alex Deucher <[email protected]>
Cc Guchun Chen <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2 -2
index 00ab0b3c8277..a4faea4fa0b5 100644
@@ -375,7 +375,7 @@ static int amdgpu_debugfs_gprwave_open(struct inode *inode, struct file *file)
 {
        struct amdgpu_debugfs_gprwave_data *rd;
 
-       rd = kzalloc(sizeof *rd, GFP_KERNEL);
+       rd = kzalloc(sizeof(*rd), GFP_KERNEL);
        if (!rd)
                return -ENOMEM;
        rd->adev = file_inode(file)->i_private;
@@ -388,6 +388,7 @@ static int amdgpu_debugfs_gprwave_open(struct inode *inode, struct file *file)
 static int amdgpu_debugfs_gprwave_release(struct inode *inode, struct file *file)
 {
        struct amdgpu_debugfs_gprwave_data *rd = file->private_data;
+
        mutex_destroy(&rd->lock);
        kfree(file->private_data);
        return 0;
--

2.25.1

Reviewed-by Reviewed-by Alex Deucher
#2 lore raw

[Public]

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Wednesday, July 26, 2023 11:59 PM
To: Swarnakar, Praful <[email protected]>
Cc: Deucher, Alexander <[email protected]>; [email protected]; Koenig, Christian <[email protected]>; Chen, Guchun <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: Fix style issues in amdgpu_debugfs.c

Quoted 39 lines · Praful Swarnakar

Fixes the following to align to linux coding style:

WARNING: Missing a blank line after declarations
WARNING: sizeof *rd should be sizeof(*rd)

Cc Christian König <[email protected]>
Cc Alex Deucher <[email protected]>
Cc Guchun Chen <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1 -1
index 00ab0b3c8277..a4faea4fa0b5 100644
@@ -375,7 +375,7 @@ static int amdgpu_debugfs_gprwave_open(struct
 inode *inode, struct file *file)  {
        struct amdgpu_debugfs_gprwave_data *rd;
 
-       rd = kzalloc(sizeof *rd, GFP_KERNEL);
+       rd = kzalloc(sizeof(*rd), GFP_KERNEL);
        if (!rd)
                return -ENOMEM;
        rd->adev = file_inode(file)->i_private; @@ -388,6 +388,7 @@

static int amdgpu_debugfs_gprwave_open(struct inode *inode, struct file *file) static int amdgpu_debugfs_gprwave_release(struct inode

*inode, struct file *file)  {
        struct amdgpu_debugfs_gprwave_data *rd = file->private_data;
+
        mutex_destroy(&rd->lock);
        kfree(file->private_data);
        return 0;

--
2.25.1