Skip to contentSkip to conversation

cifs: add missing return value check for cifs_sb_tlink

PATCH New [email protected] 1 participant 1 message Jul 26, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: add missing return value check for cifs_sb_tlink

From: Shyam Prasad N <[email protected]>

Whenever a tlink is obtained by cifs_sb_tlink, we need to check that the tlink returned is not an error. It was missing with the last change here.

Fixes b3edef6b9cd0 ("cifs: allow dumping keys for directories too")
---
 fs/smb/client/ioctl.c | 5 +++++
 1 file changed, 5 insertions(+)
fs/smb/client/ioctl.c +5 -0
index e1904b86ed96..f7160003e0ed 100644
@@ -478,6 +478,11 @@ long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg)
 			}
 			cifs_sb = CIFS_SB(inode->i_sb);
 			tlink = cifs_sb_tlink(cifs_sb);
+			if (IS_ERR(tlink)) {
+				rc = PTR_ERR(tlink);
+				break;
+			}
+
 			tcon = tlink_tcon(tlink);
 			rc = cifs_dump_full_key(tcon, (void __user *)arg);
 			cifs_put_tlink(tlink);
Signature · 1 line
2.34.1