platform/x86/amd/pmf: Fix unsigned comparison with less than zero
Subsystems (2)
PATCH 1/1 platform/x86/amd/pmf: Fix unsigned comparison with less than zero
The return value from the call to amd_pmf_get_pprof_modes() is int. However, the return value is being assigned to an unsigned char variable 'mode', so making 'mode' an int.
silence the warning:
./drivers/platform/x86/amd/pmf/sps.c:183:5-9: WARNING: Unsigned expression compared with zero: mode < 0
--- drivers/platform/x86/amd/pmf/sps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/platform/x86/amd/pmf/sps.c +2 -1
@@ -176,7 +176,8 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf)int amd_pmf_power_slider_update_event (struct amd_pmf_dev *dev) { -u8 mode, flag =0 ; +u8 flag =0 ; +int mode;int src; mode =amd_pmf_get_pprof_modes (dev);
Signature · 1 line
2.20.1.7.g153144c
Hi,
Quoted 10 lines · Yang Li
The return value from the call to
amd_pmf_get_pprof_modes()is int. However, the return value is being assigned to an unsigned char variable 'mode', so making 'mode' an int.silence the warning:
./drivers/platform/x86/amd/pmf/sps.c:183:5-9: WARNING: Unsigned expression compared with zero: mode < 0Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes
Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while.
I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle.
Regards,
Hans
Quoted 18 lines
--- drivers/platform/x86/amd/pmf/sps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/platform/x86/amd/pmf/sps.c +2
-1@@ -176,7 +176,8 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf)int amd_pmf_power_slider_update_event (struct amd_pmf_dev *dev) { -u8 mode, flag =0 ; +u8 flag =0 ; +int mode;int src; mode =amd_pmf_get_pprof_modes (dev);